* [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings
@ 2024-08-06 20:22 Rob Clark
2024-08-07 12:42 ` Stephan Gerhold
2024-08-15 20:40 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2024-08-06 20:22 UTC (permalink / raw)
To: linux-arm-msm
Cc: Stephan Gerhold, Abel Vesa, Krzysztof Kozlowski, Rob Clark,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: Rob Clark <robdclark@chromium.org>
Use the correct panel compatible, and wire up enable-gpio. It is wired
up in the same way as the x1e80100-crd.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
---
Corresponding schema update is in drm-misc-fixes
[1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02
commit: 1c4a057d01f4432704c4dc8842b6e888a91d95df
.../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 70977e9fa266..3c13331a9ef4 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -190,7 +190,6 @@ vreg_edp_3p3: regulator-edp-3p3 {
pinctrl-0 = <&edp_reg_en>;
pinctrl-names = "default";
- regulator-always-on;
regulator-boot-on;
};
@@ -592,9 +591,13 @@ &mdss_dp3 {
aux-bus {
panel {
- compatible = "edp-panel";
+ compatible = "samsung,atna45dc02", "samsung,atna33xc20";
+ enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
power-supply = <&vreg_edp_3p3>;
+ pinctrl-0 = <&edp_bl_en>;
+ pinctrl-names = "default";
+
port {
edp_panel_in: endpoint {
remote-endpoint = <&mdss_dp3_out>;
@@ -669,6 +672,16 @@ &pcie6a_phy {
status = "okay";
};
+&pmc8380_3_gpios {
+ edp_bl_en: edp-bl-en-state {
+ pins = "gpio4";
+ function = "normal";
+ power-source = <0>;
+ input-disable;
+ output-enable;
+ };
+};
+
&qupv3_0 {
status = "okay";
};
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings
2024-08-06 20:22 [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings Rob Clark
@ 2024-08-07 12:42 ` Stephan Gerhold
2024-08-15 20:40 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Stephan Gerhold @ 2024-08-07 12:42 UTC (permalink / raw)
To: Rob Clark
Cc: linux-arm-msm, Abel Vesa, Krzysztof Kozlowski, Rob Clark,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Tue, Aug 06, 2024 at 01:22:17PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Use the correct panel compatible, and wire up enable-gpio. It is wired
> up in the same way as the x1e80100-crd.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Thanks for the update!
> ---
> Corresponding schema update is in drm-misc-fixes
>
> [1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02
> commit: 1c4a057d01f4432704c4dc8842b6e888a91d95df
>
> .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index 70977e9fa266..3c13331a9ef4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -190,7 +190,6 @@ vreg_edp_3p3: regulator-edp-3p3 {
> pinctrl-0 = <&edp_reg_en>;
> pinctrl-names = "default";
>
> - regulator-always-on;
> regulator-boot-on;
> };
>
> @@ -592,9 +591,13 @@ &mdss_dp3 {
>
> aux-bus {
> panel {
> - compatible = "edp-panel";
> + compatible = "samsung,atna45dc02", "samsung,atna33xc20";
> + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
> power-supply = <&vreg_edp_3p3>;
>
> + pinctrl-0 = <&edp_bl_en>;
> + pinctrl-names = "default";
> +
> port {
> edp_panel_in: endpoint {
> remote-endpoint = <&mdss_dp3_out>;
> @@ -669,6 +672,16 @@ &pcie6a_phy {
> status = "okay";
> };
>
> +&pmc8380_3_gpios {
> + edp_bl_en: edp-bl-en-state {
> + pins = "gpio4";
> + function = "normal";
> + power-source = <0>;
> + input-disable;
> + output-enable;
> + };
> +};
> +
> &qupv3_0 {
> status = "okay";
> };
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings
2024-08-06 20:22 [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings Rob Clark
2024-08-07 12:42 ` Stephan Gerhold
@ 2024-08-15 20:40 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-08-15 20:40 UTC (permalink / raw)
To: linux-arm-msm, Rob Clark
Cc: Stephan Gerhold, Abel Vesa, Krzysztof Kozlowski, Rob Clark,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel, Konrad Dybcio
On Tue, 06 Aug 2024 13:22:17 -0700, Rob Clark wrote:
> Use the correct panel compatible, and wire up enable-gpio. It is wired
> up in the same way as the x1e80100-crd.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: x1e80100-yoga: Update panel bindings
commit: c46eef29907bc1644e0ded4b99bbd0be5ccde9a7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-15 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-06 20:22 [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings Rob Clark
2024-08-07 12:42 ` Stephan Gerhold
2024-08-15 20:40 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).