Re: [PATCH 2/4] dt-bindings: media: camss: Add qcom,sdm670-camss

[Richard Acayan <mailingradian@gmail.com>]

On Tue, Aug 06, 2024 at 11:57:38PM +0100, Bryan O'Donoghue wrote:
> On 06/08/2024 23:42, Richard Acayan wrote:
>> Add the camera subsystem for the Snapdragon 670.
>> 
>> Adapted from SC8280XP camera subsystem.
>
> Hmm, I'd like a little bit more of a commit log here. sdm670 as found in
> "spiffy device X" contains N CSIDs, Y VFEs.
>
> Its not super important but a description that is device specific would be
> nice.

Ok.

>> 
>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>> ---
>>   .../bindings/media/qcom,sdm670-camss.yaml     | 353 ++++++++++++++++++
>>   1 file changed, 353 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
>> new file mode 100644
>> index 000000000000..543fad1b5cd7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
>> @@ -0,0 +1,353 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
>> +
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/qcom,sdm670-camss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm SDM670 Camera Subsystem (CAMSS)
>> +
>> +maintainers:
>> +  - Richard Acayan <mailingradian@gmail.com>
>> +
>> +description:
>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,sdm670-camss
>> +
>> +  clocks:
>> +    maxItems: 33
>> +
>> +  clock-names:
>> +    items:
>> +      - const: camnoc_axi
>> +      - const: cpas_ahb
>> +      - const: cphy_rx_src
>> +      - const: csi0
>> +      - const: csi0_src
>
> These "_src" clocks should be dropped.

Hi, this will require dedicated definitions for SDM670 in the driver, as
SDM845 lists (and requires) the src clocks. It's certainly possible to
do so, but I'm just not sure if it's what you expected.

Or I could send an RFT to drop them from SDM845...