From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49C9818CBE5 for ; Thu, 8 Aug 2024 15:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723129720; cv=none; b=ChEpIt4FjFO2eeDP5zjV7qqmt8c9Sn0wLpARRKBpCQz1WEtgapzHcX9xJ0VVl3G3UOMYz4lDBWjdfWJXe3lQX/HaBzP6Un8GRHmNLb8kUVmnLQyx2CLYWRfCGmkIaRR1ylR2eSXLHczAjHQJSxGjNUCFN+MLpcJO6xmwkLBKtj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723129720; c=relaxed/simple; bh=w4R25BPgS5phZlT1l4auPlaUzCSJiEfnbiR3AJUJ7Qw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gxmNAdzczhoHb4URBeUgK498aaLrLEoBTLuUe4YedJP7+HExWgfveLBKpxGgC3bOgyKE3PkWEdeoIBU+9LnBsBzbqeAzYA7fhQpW/he5/bLtfDvVLftsgswAJKrl7DNOR3ohX4n8+6HNhc/oj1Zwk/SBCcSTfMRJKvs5ehs4Tes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=NTHOAgwn; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="NTHOAgwn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=Ve8L lTcqJOjzP7isM+JdryITAP9551O9yPbo/RFx+AU=; b=NTHOAgwnCwb/3N10kJrv tPOddDACm+HtzA1Bzk6OXNusk13dgX5VKkhoQqkYDb2i+MHUa/QwU1TP6beXiP3C +V0YgTnCOoW22E2bxmzCRLAzjsEe0GtMax7U5yGgQOsNNpfRvDME1NYaJZbrdfck cbk5bCVBBLwrfJJGDTM/fwVQTFaYpB61jPzrbx4FiL0JBYZOrxEH9fIwNYosaBBj nbm2lk9Fue95NRB/ElRVU3EjWiC29CSEH+lUQNHcDyQX3SoWM5SFXw9zl8Ng43FE thQZMGq+VNYgLn8bET1rmqiesdAh1FauHNANjgOGjuBL+a1Js8EHYkV9fY0A82L8 NQ== Received: (qmail 351774 invoked from network); 8 Aug 2024 17:08:35 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 8 Aug 2024 17:08:35 +0200 X-UD-Smtp-Session: l3s3148p1@jOCZZi0f1URtKPBr Date: Thu, 8 Aug 2024 17:08:35 +0200 From: Wolfram Sang To: Claudiu Cc: chris.brandt@renesas.com, andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: Re: [PATCH v3 04/11] i2c: riic: Enable runtime PM autosuspend support Message-ID: Mail-Followup-To: Wolfram Sang , Claudiu , chris.brandt@renesas.com, andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20240711115207.2843133-1-claudiu.beznea.uj@bp.renesas.com> <20240711115207.2843133-5-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wyJIwvqvaRJYLemY" Content-Disposition: inline In-Reply-To: <20240711115207.2843133-5-claudiu.beznea.uj@bp.renesas.com> --wyJIwvqvaRJYLemY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 11, 2024 at 02:52:00PM +0300, Claudiu wrote: > From: Claudiu Beznea >=20 > Enable runtime PM autosuspend support for the RIIC driver. With this, in > case there are consecutive xfer requests the device wouldn't be runtime > enabled/disabled after each consecutive xfer but after the > the delay configured by user. With this, we can avoid touching hardware > registers involved in runtime PM suspend/resume saving in this way some > cycles. The default chosen autosuspend delay is zero to keep the > previous driver behavior. >=20 > Signed-off-by: Claudiu Beznea Basically, OK with me. I'd just like a comment here like: /* Default 0 to save power. Can be overridden via sysfs for lower latency */ > + pm_runtime_set_autosuspend_delay(dev, 0); > + pm_runtime_use_autosuspend(dev); Other than that: Reviewed-by: Wolfram Sang --wyJIwvqvaRJYLemY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAma033MACgkQFA3kzBSg KbaT4A//XCkpAcVYza+MfVUBCF0Nxci3BvJ7/aNEWvqASBIdFHWQFMzCVeJi1qcJ TvZcxxo8EbcFdfF1W3Of6OYEZgbn1AhJhPRhCgDEo6j7kKyBhtXOOSXH4nTNh7sn 21U1ztQRmSFnX1HzWrB5V+du2pzclFXESPP5dqUmxJe5fPqUkCXGvMOJ4mWCDO5b J/+3aMV48yWxbiSkMgGL1Z9hDiUGxFLgftfVN1F5mhdNakY+nfsqjASF78DanwB8 w/JkXjCQrkqWVUmazmCy2hLJ9PD/gN1XipFgS/8g7ZYzOBya5P9f+/Nh4OO9VfPd JpoiOWLcOcRf26DjIsuybQJH2TqC0v+icwinbR8s55ekrWMjLeZS9q9GsKdSqEwh DBJVuMWbbEu2OMjDBL2aKGcrKSJEyFBHAd0USDISyEudbHt3duThmgfg179UMZ0Z z+H+R85V81f5KqgJxpod4Qhu06gHwChRBDTzcfszNRhg/qUsY+GoYM7ngrN5sOHN lniuB/pWjwxS1rRkIijq9+FfwJl8Tp8PUtd5UD4YSVr9FsvbhBaWGJ2seES0pOfB KFRfhtH4tAmIp29KmT9qQS/3LQWo/11r1VBtZpTkawKYauWHFgSSMAToQDSeo3CG NceoaaBR50JCS+AellLOfGeTJVDUgdy0fOJCKQLpO6zbYC066xU= =7V5+ -----END PGP SIGNATURE----- --wyJIwvqvaRJYLemY--