* [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes
@ 2024-07-17 13:50 Alexander Stein
2024-07-17 13:50 ` [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location Alexander Stein
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alexander Stein @ 2024-07-17 13:50 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Alexander Stein, devicetree, imx, linux-arm-kernel, linux-kernel
These properties are required by i2c-controller.yaml bindings.
Add them on SoC level, rather than on board level.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index f7a91d43a0ffe..3f521441faf7e 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -303,6 +303,8 @@ adma_pwm_lpcg: clock-controller@5a590000 {
i2c0: i2c@5a800000 {
reg = <0x5a800000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&i2c0_lpcg IMX_LPCG_CLK_0>,
<&i2c0_lpcg IMX_LPCG_CLK_4>;
@@ -315,6 +317,8 @@ i2c0: i2c@5a800000 {
i2c1: i2c@5a810000 {
reg = <0x5a810000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&i2c1_lpcg IMX_LPCG_CLK_0>,
<&i2c1_lpcg IMX_LPCG_CLK_4>;
@@ -327,6 +331,8 @@ i2c1: i2c@5a810000 {
i2c2: i2c@5a820000 {
reg = <0x5a820000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&i2c2_lpcg IMX_LPCG_CLK_0>,
<&i2c2_lpcg IMX_LPCG_CLK_4>;
@@ -339,6 +345,8 @@ i2c2: i2c@5a820000 {
i2c3: i2c@5a830000 {
reg = <0x5a830000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&i2c3_lpcg IMX_LPCG_CLK_0>,
<&i2c3_lpcg IMX_LPCG_CLK_4>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location
2024-07-17 13:50 [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Alexander Stein
@ 2024-07-17 13:50 ` Alexander Stein
2024-07-17 14:36 ` Frank Li
2024-07-17 14:35 ` [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Frank Li
2024-08-12 11:21 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2024-07-17 13:50 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Frank Li
Cc: Alexander Stein, devicetree, imx, linux-arm-kernel, linux-kernel
Align the closing brace to opening line.
Fixes: 1db044b25d2e ("arm64: dts: imx8dxl: add adc0 support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index 3f521441faf7e..1ee9496c988c5 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -370,7 +370,7 @@ adc0: adc@5a880000 {
assigned-clock-rates = <24000000>;
power-domains = <&pd IMX_SC_R_ADC_0>;
status = "disabled";
- };
+ };
adc1: adc@5a890000 {
compatible = "nxp,imx8qxp-adc";
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes
2024-07-17 13:50 [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Alexander Stein
2024-07-17 13:50 ` [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location Alexander Stein
@ 2024-07-17 14:35 ` Frank Li
2024-08-12 11:21 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2024-07-17 14:35 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Wed, Jul 17, 2024 at 03:50:25PM +0200, Alexander Stein wrote:
> These properties are required by i2c-controller.yaml bindings.
> Add them on SoC level, rather than on board level.
>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index f7a91d43a0ffe..3f521441faf7e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -303,6 +303,8 @@ adma_pwm_lpcg: clock-controller@5a590000 {
>
> i2c0: i2c@5a800000 {
> reg = <0x5a800000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&i2c0_lpcg IMX_LPCG_CLK_0>,
> <&i2c0_lpcg IMX_LPCG_CLK_4>;
> @@ -315,6 +317,8 @@ i2c0: i2c@5a800000 {
>
> i2c1: i2c@5a810000 {
> reg = <0x5a810000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&i2c1_lpcg IMX_LPCG_CLK_0>,
> <&i2c1_lpcg IMX_LPCG_CLK_4>;
> @@ -327,6 +331,8 @@ i2c1: i2c@5a810000 {
>
> i2c2: i2c@5a820000 {
> reg = <0x5a820000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&i2c2_lpcg IMX_LPCG_CLK_0>,
> <&i2c2_lpcg IMX_LPCG_CLK_4>;
> @@ -339,6 +345,8 @@ i2c2: i2c@5a820000 {
>
> i2c3: i2c@5a830000 {
> reg = <0x5a830000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&i2c3_lpcg IMX_LPCG_CLK_0>,
> <&i2c3_lpcg IMX_LPCG_CLK_4>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location
2024-07-17 13:50 ` [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location Alexander Stein
@ 2024-07-17 14:36 ` Frank Li
0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2024-07-17 14:36 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Wed, Jul 17, 2024 at 03:50:26PM +0200, Alexander Stein wrote:
> Align the closing brace to opening line.
>
> Fixes: 1db044b25d2e ("arm64: dts: imx8dxl: add adc0 support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index 3f521441faf7e..1ee9496c988c5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -370,7 +370,7 @@ adc0: adc@5a880000 {
> assigned-clock-rates = <24000000>;
> power-domains = <&pd IMX_SC_R_ADC_0>;
> status = "disabled";
> - };
> + };
>
> adc1: adc@5a890000 {
> compatible = "nxp,imx8qxp-adc";
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes
2024-07-17 13:50 [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Alexander Stein
2024-07-17 13:50 ` [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location Alexander Stein
2024-07-17 14:35 ` [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Frank Li
@ 2024-08-12 11:21 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2024-08-12 11:21 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Wed, Jul 17, 2024 at 03:50:25PM +0200, Alexander Stein wrote:
> These properties are required by i2c-controller.yaml bindings.
> Add them on SoC level, rather than on board level.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied both, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-12 11:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-17 13:50 [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Alexander Stein
2024-07-17 13:50 ` [PATCH 2/2] arm64: dts: imx8-ss-dma: Fix adc0 closing brace location Alexander Stein
2024-07-17 14:36 ` Frank Li
2024-07-17 14:35 ` [PATCH 1/2] arm64: dts: imx8-ss-dma: add #address-cells and #size-cells to LPI2C nodes Frank Li
2024-08-12 11:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).