From: Frank Li <Frank.li@nxp.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
<linux-pci@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type
Date: Mon, 12 Aug 2024 12:33:02 -0400 [thread overview]
Message-ID: <Zro5Pi2LbnCjBiNA@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240701221612.2112668-1-Frank.Li@nxp.com>
On Mon, Jul 01, 2024 at 06:16:12PM -0400, Frank Li wrote:
> fsl,pcie-scfg actually need an argument when there are more than one PCIe
> instances. Change it to phandle-array and use items to describe each field
> means.
>
> Fix below warning.
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long
> from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Bjorn and Krzysztof Wilczyński:
Can you take care this patch? Rob already acked.
Frank
> Change form v2 to v3
> - remove minItems because all dts use one argument.
> Change from v1 to v2
> - update commit message.
> ---
> .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
> index 793986c5af7ff..741b96defcc95 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
> @@ -43,10 +43,15 @@ properties:
> - const: config
>
> fsl,pcie-scfg:
> - $ref: /schemas/types.yaml#/definitions/phandle
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> description: A phandle to the SCFG device node. The second entry is the
> physical PCIe controller index starting from '0'. This is used to get
> SCFG PEXN registers.
> + items:
> + items:
> + - description: A phandle to the SCFG device node
> + - description: PCIe controller index starting from '0'
> + maxItems: 1
>
> big-endian:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-08-12 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 22:16 [PATCH v3 1/1] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type Frank Li
2024-07-03 17:27 ` Rob Herring
2024-08-22 17:05 ` Frank Li
2024-08-12 16:33 ` Frank Li [this message]
2024-08-26 16:05 ` Rob Herring (Arm)
2024-09-04 15:12 ` Frank Li
2024-09-04 15:03 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zro5Pi2LbnCjBiNA@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox