From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B4263A9 for ; Tue, 13 Aug 2024 00:45:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723509936; cv=none; b=fK3QO6YC0rT//kgzHCGOKl0S2eiGXAqUjoq2HK/kMioiinOUizY1ChWa+5i1r73+HMZySShWpmzJrtOU7DLgyIK19XuwmgmYiFnNXBcqtKxpqztvZX0F3eZV359wUejMeer0sKTJ2cTw8bzFzwRkkpvBx7mbpivVm2nwvdWUND0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723509936; c=relaxed/simple; bh=1sBgTIKoJ6AjCZ9d/4YTN6ajHX8hpg8Jnb/EcKKS2RQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eQij6Ptj+wjKWpE62Nr3cDp5UY34X8tWZcJ6rE4JCHUqTW3G7p9ZLBC3cvbM3cdDeEvjWeAqYHOG6NNPOWpB9+4LX7Q+IHHvxrOE1nE7kTMV0xYqZyZmKFRNPX1SAzUFapkSteQeMFBGuJQb7EgXI5jthkSzeDo/bluC/MBZ6TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=fgqw/8UX; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="fgqw/8UX" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1fc65329979so45106465ad.0 for ; Mon, 12 Aug 2024 17:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1723509934; x=1724114734; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1Beo73jI8KH5p03NxQPXLaupS8Ut84TtJmPr0+Y+H6g=; b=fgqw/8UX/rOFKnGO4Qw7UTr3fPRrjchwCWqqDMVWrfrnA5KtNi8sApteK5xebfWEAe 3alttG2i/SY5X//HIcW09qGywlfHaMlJkjSlqm+YNeTQTR0r4RCLK4qsE2iO1wEZLcGd LkGYpViyZ11vPUfG1DoRxRTGf2FVKI0vQ9xr5rHwbqlJYA7J+0wCB/QBdmM+NUjvfA2g Dj9nD+zaR3Gun6corO4RDKART+aaAphUjomNCUfLmIf2JU7VFO8dKDt6RtPEMQfgcvnD pIQVe1iuiG74phuO9Qpwnqv8uz57GXrzveaXy/2RKVD3XTHPRDClEvkV3ghkWrfP3u1j 1WBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723509934; x=1724114734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1Beo73jI8KH5p03NxQPXLaupS8Ut84TtJmPr0+Y+H6g=; b=r2C40vJGOecPeofHKGV77y85qePhdYokPWHIb4M31iUXomrNfqUgYzl100d3v9+cfd nN6dkmTjyR0BxKY425LAs6QcLU1/NaMu1OFf79JWbAU4MF1uYfG9EkbbH0+0Mjhrm90E T45u0EvM2mPRLWBKAKXd+RA6zErjGg+4vKxeTEsXu4kP9as+b9xsdHcCL/Jy0tRLxYvm ZPoZcxgd0jBKHCZi1gdnv5lEk2TkNF4mZl5n4zmlu/50q1xk+Ae3ZgqrD3d7BmXWy9Fu N/yDOSUS3SW9imGvdqyJQb1R+oAHFGnUANNf4Msfo7zYoOCnJvOqX0Md3Ip+trlQuTnk 2SUw== X-Forwarded-Encrypted: i=1; AJvYcCUTxvFAEkI3uUGXSvqleGj1U6Ozd6mQEG1Zg4B4F0w46hKmFbGcFeGYj43w4pPJvByLDKwVtStGumsu@vger.kernel.org X-Gm-Message-State: AOJu0Ywf04OcpAvK8kluEKR1sbzz+jPgoVjxRszfpBxH/eBGCip0LojB e57G7SqlqlB2gVYZ6na2yhW+/EJAMRVlOBidczC8UF/vc5OYVSHU5f1AhosF6og= X-Google-Smtp-Source: AGHT+IHdEc1RzSfknb4O0tEELFITV1/FMiLC99gVJNOSQQB/c+hZmMPVy98DA8PMYeZcE4ZXSNQJNQ== X-Received: by 2002:a17:902:e80b:b0:1fb:57e7:5bb4 with SMTP id d9443c01a7336-201ca1831c4mr26201755ad.37.1723509934094; Mon, 12 Aug 2024 17:45:34 -0700 (PDT) Received: from ghost ([2601:647:6700:64d0:239c:9f30:d4d6:f989]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1c86ddsm2537295ad.263.2024.08.12.17.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 17:45:33 -0700 (PDT) Date: Mon, 12 Aug 2024 17:45:30 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Samuel Holland , Jonathan Corbet , Shuah Khan , Guo Ren , Evan Green , Andy Chiu , Jessica Clarke , Andrew Jones , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Conor Dooley , Heiko Stuebner Subject: Re: [PATCH v9 00/13] riscv: Add support for xtheadvector Message-ID: References: <20240806-xtheadvector-v9-0-62a56d2da5d0@rivosinc.com> <20240809-slapping-graph-461287bac506@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809-slapping-graph-461287bac506@spud> On Fri, Aug 09, 2024 at 11:31:15PM +0100, Conor Dooley wrote: > On Tue, Aug 06, 2024 at 05:31:36PM -0700, Charlie Jenkins wrote: > > xtheadvector is a custom extension that is based upon riscv vector > > version 0.7.1 [1]. All of the vector routines have been modified to > > support this alternative vector version based upon whether xtheadvector > > was determined to be supported at boot. > > > > vlenb is not supported on the existing xtheadvector hardware, so a > > devicetree property thead,vlenb is added to provide the vlenb to Linux. > > > > There is a new hwprobe key RISCV_HWPROBE_KEY_VENDOR_EXT_THEAD_0 that is > > used to request which thead vendor extensions are supported on the > > current platform. This allows future vendors to allocate hwprobe keys > > for their vendor. > > > > Support for xtheadvector is also added to the vector kselftests. > > So uh, since noone seems to have brought it up, in the light of the issues > with thead's vector implementation, (https://ghostwriteattack.com/) do we > want to enable it at all? I can make it clear in the kconfig that xtheadvector is succeptible to this attack and that it should be enabled with caution. I think we should let people that understand the risk to enable it. - Charlie