* [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
@ 2024-07-25 12:25 Tarang Raval
2024-08-05 10:12 ` Tarang Raval
2024-08-13 2:14 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Tarang Raval @ 2024-07-25 12:25 UTC (permalink / raw)
To: krzk+dt, shawnguo, festevam
Cc: tarang.raval, Rob Herring, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, devicetree, imx, linux-arm-kernel,
linux-kernel
Add ethernet support for emtop imx8mm basboard
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
Change in V3
1. Add appropriate commit
2. Add Changelog at correct place
Change in V2
1. Add Board name into subject
2. Remove below properties
- at803x,eee-disabled;
- at803x,vddio-1p8v;
---
.../dts/freescale/imx8mm-emtop-baseboard.dts | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
index 1c4e4d175989..7d2cb74c64ee 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
@@ -11,5 +11,53 @@ / {
model = "Emtop Embedded Solutions i.MX8M Mini Baseboard V1";
compatible = "ees,imx8mm-emtop-baseboard", "ees,imx8mm-emtop-som",
"fsl,imx8mm";
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-handle = <ðphy0>;
+ fsl,magic-packet;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy0: ethernet-phy@4 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <4>;
+ reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ vddio-supply = <&vddio>;
+
+ vddio: vddio-regulator {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ };
+ };
+};
+&iomuxc {
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
+ MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3
+ MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f
+ MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f
+ MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f
+ MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f
+ MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
+ MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
+ MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x19
+ >;
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
2024-07-25 12:25 [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support Tarang Raval
@ 2024-08-05 10:12 ` Tarang Raval
2024-08-09 12:00 ` Tarang Raval
2024-08-13 2:14 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Tarang Raval @ 2024-08-05 10:12 UTC (permalink / raw)
To: krzk+dt@kernel.org, shawnguo@kernel.org, festevam@gmail.com
Cc: Rob Herring, Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
As per your comments on v2 patch I have shared an updated version of the patch (v3-0001-arm64-dts-imx8mm-emtop-baseboard-Add-Ethernet-Sup.patch) with the recommended corrections.
is there any updates on this patch?
Best regards,
Tarang
________________________________________
From: Tarang Raval
Sent: Thursday, July 25, 2024 5:55 PM
To: krzk+dt@kernel.org <krzk+dt@kernel.org>; shawnguo@kernel.org <shawnguo@kernel.org>; festevam@gmail.com <festevam@gmail.com>
Cc: Tarang Raval <tarang.raval@siliconsignals.io>; Rob Herring <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; imx@lists.linux.dev <imx@lists.linux.dev>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
Add ethernet support for emtop imx8mm basboard
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
Change in V3
1. Add appropriate commit
2. Add Changelog at correct place
Change in V2
1. Add Board name into subject
2. Remove below properties
- at803x,eee-disabled;
- at803x,vddio-1p8v;
---
.../dts/freescale/imx8mm-emtop-baseboard.dts | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
index 1c4e4d175989..7d2cb74c64ee 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
@@ -11,5 +11,53 @@ / {
model = "Emtop Embedded Solutions i.MX8M Mini Baseboard V1";
compatible = "ees,imx8mm-emtop-baseboard", "ees,imx8mm-emtop-som",
"fsl,imx8mm";
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-handle = <ðphy0>;
+ fsl,magic-packet;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy0: ethernet-phy@4 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <4>;
+ reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ vddio-supply = <&vddio>;
+
+ vddio: vddio-regulator {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ };
+ };
+};
+&iomuxc {
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
+ MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3
+ MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f
+ MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f
+ MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f
+ MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f
+ MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
+ MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
+ MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x19
+ >;
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
2024-08-05 10:12 ` Tarang Raval
@ 2024-08-09 12:00 ` Tarang Raval
0 siblings, 0 replies; 4+ messages in thread
From: Tarang Raval @ 2024-08-09 12:00 UTC (permalink / raw)
To: krzk+dt@kernel.org, shawnguo@kernel.org, festevam@gmail.com
Cc: Rob Herring, Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
I wanted to kindly follow up on the status of my patch submission. Please let me know if there are any updates.
Best regards,
Tarang
________________________________________
From: Tarang Raval <tarang.raval@siliconsignals.io>
Sent: Monday, August 5, 2024 3:42 PM
To: krzk+dt@kernel.org <krzk+dt@kernel.org>; shawnguo@kernel.org <shawnguo@kernel.org>; festevam@gmail.com <festevam@gmail.com>
Cc: Rob Herring <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; imx@lists.linux.dev <imx@lists.linux.dev>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
As per your comments on v2 patch I have shared an updated version of the patch (v3-0001-arm64-dts-imx8mm-emtop-baseboard-Add-Ethernet-Sup.patch) with the recommended corrections.
is there any updates on this patch?
Best regards,
Tarang
________________________________________
From: Tarang Raval
Sent: Thursday, July 25, 2024 5:55 PM
To: krzk+dt@kernel.org <krzk+dt@kernel.org>; shawnguo@kernel.org <shawnguo@kernel.org>; festevam@gmail.com <festevam@gmail.com>
Cc: Tarang Raval <tarang.raval@siliconsignals.io>; Rob Herring <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; imx@lists.linux.dev <imx@lists.linux.dev>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
Add ethernet support for emtop imx8mm basboard
Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
---
Change in V3
1. Add appropriate commit
2. Add Changelog at correct place
Change in V2
1. Add Board name into subject
2. Remove below properties
- at803x,eee-disabled;
- at803x,vddio-1p8v;
---
.../dts/freescale/imx8mm-emtop-baseboard.dts | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
index 1c4e4d175989..7d2cb74c64ee 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
@@ -11,5 +11,53 @@ / {
model = "Emtop Embedded Solutions i.MX8M Mini Baseboard V1";
compatible = "ees,imx8mm-emtop-baseboard", "ees,imx8mm-emtop-som",
"fsl,imx8mm";
+};
+
+&fec1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ phy-mode = "rgmii-id";
+ phy-handle = <ðphy0>;
+ fsl,magic-packet;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy0: ethernet-phy@4 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <4>;
+ reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ vddio-supply = <&vddio>;
+
+ vddio: vddio-regulator {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ };
+ };
+};
+&iomuxc {
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_ENET_MDC_ENET1_MDC 0x3
+ MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO 0x3
+ MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3 0x1f
+ MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2 0x1f
+ MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1 0x1f
+ MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0 0x1f
+ MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3 0x91
+ MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2 0x91
+ MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1 0x91
+ MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0 0x91
+ MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
+ MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
+ MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
+ MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
+ MX8MM_IOMUXC_SAI2_RXC_GPIO4_IO22 0x19
+ >;
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support
2024-07-25 12:25 [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support Tarang Raval
2024-08-05 10:12 ` Tarang Raval
@ 2024-08-13 2:14 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2024-08-13 2:14 UTC (permalink / raw)
To: Tarang Raval
Cc: krzk+dt, shawnguo, festevam, Rob Herring, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, devicetree, imx,
linux-arm-kernel, linux-kernel
On Thu, Jul 25, 2024 at 05:55:22PM +0530, Tarang Raval wrote:
> Add ethernet support for emtop imx8mm basboard
s/basboard/baseboard
Fixed it up and applied the patch, thanks!
Shawn
>
> Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-13 2:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-25 12:25 [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Ethernet Support Tarang Raval
2024-08-05 10:12 ` Tarang Raval
2024-08-09 12:00 ` Tarang Raval
2024-08-13 2:14 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).