* Re: [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes
2024-08-11 15:34 [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes Krzysztof Kozlowski
@ 2024-08-12 16:06 ` Conor Dooley
2024-08-12 19:44 ` Tanmay Shah
2024-08-13 15:29 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-08-12 16:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Michal Simek, Ben Levinsky,
Tanmay Shah, Radhey Shyam Pandey, linux-remoteproc, devicetree,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
On Sun, Aug 11, 2024 at 05:34:38PM +0200, Krzysztof Kozlowski wrote:
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false. Add missing additionalProperties
> to fix dt_binding_check warning:
>
> xlnx,zynqmp-r5fss.yaml: ^r(.*)@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
>
> Fixes: 9e1b2a0757d0 ("dt-bindings: remoteproc: Add Tightly Coupled Memory (TCM) bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes
2024-08-11 15:34 [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes Krzysztof Kozlowski
2024-08-12 16:06 ` Conor Dooley
@ 2024-08-12 19:44 ` Tanmay Shah
2024-08-13 15:29 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: Tanmay Shah @ 2024-08-12 19:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Michal Simek,
Ben Levinsky, Radhey Shyam Pandey, linux-remoteproc, devicetree,
linux-arm-kernel, linux-kernel
Reviewed-by: Tanmay Shah <tanmay.shah@amd.com>
On 8/11/24 10:34 AM, Krzysztof Kozlowski wrote:
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false. Add missing additionalProperties
> to fix dt_binding_check warning:
>
> xlnx,zynqmp-r5fss.yaml: ^r(.*)@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
>
> Fixes: 9e1b2a0757d0 ("dt-bindings: remoteproc: Add Tightly Coupled Memory (TCM) bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> index 6f13da11f593..ee63c03949c9 100644
> --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> @@ -62,6 +62,7 @@ properties:
> patternProperties:
> "^r(.*)@[0-9a-f]+$":
> type: object
> + additionalProperties: false
> description: |
> The RPU is located in the Low Power Domain of the Processor Subsystem.
> Each processor includes separate L1 instruction and data caches and
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes
2024-08-11 15:34 [PATCH] dt-bindings: remoteproc: xlnx,zynqmp-r5fss: add missing "additionalProperties" on child nodes Krzysztof Kozlowski
2024-08-12 16:06 ` Conor Dooley
2024-08-12 19:44 ` Tanmay Shah
@ 2024-08-13 15:29 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2024-08-13 15:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Michal Simek, Ben Levinsky, Tanmay Shah, Radhey Shyam Pandey,
linux-remoteproc, devicetree, linux-arm-kernel, linux-kernel
On Sun, Aug 11, 2024 at 05:34:38PM +0200, Krzysztof Kozlowski wrote:
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false. Add missing additionalProperties
> to fix dt_binding_check warning:
>
> xlnx,zynqmp-r5fss.yaml: ^r(.*)@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
>
> Fixes: 9e1b2a0757d0 ("dt-bindings: remoteproc: Add Tightly Coupled Memory (TCM) bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied.
Thanks,
Mathieu
> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> index 6f13da11f593..ee63c03949c9 100644
> --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> @@ -62,6 +62,7 @@ properties:
> patternProperties:
> "^r(.*)@[0-9a-f]+$":
> type: object
> + additionalProperties: false
> description: |
> The RPU is located in the Low Power Domain of the Processor Subsystem.
> Each processor includes separate L1 instruction and data caches and
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread