From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011029.outbound.protection.outlook.com [52.101.65.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD081C6F5B; Tue, 27 Aug 2024 16:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.29 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724776381; cv=fail; b=NoTDMxUoYcaKOj9ZxqrFqs7TM2q63tlwLh7iP/4VZoyOep7jICiThrNhtbwuOBFgYqbFRF409Z09O84cmAMpkzG/AreaZ7XZAdlWPUZL0EmXbLlBu9vFtgyo2iBhBDoKx+RIXc7wrV5Q9XcKwvXTPi0LCxt/mt1x2XftjFUMFUI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724776381; c=relaxed/simple; bh=ZddIDTyWtVJARtwbcCU47fBAjecGuT66rEZI3oUbGn4=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=f53Hi/LpH9Ywym/bsE/DSR+xmA3uAdSDSYEnyrblZDiZ7Ne0h12oWJUDCnX2N08TD4BXbn4BoHYDpGEfEFD21e4hTfNYqeSTQuIIREYMWvmg0pLVOhT2alYYVRXG/uXk4/tpUZllx3o0mznpnYmn1NHyHGGHzoMgFR7ZuU/Z9bI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Vm3Y+8NO; arc=fail smtp.client-ip=52.101.65.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Vm3Y+8NO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y8djOqhoyBITPgGLXXkhP1LWhLfVusxbDc2Bh1ObGQKFHksAmE4OWum/JdRslcFcLbh3Dzm8p19JyZUg+OSZVn9kyfJjwEXztkOirFg4f6f11fym7IwNgHC6m868VfL9ujBdDPAMza/6LCzST0UsZAItNp1VIn570kW3PyKk/+qgu8XIdAcFbHHS0qD2cM6JZc4INcxu/YS7H80FHP21+ECm25Zow1LPXREpMqa/FRHXLTcbLQKVe8g/jAQmjZ+mAXRb5z13FhNjXwDplnOpF2Kkk4QgH9Wnq0lwELVya/09s6bIHm4IrkcMSKkwkKC6SaJp8+4dU9b9mMTHkOLUsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wi8S8/Lpc+w3tYxJry9AvKL+qOaRdti9qFEpSIxz+CY=; b=AwB/QNW/RnqjHEozqZa7bpeWZs/A5qEPf9LtkRbzAqJbIw13jKWcVS0PE2dNGAbqd1FjT/SLh6djmF+0RkS2Ioo/AtlSLmuAh1APjyiVKpSSpnjnHSZy9js0FmW3tQI5ABNLX6YswvdkLiRwWHh7HsfBRpYIv1uak4C+Lalsxqeuz8Jx/yVNAP19jrv9gk25Lw85+3Huou21/ogy/Gh7KWV5IQ/SXypSqQlUp44XOpazyFMnHn7/6I2ZJs4xXlwWeoe0eRFBnkUtKwFdbSXyIc8RBCq0oONjniGBFjVbvPPf2+2K+LKKOKe/xaTfinOzLvPxTrOagg01YXypaAY9DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wi8S8/Lpc+w3tYxJry9AvKL+qOaRdti9qFEpSIxz+CY=; b=Vm3Y+8NOzVQhGgjQc8FKaAiX+h726VBwGxKGCU7uMqR2w/rn23Rial8XCu+U26tVzr9aspOSRWDs0kM7kY8Bvsla3s25rdKQwU4N6J7ObFEar0omNPGfRVh+IbrnQyRwB6GhXLuZ78MKzgh/1HCf+hvXwPz8DslUuOlrVKIGA4bbvk3ta6AD/a098JYawSYTR43d1UI+1FgCoF/cjQnnPDrJaeOSTVs8JOqicJa3NDAbJXbuF1F5oAX/Q1VYH8e1/PZkrtgncNZ1Cep0cJrsGryfEEGqOPQNyHd7LgqsbTcW1bN/4D7EVE8qHS/2reburLLGbJtmr5a+F8iu1zQ0mA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8444.eurprd04.prod.outlook.com (2603:10a6:102:1db::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.24; Tue, 27 Aug 2024 16:32:54 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.7875.019; Tue, 27 Aug 2024 16:32:54 +0000 Date: Tue, 27 Aug 2024 12:32:42 -0400 From: Frank Li To: Conor Dooley Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Olof Johansson , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH 1/3] dt-bindings: PCI: layerscape-pci: Replace fsl,lx2160a-pcie with fsl,lx2160ar2-pcie Message-ID: References: <20240826-2160r2-v1-0-106340d538d6@nxp.com> <20240826-2160r2-v1-1-106340d538d6@nxp.com> <20240827-breeding-vagrancy-22cd1e1f9428@spud> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827-breeding-vagrancy-22cd1e1f9428@spud> X-ClientProxiedBy: SJ0PR03CA0176.namprd03.prod.outlook.com (2603:10b6:a03:338::31) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8444:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f5e010-01a6-4405-f832-08dcc6b5e548 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?F9KNHskxWlsE7KOZ3WrFYkzqgQnnWGgqJfG3+Nb7nXIuznnL079HtG8MXZRV?= =?us-ascii?Q?J9xD/VAkQBKZlCl9hz9LKJGAOSc5nsqI9ImxhTd6TWfu3peFjB1PLSktI8fe?= =?us-ascii?Q?SbeFrf933HPFXqoKGnV/CXXx0hNL2EqsZzC++6wgnlQBUS/ICq3NHsyT0MDE?= =?us-ascii?Q?BONhotMhAqN4fV+/kSdZFsp/g4uZC0V7tkRI8cPniTY4aVSRX6GxBje3FrSQ?= =?us-ascii?Q?oSfhwolAMeuRUY5D5pHB5+n3CBteJyfBgaY678es2a+ettBN0ZiYv4bXHLo1?= =?us-ascii?Q?k0mERr9E4Uv+1UTl0m2FR1+mggYKlswwwRMmzH71SXr5TYdXbOaMCFsY3G5C?= =?us-ascii?Q?egTzjY+Ee1xIJ3VO5D75qR+iyAIKzTGi+0yov5vpicelkyFuU/RbKrhlDPCS?= =?us-ascii?Q?er/Zwz3huoRenqeFIjuxE94vqkUXhPfjGzvHbtLjgnuS2SIFhywXfWHd7bvH?= =?us-ascii?Q?6VVMPsD6QmOExCk4UVhMiY0/CAxe6mletoNb+uh6shN/47V32eUs7hHDQmqV?= =?us-ascii?Q?eWVHOOuQDRYEvlkJp5n5wuzXnS8bppUPHtEAtAKPfVf+LOrGRzVC+MrDMV7k?= =?us-ascii?Q?QNh5Y8O387OkOIo5q6DYD6fitchaHd2XFmUKNSFXr3c3MYIJmzK4iGCkMY/u?= =?us-ascii?Q?4SLoJzIk+hqunaMIuA3CZ1mBKrEzrljRVg4XLkjGCj7o6sdApeVnkr2NjT5k?= =?us-ascii?Q?fTwMiPkAKvLb9GZELiLXnRNErtnyLCcLFVK3wmYcRKrjlO/2vo6aeP62548T?= =?us-ascii?Q?2YiG8qpsX90350ds838zN695u0x2hbrWVPem2VPHk7xOUeGNr3bFfNbYLYHj?= =?us-ascii?Q?2Hczq16hrjkbDukPO2eUUOulaSdwH95nY45epJdJdCy6hr63Yc/PfLX7SpN+?= =?us-ascii?Q?gbV6HglWVgCaxTunv3dc0qFwiYoPvsDgKLoO2S6Iihj+pFXHTctXvDsrQQpo?= =?us-ascii?Q?LEIU3047Qmkx2+8+GXyQk3LCKFdj5FALC92htb3T0TBQqAqhqLSJq80Ozds8?= =?us-ascii?Q?vgSp0OSRNggC9k0I3gGANInYdxJ8GJGcoHItyV/dI0TcVUh+NyhwTSSWxGn2?= =?us-ascii?Q?gg0pYRHA66gUvHKB1algks9HXxHPs2BwiL6AjWRFBSDdL1PTiYWh9ijWVb2A?= =?us-ascii?Q?d7PbT8HhGqRBL+tkKlb4EYtBDAx9PAod4b8UZPManC3gThD1TmdA3kb6Tt/2?= =?us-ascii?Q?KlChw3oiCN134hS509C+EJVtJvkZ+pavqUQwcsBGUmBndKZkVwP9Q1HJWWPG?= =?us-ascii?Q?ug1E1Es0ok6uLOR+yxK9eRAGnqeGDxqV/3q09DUwk8UwIsmxyf0U2ZkfF+Kq?= =?us-ascii?Q?D11+Gzy38+SM9gJ54c2uLGYWYm7xkisvxb8MjQQ7glzZ21Re5HEBFbC6vDoF?= =?us-ascii?Q?NUenJxyakKOR6Xr3Gr0/X6FR41R3GzaN6HIm664IOKX9qNaefw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LQeMg8ktNrcd9N/JEeZ0EH9t85icJ9tg/svHekIOW/lw9PM/Xo+uRBWmWI67?= =?us-ascii?Q?dteBp1jAgmX2fR5tkc+p4sbVJPQyjrSy4ncON4sWl4D0UnM+bUfHLwK1zkL7?= =?us-ascii?Q?UQgJ1Bz3VyBlKG+RhH1Tx3pnmDS6Po2eXcx6MJCStWtdtLLdva0l0lE+VJ1S?= =?us-ascii?Q?g8eEZ9/YlihLsdjI13i+/9eIIkcfKyJYhsD70HLUBEaoV8j+wnUc3PFQRKxf?= =?us-ascii?Q?Oqh8v878gRwIQqUNxcqmAXp8mLvvXKQRa0NTB4cjKQj68EbNlr0hZQ9vKwB2?= =?us-ascii?Q?tAkWYmeMehb7XBV9d79t/K0m2OPfVB8h8aNWzTF6wxIdLF4yG0ag//bjoIHV?= =?us-ascii?Q?8TYc08eX5MMRQnB0bRk8Vz53THu0VkJOxnZrvwiCIyVPK8gxnusclLBEPmDT?= =?us-ascii?Q?OrEtRwZ8mYHeJanoXrsEaWNxIcuV0v0clXs8L9bNUUjcyxBSMy5lhmO0PgNY?= =?us-ascii?Q?tGGvlGqbQ0npfY44KAvYpFp71C0VT5Wl/vue5VoxGrxxaA2szt39xF5ykCsm?= =?us-ascii?Q?AftjWHk3SjZ4q7oeBkqdukOyF9mZ7zx9l2KZg56pl5UsUz67EVmrvuIxVdo0?= =?us-ascii?Q?8GlMm1nwQkN7vA8WTfDkIdcARGBYs/Yl7AI62lT0TRmyDE7M+0jQHCR214Er?= =?us-ascii?Q?lGIFy8qYuCDvWayCyetrdZ0kC5L2ULFgxR/YvXLwiNa4Ee8eDvbPis2DKZ+O?= =?us-ascii?Q?2wJbcUoHXR4nX8OEc2KYVS4eu65EzM5A+x3neAOZ+krxl5vOXN0DZSg4Ctvb?= =?us-ascii?Q?c72A0DEvUQhtk/R8kyoKrifUkbjSHLa5qCjm2ii/+oA7noaatFUQsMTJxWuw?= =?us-ascii?Q?p9WUuf5HDdO7Y1NaVqTpAILVecamIuREMVhaQXQDpACz7JuLNMtqq1r3LFBa?= =?us-ascii?Q?YAcreKQlPYVp9w8zSQHKUA67ZK3tLkN9VB9Z38cP/DnUSfSk5Dbzc6pqNbMO?= =?us-ascii?Q?oNzykcwz5vDriZ7KyOMnTwldQ9wUpZGOl0tstrTlTQVXltJItKqpNa8Z01I7?= =?us-ascii?Q?RQyG6HZcSVxRXmgaPTpps5eqxhpMWzqMQOCINn+Y53cBtUkhXHFfaDotn4jh?= =?us-ascii?Q?gyxV5h59Pf2G1nrE8SwXxJUjI7bhINYGjLOZzF3rkR93a0R3Ye40TEPnkiUL?= =?us-ascii?Q?ZpY1aO/WBxquc/pZA0X7JsSa/J22Rvo+9+05ljNLliNC57k7ICaiG5zayoIL?= =?us-ascii?Q?mZPExT/z4urKu9RTis8RGIYelWPI79kjWI0Qafm/CA+nwjs8614j9/4MO07j?= =?us-ascii?Q?TvUDkb0uAVEgsNaEoK1dEzrth6PgZ5zTDbBOX8A+x6DtUQ843PZBgbeVg7Sx?= =?us-ascii?Q?/dZY/4cs84PzYh42F31klMntxRPV4ek2tvhc+kN3sDXm+ZpKKElF6IyoHI8f?= =?us-ascii?Q?NwSqnnmhSr+1rQCqig0F2td/GxbZhEbrug7p3bim/98W/SLjywFcklBrMO4D?= =?us-ascii?Q?cDW2njuJhjaUAJegr+PzXLJZxBHnfC8bCxT5KYlZIm4ixhAiXrBD609BxE/Z?= =?us-ascii?Q?x3pxCO7H/1GSdtnVVbfsXwYfafDZ1KUBAs3Ez6J8L/5IRYNmD+QgSYY/cJPj?= =?us-ascii?Q?eKGTewaS9sLWH87DrbE=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28f5e010-01a6-4405-f832-08dcc6b5e548 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2024 16:32:54.1408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qukaG9VD6SPmu3bRpUF9yfzcE9MYFnY89gqGjPxevUJjTZjKhmFTFSEUN+4Q4BvmwMwKTQZsW3oBXdJKfIjPDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8444 On Tue, Aug 27, 2024 at 05:14:32PM +0100, Conor Dooley wrote: > On Mon, Aug 26, 2024 at 05:38:32PM -0400, Frank Li wrote: > > fsl,lx2160a-pcie compatible is used for mobivel according to > > Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt > > > > fsl,layerscape-pcie.yaml is used for designware PCIe controller binding. So > > change it to fsl,lx2160ar2-pcie and allow fall back to fsl,ls2088a-pcie. > > > > Sort compatible string. > > > > Fixes: 24cd7ecb3886 ("dt-bindings: PCI: layerscape-pci: Convert to YAML format") > > I don't understand what this fixes tag is for, this is a brand new > compatible that you are adding, why does it need a fixes tag pointing to > the conversion? Because previous convert wrongly included "fsl,lx2160a-pcie" here, which already used for mobivel pci controler, descripted in layerscape-pcie-gen4.txt. This patch fix this problem, rename fsl,lx2160a-pcie to fsl,lx2160ar2-pcie > > > Signed-off-by: Frank Li > > --- > > .../bindings/pci/fsl,layerscape-pcie.yaml | 26 ++++++++++++---------- > > 1 file changed, 14 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > > index 793986c5af7ff..daeab5c0758d1 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > > @@ -22,18 +22,20 @@ description: > > > > properties: > > compatible: > > - enum: > > - - fsl,ls1021a-pcie > > - - fsl,ls2080a-pcie > > - - fsl,ls2085a-pcie > > - - fsl,ls2088a-pcie > > - - fsl,ls1088a-pcie > > - - fsl,ls1046a-pcie > > - - fsl,ls1043a-pcie > > - - fsl,ls1012a-pcie > > - - fsl,ls1028a-pcie > > - - fsl,lx2160a-pcie > > - > > + oneOf: > > + - enum: > > + - fsl,ls1012a-pcie > > + - fsl,ls1021a-pcie > > + - fsl,ls1028a-pcie > > + - fsl,ls1043a-pcie > > + - fsl,ls1046a-pcie > > + - fsl,ls1088a-pcie > > + - fsl,ls2080a-pcie > > + - fsl,ls2085a-pcie > > + - fsl,ls2088a-pcie > > + - items: > > + - const: fsl,lx2160ar2-pcie > > + - const: fsl,ls2088a-pcie > > reg: > > maxItems: 2 > > > > > > -- > > 2.34.1 > >