From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9746A18A928; Tue, 20 Aug 2024 17:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174215; cv=none; b=GTgAHGj9NLJZm4Ms3yIgJeXCDGc2SK6CWVNcj+UxWaTsrg5hf+H1IzIs51sqZ+s3aPJxsAODxxg90+OmqAr/BhwDYaR+zrDrEWvgbsOLYStAVggzzKRT3dKxu1yQdn145MedA3/TFwgDP4GYmbake1xpJQoXxOc9NcLoDvxl7M8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174215; c=relaxed/simple; bh=1WOCN1hQxUm1krY7hl5MD+NIzVYaTnsupZFCAJLrYTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PJh4rMjGwg90GHvlV2MaA+RexSmO0W+6tSJKX+mOqGOCSnrYmy0+8vU/X+uVeS9K8aMea1LRxBgSNxaV0FzoKbP25V/ubyy4PeBA5oq5hR7LxlSjvXUhrGF/GGEGCJpqzyfrkA2NWRdXKNq+382x8PW5KyYMjHpL4z+hhzvFCDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aDgDPDlG; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aDgDPDlG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724174214; x=1755710214; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1WOCN1hQxUm1krY7hl5MD+NIzVYaTnsupZFCAJLrYTs=; b=aDgDPDlGBOBVdExNqWfPQoUWA10BQbJwJu3meocUxnJ+DUn8wtf60SdT 4uzqA6rDnVIxXKbnES5lI2kLDNbwwXMa8tO6HSO2wNsNhfdUkfxrx9qp8 WKnm0KJTPhvM7SZ4V0ckZLgyU7/BFu0OldlO3FXnEza6n30q32btnI/wA zxmWgfSFazTwjb1inhFdJ2Jj47CUqI6NLlwMJW+6QAIsn10j4Tmu+3tVZ 4r5e+/QaAhrfsorGFa6qdDvfHuR95ktF5cP8MuoinkYr44SsJRgQ2467t thTeLjIvs0T/0Vyxrn0rso60UtGOSUrgZAYW/rbGZ9AEtPHWHfEFUyFqb A==; X-CSE-ConnectionGUID: DUhOeT6wR4SY8q6WJuK3pg== X-CSE-MsgGUID: 3P4EXWVmQYmZcpijna41yQ== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="26363978" X-IronPort-AV: E=Sophos;i="6.10,162,1719903600"; d="scan'208";a="26363978" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 10:16:53 -0700 X-CSE-ConnectionGUID: 9kKj3Zq/Rcak+WCW+VHNBQ== X-CSE-MsgGUID: YxLX6qvOT+uBQrS9ly4vBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,162,1719903600"; d="scan'208";a="65650227" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 10:16:44 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sgSTI-0000000HNl0-2L24; Tue, 20 Aug 2024 20:16:40 +0300 Date: Tue, 20 Aug 2024 20:16:40 +0300 From: Andy Shevchenko To: Stephen Boyd Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Douglas Anderson , Pin-yen Lin , Andrzej Hajda , Benson Leung , Conor Dooley , Daniel Vetter , David Airlie , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Guenter Roeck , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lee Jones , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Prashant Malani , Robert Foss , Rob Herring , Thomas Zimmermann , Tzung-Bi Shih , Alexandre Belloni , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , Ivan Orlov , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, Mika Westerberg , "Rafael J . Wysocki" , Sakari Ailus , Vinod Koul Subject: Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register() Message-ID: References: <20240819223834.2049862-1-swboyd@chromium.org> <20240819223834.2049862-6-swboyd@chromium.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), GFP_KERNEL); > > > + if (!ptr) > > > + return ERR_PTR(-ENOMEM); > > > + > > > + switch_dev = typec_switch_register(parent ,desc); (Side note: wrong location of the white space) > > > + if (!IS_ERR(switch_dev)) { (Side note: positive conditional is okay) > > > + *ptr = switch_dev; > > > + devres_add(parent, ptr); > > > + } else { > > > + devres_free(ptr); > > > + } > > > > devm_add_action_or_reset() ? > > No. We don't want to call the 'action' devm_typec_switch_unregister() > when it fails because that would unregister a switch that has never been > registered. Hmm... With devm_add_action_or_reset() we first do things and then try to add them to the managed resources. In that case it won't be like you described. What do I miss? -- With Best Regards, Andy Shevchenko