From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44C416EB4B for ; Thu, 22 Aug 2024 10:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724321072; cv=none; b=dnyNdGaqasSDZ0Ybv7ntDbbaIIRr+NBt+1jspWMh0ffOvY1mkBLmCeSH2QbTW8GCa3gu5Ds1/f/BQLiJWk3clPJBbAAmAtJzzOg0IvWRdx2EZgz27cfsHCC2GFnMyse2RPz3CL42Qi/mcOIdf9cNzg18z7zJ2fEfXIZZ9RdK1Uw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724321072; c=relaxed/simple; bh=xxyoPJfX24KJoyxO6jEzwtrU2Hoh+t/Pzgync5R29bw=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R8LSNZu2bqMDUEYRI2FU68fwVRFd/MUG4/NpP/rpIOaWEqr2EQYkjBJHmgnWoPmPALaG/2kuD5Ho0ggXZHPUsmIC87DQAW3xx0nYdI2jUGhzhNy10pBmz2nybiQv2WT3k9N2PCU5ZL88mVE28uUUTEPCGc914MfVAsHnrhJWQKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cjd0qZgh; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cjd0qZgh" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a80eab3945eso71616266b.1 for ; Thu, 22 Aug 2024 03:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724321069; x=1724925869; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=MpyK4IsQzJrI6qeJJhvprKefQNt+Ld7JQCqPLKfE9e0=; b=cjd0qZghW7v0ktHKohaYYLp+lK+DySxFbu34qndmjCyWRs2wDG5qBO45dz0EwS0R0i 0ENCdE8+ChXf1PSynPrqXNYD4VPJpJaCOkc2cj/b468r//RB1wegrQdTUDpZURtZ7dOT 2vZ7wo0Gavo+Va1aEUOy2l13V5qayiFiohQQWgsRqnJiFZH2aB4MA3DrjNGgIYHL4zox kn1PzOXREbrp3z7h2Sf1yy9VRyzBzIzyUl1BUGiDvB/X+I+QxNGjc2TBRn8ogA5e5aGI BZPueo2fQcKSCGYnoI6NQ3hulR42mQJ/a7RsYYTkrJhoEvc7V0f7ZgsZmQ+EWCN4JqIQ kRWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724321069; x=1724925869; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MpyK4IsQzJrI6qeJJhvprKefQNt+Ld7JQCqPLKfE9e0=; b=E/jfYuMHufjrmhVr+8CoztvsteU3i/lBQS2MS4UF4XhDKjBrtVKX5v58uAsJHTFIzF pkQK8UoGlxW9tjVHkI0Xk0i175Fxluq9l9RU7gmf/hIUjA+SpgnCW0QBg46jhXkNvuLc fKjfEAf18/a9Sf9aHNCYcT0rq9UCueXBIE9toTYqCX5DsBxdG/XKACVbg4n/RzGS00xM TX5Yil5lUL7AUdHjJcFmJlI5VjyO0Ctty3E95tOjpElP1EJmE6VRPDYYYNiBb/Vi4ZKt VZjjbMFHgi7jn7Lhfe50Qu33x6dfYfSeHAWJFRsEW2u1T9GzTq8jIWtZz5dnRjyOMs7R sbXQ== X-Forwarded-Encrypted: i=1; AJvYcCVM7rQ2mmroUSQZITstr+w/EQ/JM3OPZzTkNKOL0c6V9+w4RtJ6PGb8O/unxzqNGjGPERlzi5fCkyO4@vger.kernel.org X-Gm-Message-State: AOJu0YwCmK5Z/wOYMhcRVZKDRpfoQnUkdRRccqL0wNX510ICqSyBD/mf lxLg/TGHoRq9mD70615KWL92zfd3yuKB5HqpjaU+1MregDGM01orHj9w4MFWJ5I= X-Google-Smtp-Source: AGHT+IHlxXQHOoIG5Xms+dbKMTaH/vArkSFDYv8NHwvurq0I3OqBwEKhWmO0dZKyqjO8q42AqL7AQQ== X-Received: by 2002:a17:907:f14d:b0:a7a:9760:9aec with SMTP id a640c23a62f3a-a866f8c3418mr450021966b.43.1724321068912; Thu, 22 Aug 2024 03:04:28 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f48a9b6sm96500966b.179.2024.08.22.03.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 03:04:28 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 22 Aug 2024 12:04:34 +0200 To: Simon Horman Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren Subject: Re: [PATCH 06/11] clk: rp1: Add support for clocks provided by RP1 Message-ID: Mail-Followup-To: Simon Horman , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: <20240821131757.GB6387@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821131757.GB6387@kernel.org> Hi Simon, On 14:17 Wed 21 Aug , Simon Horman wrote: > On Tue, Aug 20, 2024 at 04:36:08PM +0200, Andrea della Porta wrote: > > RaspberryPi RP1 is an MFD providing, among other peripherals, several > > clock generators and PLLs that drives the sub-peripherals. > > Add the driver to support the clock providers. > > > > Signed-off-by: Andrea della Porta > > ... > > > diff --git a/drivers/clk/clk-rp1.c b/drivers/clk/clk-rp1.c > > new file mode 100644 > > index 000000000000..d18e711c0623 > > --- /dev/null > > +++ b/drivers/clk/clk-rp1.c > > @@ -0,0 +1,1655 @@ > > +// SPDX-License-Identifier: GPL > > checkpatch says: > > WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/... > Alas, the system on which I executed checkpatch was missing git python module, so spdxcheck.py wasn't working properly, sorry about that. Fixed in the next release. > ... > > > +static int rp1_clock_set_parent(struct clk_hw *hw, u8 index) > > +{ > > + struct rp1_clock *clock = container_of(hw, struct rp1_clock, hw); > > + struct rp1_clockman *clockman = clock->clockman; > > + const struct rp1_clock_data *data = clock->data; > > + u32 ctrl, sel; > > + > > + spin_lock(&clockman->regs_lock); > > + ctrl = clockman_read(clockman, data->ctrl_reg); > > + > > + if (index >= data->num_std_parents) { > > + /* This is an aux source request */ > > + if (index >= data->num_std_parents + data->num_aux_parents) > > It looks like &clockman->regs_lock needs to be unlocked here. > > Flagged by Smatch, Sparse. and Coccinelle. Ack. Many thanks, Andrea > > > + return -EINVAL; > > + > > + /* Select parent from aux list */ > > + ctrl = set_register_field(ctrl, index - data->num_std_parents, > > + CLK_CTRL_AUXSRC_MASK, > > + CLK_CTRL_AUXSRC_SHIFT); > > + /* Set src to aux list */ > > + ctrl = set_register_field(ctrl, AUX_SEL, data->clk_src_mask, > > + CLK_CTRL_SRC_SHIFT); > > + } else { > > + ctrl = set_register_field(ctrl, index, data->clk_src_mask, > > + CLK_CTRL_SRC_SHIFT); > > + } > > + > > + clockman_write(clockman, data->ctrl_reg, ctrl); > > + spin_unlock(&clockman->regs_lock); > > + > > + sel = rp1_clock_get_parent(hw); > > + WARN(sel != index, "(%s): Parent index req %u returned back %u\n", > > + data->name, index, sel); > > + > > + return 0; > > +} > > ...