From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, ang.iglesiasg@gmail.com,
linus.walleij@linaro.org, biju.das.jz@bp.renesas.com,
javier.carrasco.cruz@gmail.com, semen.protsenko@linaro.org,
579lpy@gmail.com, ak@it-klinger.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] iio: pressure: bmp280: Remove config error check for IIR filter updates
Date: Mon, 26 Aug 2024 13:12:47 +0300 [thread overview]
Message-ID: <ZsxVH3TG2vs38Brw@smile.fi.intel.com> (raw)
In-Reply-To: <20240824111806.GC9644@vamoiridPC>
On Sat, Aug 24, 2024 at 01:18:06PM +0200, Vasileios Amoiridis wrote:
> On Fri, Aug 23, 2024 at 10:15:29PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 23, 2024 at 08:17:10PM +0200, Vasileios Amoiridis wrote:
...
> > > + ret = regmap_update_bits(data->regmap, BMP580_REG_DSP_IIR,
> > > + BMP580_DSP_IIR_PRESS_MASK |
> > > + BMP580_DSP_IIR_TEMP_MASK, reg_val);
> >
> > Better to split on logical bounds
> >
> > ret = regmap_update_bits(data->regmap, BMP580_REG_DSP_IIR,
> > BMP580_DSP_IIR_PRESS_MASK | BMP580_DSP_IIR_TEMP_MASK,
> > reg_val);
>
> This goes beyond the 80 char limit. I know that there is the relaxed
> limit of 100 chars but I didn't feel it was more readable like this.
> I could definitely use it though, thanks!
The readability has a priority over that limit. That's even mentioned in
the documentation besides the relaxed limit.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-26 10:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 18:17 [PATCH v3 0/7] pressure: bmp280: Minor cleanup and interrupt support Vasileios Amoiridis
2024-08-23 18:17 ` [PATCH v3 1/7] iio: pressure: bmp280: Use bulk read for humidity calibration data Vasileios Amoiridis
2024-08-23 18:47 ` Andy Shevchenko
2024-08-24 11:10 ` Vasileios Amoiridis
2024-08-23 18:17 ` [PATCH v3 2/7] iio: pressure: bmp280: Add support for bmp280 soft reset Vasileios Amoiridis
2024-08-23 19:13 ` Andy Shevchenko
2024-08-24 11:16 ` Vasileios Amoiridis
2024-08-26 10:11 ` Andy Shevchenko
2024-08-25 7:04 ` Christophe JAILLET
2024-08-28 7:49 ` Vasileios Amoiridis
2024-08-23 18:17 ` [PATCH v3 3/7] iio: pressure: bmp280: Remove config error check for IIR filter updates Vasileios Amoiridis
2024-08-23 19:15 ` Andy Shevchenko
2024-08-24 11:18 ` Vasileios Amoiridis
2024-08-26 10:12 ` Andy Shevchenko [this message]
2024-08-23 18:17 ` [PATCH v3 4/7] iio: pressure: bmp280: Use sleep and forced mode for oneshot captures Vasileios Amoiridis
2024-08-23 19:25 ` Andy Shevchenko
2024-08-24 11:29 ` Vasileios Amoiridis
2024-08-26 10:17 ` Andy Shevchenko
2024-08-23 18:17 ` [PATCH v3 5/7] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices Vasileios Amoiridis
2024-08-23 18:51 ` Biju Das
2024-08-24 11:31 ` Vasileios Amoiridis
2024-08-24 11:41 ` Biju Das
2024-08-24 12:09 ` Vasileios Amoiridis
2024-08-24 7:45 ` Krzysztof Kozlowski
2024-08-24 11:35 ` Vasileios Amoiridis
2024-08-25 6:57 ` Krzysztof Kozlowski
2024-08-23 18:17 ` [PATCH v3 6/7] iio: pressure: bmp280: Add data ready trigger support Vasileios Amoiridis
2024-08-23 20:06 ` Andy Shevchenko
2024-08-24 12:02 ` Vasileios Amoiridis
2024-08-26 10:01 ` Jonathan Cameron
2024-08-26 10:26 ` Andy Shevchenko
2024-08-26 10:23 ` Andy Shevchenko
2024-08-28 14:01 ` Vasileios Amoiridis
2024-08-28 14:17 ` Andy Shevchenko
2024-08-28 18:13 ` Vasileios Amoiridis
2024-08-23 18:17 ` [PATCH v3 7/7] iio: pressure: bmp280: Move bmp085 interrupt to new configuration Vasileios Amoiridis
2024-08-24 10:02 ` Jonathan Cameron
2024-08-24 12:07 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsxVH3TG2vs38Brw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=579lpy@gmail.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).