From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CE819AA57 for ; Mon, 26 Aug 2024 20:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724703506; cv=none; b=M2maG3uDFrMjZ3sHp7UY4R1WqSwkIE0nZg12NUFi4WcTlEYHMj34r/O1GLSGB5adn3+CzfA75AUQYluX3dvRS2f7SKLlYZWxMrDGxUWy5oo7AdkFunLY1tIkYg3iZiu/1Ze+H/EvV/VBbNR8K7Uwq75AVLLyqZhQBmy0+j+Gl2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724703506; c=relaxed/simple; bh=x1koh82jZtl5PCTVnwGWjnH7a1/xTcElJvB0lCAu//I=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n1L4OKSISOnmkV9Te0MXFYvKf316RxIZtUbNuMr04zx7RYDqhjuCa9MKxgCHMLFHjVlMWjI7j/TcLarv5ixeKI47ZqVdpTi26LnEmcON4k6rBbHYApzYIdcrvES+ltKtz9d5sDnee+r3kbtlAXFyYAgL4YaU8tbJVl/XcN8UhDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Zp0jeE0o; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Zp0jeE0o" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a8683dc3b17so300272466b.3 for ; Mon, 26 Aug 2024 13:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724703503; x=1725308303; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=NQcMPtKwW2Ur+/ekeJHQBfttffMZ3TRumocDv4AvDhE=; b=Zp0jeE0oF/j8fU2kLqs40sNtdop8ZQZdgPIxd5yILz7t5nz/nqzeGgDHeAhu6gamWw T22oZADtHvcJNNm718zniI6jonxYUHR8IeGIb6plg479Ri4PlGS4yaDZ+xViwtjYRlru KRjFeC1Hp3Ifg+FXt5WLpVY63Mu7IN8QMDnbwZH7Ze/UyLNTMSpWNzAbcHJhed1bqrnh /dxRiyaM3kUnLkkExvJfokrcchEsYW2k7wZoibIFzDmYt970knIZXQzzxrLx663jYHU0 5IAaixaQatSfzMvCuFTXrIlMWl87jrGEdyPr3cJt3Yyz7s0RgzZDDbfY627IWt9Owco/ 34yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724703503; x=1725308303; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NQcMPtKwW2Ur+/ekeJHQBfttffMZ3TRumocDv4AvDhE=; b=cVSF5qEnKxhjCeKi8X7phHUgCTsW8uziK07YbVV6E/nUZpLO5xUq2BvspS2nXCcubK yZIWw7eKMNNHVdULDbGtqm+X4xpF8/rMw52Ciba2MWycECV+Ccvc6RyBV39txS1wsnuI p+xbvHmG//dyVEtG4iHi3QKZ+KJrfHIKXlXl/UJWeN9WyDTC0v1D9/Z8SBK28ZyTyKi4 UUjg41+zbQauk6rKcJzjgETJi8QBOk9Sn3YdikU6hDUvs63nNX7l2ZEu8rDOzemlAgY5 rL+18xXCnmGpme3YbOKGDTGTXG83dWLrSZuC90iVggb+WSj5W8oILFNy4pDq7mdgcq82 u0Lg== X-Forwarded-Encrypted: i=1; AJvYcCWXL+Fefu9mgVM+s56VwoZ6r+ZdUZdEX3Efz/1R9hEEowgZHQOZinpv0mu+qVnnYxbPzCDHmOSvDxvx@vger.kernel.org X-Gm-Message-State: AOJu0YwktCNLX4Xopm7cWclM6PpFm0gFZ8maL9vaifDIlrXLfu7pobfo 3Xd3RD9tpZCgFoYy3YpiBONtNLz1PBXRQRWuV98JVG/bDAu0UMlzcOMWAsVNcAU= X-Google-Smtp-Source: AGHT+IGg3wF8BNSAEwrMaM1mnP282cCzSjHmPqhfR3e+bo7xqlwNcVANiEFofVeUFy+v47Ksb4HTjw== X-Received: by 2002:a05:6402:26d3:b0:5a1:2ce9:f416 with SMTP id 4fb4d7f45d1cf-5c0891b4825mr9974880a12.37.1724703502649; Mon, 26 Aug 2024 13:18:22 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e5485003sm16833066b.13.2024.08.26.13.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 13:18:22 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 26 Aug 2024 22:18:29 +0200 To: Florian Fainelli Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren Subject: Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1 Message-ID: Mail-Followup-To: Florian Fainelli , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Florian, On 10:02 Wed 21 Aug , Florian Fainelli wrote: > On 8/20/24 07:36, Andrea della Porta wrote: > > RaspberryPi RP1 is multi function PCI endpoint device that > > exposes several subperipherals via PCI BAR. > > Add an ethernet node for Cadence MACB to the RP1 dtso > > > > Signed-off-by: Andrea della Porta > > --- > > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso > > index d80178a278ee..b40e203c28d5 100644 > > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso > > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso > > @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 { > > <50000000>; // RP1_CLK_ETH_TSU > > }; > > + rp1_eth: ethernet@c040100000 { > > + reg = <0xc0 0x40100000 0x0 0x4000>; > > + compatible = "cdns,macb"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + interrupts = ; > > + clocks = <&macb_pclk &macb_hclk &rp1_clocks RP1_CLK_ETH_TSU>; > > + clock-names = "pclk", "hclk", "tsu_clk"; > > + phy-mode = "rgmii-id"; > > + cdns,aw2w-max-pipe = /bits/ 8 <8>; > > + cdns,ar2r-max-pipe = /bits/ 8 <8>; > > + cdns,use-aw2b-fill; > > + local-mac-address = [00 00 00 00 00 00]; > > + phy-handle = <&phy1>; > > + phy-reset-gpios = <&rp1_gpio 32 GPIO_ACTIVE_LOW>; > > + phy-reset-duration = <5>; > > + > > + phy1: ethernet-phy@1 { > > + reg = <0x1>; > > + brcm,powerdown-enable; > > Undocumented property, and I would like to understand why this needs to be > specified in the Device Tree? What model of Broadcom Ethernet PHY is being > used here? It's a Broadcom BCM5421 transceiver, and that property is intended to support the optional link-down powersave from DT. It will require slight changes in drivers/net/phy/broadcom.c too and is not really necessary for minimal support, so I will drop it in the next iteration. Many thanks, Andrea > -- > Florian >