From: Aurelien Jarno <aurelien@aurel32.net>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dongjin Kim <tobetter@gmail.com>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: rockchip: Correct vendor prefix for Hardkernel ODROID-M1
Date: Mon, 26 Aug 2024 23:14:58 +0200 [thread overview]
Message-ID: <ZszwUp4UfgPSiIkl@aurel32.net> (raw)
In-Reply-To: <20240826205538.1066103-3-jonas@kwiboo.se>
On 2024-08-26 20:55, Jonas Karlman wrote:
> The vendor prefix for Hardkernel ODROID-M1 is incorrectly listed as
> rockchip. Use the proper hardkernel vendor prefix for this board.
>
> Fixes: fd3583267703 ("arm64: dts: rockchip: Add Hardkernel ODROID-M1 board")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts
> index a337f547caf5..9a122f67a6c4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts
> @@ -13,7 +13,7 @@
>
> / {
> model = "Hardkernel ODROID-M1";
> - compatible = "rockchip,rk3568-odroid-m1", "rockchip,rk3568";
> + compatible = "hardkernel,rk3568-odroid-m1", "rockchip,rk3568";
>
> aliases {
> ethernet0 = &gmac0;
Ditto, thanks for the fix.
Reviewed: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
next prev parent reply other threads:[~2024-08-26 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:55 [PATCH 0/4] arm64: dts: rockchip: Add Hardkernel ODROID-M1S Jonas Karlman
2024-08-26 20:55 ` [PATCH 1/4] dt-bindings: arm: rockchip: Correct vendor for Hardkernel ODROID-M1 Jonas Karlman
2024-08-26 21:14 ` Aurelien Jarno
2024-08-26 20:55 ` [PATCH 2/4] arm64: dts: rockchip: Correct vendor prefix " Jonas Karlman
2024-08-26 21:14 ` Aurelien Jarno [this message]
2024-08-26 20:55 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M1S Jonas Karlman
2024-08-26 20:55 ` [PATCH 4/4] arm64: dts: " Jonas Karlman
[not found] ` <66ccebe1.c80a0220.22579e.e8daSMTPIN_ADDED_BROKEN@mx.google.com>
2024-08-27 6:50 ` [PATCH 1/4] dt-bindings: arm: rockchip: Correct vendor for Hardkernel ODROID-M1 Krzysztof Kozlowski
2024-08-27 11:17 ` Jonas Karlman
[not found] ` <66ccebeb.d40a0220.356790.58caSMTPIN_ADDED_BROKEN@mx.google.com>
2024-08-27 6:52 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M1S Krzysztof Kozlowski
2024-08-27 11:29 ` Jonas Karlman
2024-08-27 11:44 ` Heiko Stuebner
2024-08-27 13:01 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZszwUp4UfgPSiIkl@aurel32.net \
--to=aurelien@aurel32.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).