From: Vinod Koul <vkoul@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X
Date: Thu, 29 Aug 2024 22:33:27 +0530 [thread overview]
Message-ID: <ZtCp346ucJq/V1kP@vaman> (raw)
In-Reply-To: <IA1PR20MB4953572077286AF23A747507BB962@IA1PR20MB4953.namprd20.prod.outlook.com>
On 29-08-24, 09:38, Inochi Amaoto wrote:
> On Wed, Aug 28, 2024 at 11:24:24PM GMT, Vinod Koul wrote:
> > On 27-08-24, 14:49, Inochi Amaoto wrote:
> > > The "top" system controller of CV18XX/SG200X exposes control
> > > register access for various devices. Add soc header file to
> > > describe it.
> >
> > I dont think I am full onboard this idea,
>
> Feel free to share your idea. I just added this file for
> convenience to access the offset of the syscon device.
> In fact, I am not sure whether it is better to use reg
> offset. Using reg adds some unncessary complexity, but
> can avoid use this offset file. If you prefer this way,
> it is OK for me to change.
I would just add the offsets that I need in local driver header and move
on...
>
> > but still need someone to ack it
>
> I am not sure there will be someone to ack it. If this patch
> is kept.
>
> > >
> > > Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> > > ---
> > > include/soc/sophgo/cv1800-sysctl.h | 30 ++++++++++++++++++++++++++++++
> >
> > is soc/sophgo/ right path? why not include/soc/sifive/... (sorry dont
> > know much about this here...)
> >
>
> CV1800 is a SoC from Sophgo, it is not from SiFive.
As I said I am not sure, someone who is from this world should ack this
header
--
~Vinod
next prev parent reply other threads:[~2024-08-29 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 6:48 [PATCH v12 0/3] riscv: sophgo: add dmamux support for Sophgo CV1800/SG2000 SoCs Inochi Amaoto
2024-08-27 6:49 ` [PATCH v12 1/3] dt-bindings: dmaengine: Add dma multiplexer for CV18XX/SG200X series SoC Inochi Amaoto
2024-08-27 6:49 ` [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X Inochi Amaoto
2024-08-28 17:54 ` Vinod Koul
2024-08-29 1:38 ` Inochi Amaoto
2024-08-29 17:03 ` Vinod Koul [this message]
2024-08-30 1:30 ` Inochi Amaoto
2024-08-27 6:49 ` [PATCH v12 3/3] dmaengine: add driver for Sophgo CV18XX/SG200X dmamux Inochi Amaoto
2024-08-28 17:56 ` Vinod Koul
2024-08-29 1:23 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtCp346ucJq/V1kP@vaman \
--to=vkoul@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox