* [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
@ 2024-08-23 2:12 Liu Ying
2024-08-23 2:33 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Liu Ying @ 2024-08-23 2:12 UTC (permalink / raw)
To: devicetree, imx, linux-arm-kernel, linux-kernel
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
alexander.stein
J17 on i.MX8mp EVK base board is a HDMI type A connector.
It connects with i.MX8mp HDMI PHY. Add support for it.
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v2:
* Change label hdmi_out to hdmi_in. (Alexander)
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 46 ++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 938347704136..d26930f1a9e9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -56,6 +56,18 @@ memory@40000000 {
<0x1 0x00000000 0 0xc0000000>;
};
+ native-hdmi-connector {
+ compatible = "hdmi-connector";
+ label = "HDMI OUT";
+ type = "a";
+
+ port {
+ hdmi_in: endpoint {
+ remote-endpoint = <&hdmi_tx_out>;
+ };
+ };
+ };
+
pcie0_refclk: pcie0-refclk {
compatible = "fixed-clock";
#clock-cells = <0>;
@@ -408,6 +420,28 @@ &flexcan2 {
status = "disabled";/* can2 pin conflict with pdm */
};
+&hdmi_pvi {
+ status = "okay";
+};
+
+&hdmi_tx {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_hdmi>;
+ status = "okay";
+
+ ports {
+ port@1 {
+ hdmi_tx_out: endpoint {
+ remote-endpoint = <&hdmi_in>;
+ };
+ };
+ };
+};
+
+&hdmi_tx_phy {
+ status = "okay";
+};
+
&i2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
@@ -604,6 +638,10 @@ &lcdif1 {
status = "okay";
};
+&lcdif3 {
+ status = "okay";
+};
+
&micfil {
#sound-dai-cells = <0>;
pinctrl-names = "default";
@@ -858,6 +896,14 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 0x140
>;
};
+ pinctrl_hdmi: hdmigrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x1c2
+ MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x1c2
+ MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x10
+ >;
+ };
+
pinctrl_hog: hoggrp {
fsl,pins = <
MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x40000010
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
2024-08-23 2:12 [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output Liu Ying
@ 2024-08-23 2:33 ` Fabio Estevam
2024-08-23 2:51 ` Liu Ying
2024-08-23 6:28 ` Alexander Stein
2024-09-01 7:38 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2024-08-23 2:33 UTC (permalink / raw)
To: Liu Ying
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
conor+dt, shawnguo, s.hauer, kernel, alexander.stein
On Thu, Aug 22, 2024 at 11:12 PM Liu Ying <victor.liu@nxp.com> wrote:
> + ports {
> + port@1 {
@1 without reg = <1>; will cause a warning.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
2024-08-23 2:33 ` Fabio Estevam
@ 2024-08-23 2:51 ` Liu Ying
2024-08-23 3:03 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Liu Ying @ 2024-08-23 2:51 UTC (permalink / raw)
To: Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
conor+dt, shawnguo, s.hauer, kernel, alexander.stein
On 08/23/2024, Fabio Estevam wrote:
> On Thu, Aug 22, 2024 at 11:12 PM Liu Ying <victor.liu@nxp.com> wrote:
>
>> + ports {
>> + port@1 {
>
> @1 without reg = <1>; will cause a warning.
reg = <1>; is in arch/arm64/boot/dts/freescale/imx8mp.dtsi,
so it is not needed here.
I don't see any warning without reg = <1>; here.
Do you see the warning you are claiming? If yes, can you
paste the warning and what command do you use to trigger the
warning?
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
2024-08-23 2:51 ` Liu Ying
@ 2024-08-23 3:03 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2024-08-23 3:03 UTC (permalink / raw)
To: Liu Ying
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
conor+dt, shawnguo, s.hauer, kernel, alexander.stein
On Thu, Aug 22, 2024 at 11:50 PM Liu Ying <victor.liu@nxp.com> wrote:
> reg = <1>; is in arch/arm64/boot/dts/freescale/imx8mp.dtsi,
> so it is not needed here.
You are right. I haven't noticed it was part of imx8mp.dtsi.
I ran 'make dtbs_check' and no warning is seen.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
2024-08-23 2:12 [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output Liu Ying
2024-08-23 2:33 ` Fabio Estevam
@ 2024-08-23 6:28 ` Alexander Stein
2024-09-01 7:38 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Alexander Stein @ 2024-08-23 6:28 UTC (permalink / raw)
To: devicetree, imx, linux-arm-kernel, linux-kernel, Liu Ying
Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam
Hi,
Am Freitag, 23. August 2024, 04:12:57 CEST schrieb Liu Ying:
> J17 on i.MX8mp EVK base board is a HDMI type A connector.
> It connects with i.MX8mp HDMI PHY. Add support for it.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> v2:
> * Change label hdmi_out to hdmi_in. (Alexander)
>
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 46 ++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index 938347704136..d26930f1a9e9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -56,6 +56,18 @@ memory@40000000 {
> <0x1 0x00000000 0 0xc0000000>;
> };
>
> + native-hdmi-connector {
> + compatible = "hdmi-connector";
> + label = "HDMI OUT";
> + type = "a";
> +
> + port {
> + hdmi_in: endpoint {
> + remote-endpoint = <&hdmi_tx_out>;
> + };
> + };
> + };
> +
> pcie0_refclk: pcie0-refclk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -408,6 +420,28 @@ &flexcan2 {
> status = "disabled";/* can2 pin conflict with pdm */
> };
>
> +&hdmi_pvi {
> + status = "okay";
> +};
> +
> +&hdmi_tx {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hdmi>;
> + status = "okay";
> +
> + ports {
> + port@1 {
> + hdmi_tx_out: endpoint {
> + remote-endpoint = <&hdmi_in>;
> + };
> + };
> + };
> +};
> +
> +&hdmi_tx_phy {
> + status = "okay";
> +};
> +
> &i2c1 {
> clock-frequency = <400000>;
> pinctrl-names = "default";
> @@ -604,6 +638,10 @@ &lcdif1 {
> status = "okay";
> };
>
> +&lcdif3 {
> + status = "okay";
> +};
> +
> &micfil {
> #sound-dai-cells = <0>;
> pinctrl-names = "default";
> @@ -858,6 +896,14 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 0x140
> >;
> };
>
> + pinctrl_hdmi: hdmigrp {
> + fsl,pins = <
> + MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x1c2
> + MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x1c2
> + MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x10
> + >;
> + };
> +
> pinctrl_hog: hoggrp {
> fsl,pins = <
> MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x40000010
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output
2024-08-23 2:12 [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output Liu Ying
2024-08-23 2:33 ` Fabio Estevam
2024-08-23 6:28 ` Alexander Stein
@ 2024-09-01 7:38 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2024-09-01 7:38 UTC (permalink / raw)
To: Liu Ying
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
conor+dt, shawnguo, s.hauer, kernel, festevam, alexander.stein
On Fri, Aug 23, 2024 at 10:12:57AM +0800, Liu Ying wrote:
> J17 on i.MX8mp EVK base board is a HDMI type A connector.
> It connects with i.MX8mp HDMI PHY. Add support for it.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-01 7:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 2:12 [PATCH v2] arm64: dts: imx8mp-evk: Add native HDMI output Liu Ying
2024-08-23 2:33 ` Fabio Estevam
2024-08-23 2:51 ` Liu Ying
2024-08-23 3:03 ` Fabio Estevam
2024-08-23 6:28 ` Alexander Stein
2024-09-01 7:38 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).