devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
@ 2024-08-27  6:47 Liu Ying
  2024-08-27  6:47 ` [PATCH 1/2] " Liu Ying
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Liu Ying @ 2024-08-27  6:47 UTC (permalink / raw)
  To: devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, quic_bjorande, geert+renesas,
	dmitry.baryshkov, neil.armstrong, arnd, nfraprado

Hi,

This patch set adds PWM backlight support for "LVDS" connector on i.MX93
11x11 EVK.

This patch set is based on next-20240826 and targets for v6.12.

Patch 1 adds device tree support for the PWM backlight.
Patch 2 updates defconfig for ARM64 to build ADP5585 MFD/GPIO/PWM drivers
as modules.

Liu Ying (2):
  arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
  arm64: defconfig: Enable ADP5585 GPIO and PWM drivers

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 30 +++++++++++++++++++
 arch/arm64/configs/defconfig                  |  3 ++
 2 files changed, 33 insertions(+)


base-commit: 1ca4237ad9ce29b0c66fe87862f1da54ac56a1e8
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
  2024-08-27  6:47 [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Liu Ying
@ 2024-08-27  6:47 ` Liu Ying
  2024-08-27 15:13   ` Frank Li
  2024-08-27  6:47 ` [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers Liu Ying
  2024-09-01  9:11 ` [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Shawn Guo
  2 siblings, 1 reply; 6+ messages in thread
From: Liu Ying @ 2024-08-27  6:47 UTC (permalink / raw)
  To: devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, quic_bjorande, geert+renesas,
	dmitry.baryshkov, neil.armstrong, arnd, nfraprado

J702 on i.MX93 11x11 EVK base board is a 40-pin connector labelled
"LVDS".  This connector supports PWM backlight with default 12V power
supply and ADP5585 PWM controller.  Add support for the backlight.

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
This patch is based on next-20240826.

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 60eb64761392..8d036b3962e9 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -62,6 +62,15 @@ vdevbuffer: vdevbuffer@a4020000 {
 
 	};
 
+	reg_vdd_12v: regulator-vdd-12v {
+		compatible = "regulator-fixed";
+		regulator-name = "VDD_12V";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+		gpio = <&pcal6524 14 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
 	reg_vref_1v8: regulator-adc-vref {
 		compatible = "regulator-fixed";
 		regulator-name = "vref_1v8";
@@ -81,6 +90,17 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		enable-active-high;
 	};
 
+	backlight_lvds: backlight-lvds {
+		compatible = "pwm-backlight";
+		pwms = <&adp5585 0 100000 0>;
+		brightness-levels = <0 100>;
+		num-interpolated-steps = <100>;
+		default-brightness-level = <100>;
+		power-supply = <&reg_vdd_12v>;
+		enable-gpios = <&adp5585 9 GPIO_ACTIVE_HIGH>;
+		status = "disabled";
+	};
+
 	bt_sco_codec: bt-sco-codec {
 		compatible = "linux,bt-sco";
 		#sound-dai-cells = <1>;
@@ -302,6 +322,16 @@ ldo5: LDO5 {
 			};
 		};
 	};
+
+	adp5585: io-expander@34 {
+		compatible = "adi,adp5585-00", "adi,adp5585";
+		reg = <0x34>;
+		vdd-supply = <&buck4>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-reserved-ranges = <5 1>;
+		#pwm-cells = <3>;
+	};
 };
 
 &lpi2c3 {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers
  2024-08-27  6:47 [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Liu Ying
  2024-08-27  6:47 ` [PATCH 1/2] " Liu Ying
@ 2024-08-27  6:47 ` Liu Ying
  2024-08-27 13:30   ` Krzysztof Kozlowski
  2024-09-01  9:11 ` [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Shawn Guo
  2 siblings, 1 reply; 6+ messages in thread
From: Liu Ying @ 2024-08-27  6:47 UTC (permalink / raw)
  To: devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, quic_bjorande, geert+renesas,
	dmitry.baryshkov, neil.armstrong, arnd, nfraprado

ADP5585 is found on i.MX93 11x11 EVK base board as a GPIO expander
and a PWM controller.  Build ADP5585 GPIO and PWM drivers as modules.
While at it, build ADP5585 MFD driver as a module because the GPIO
and PWM drivers depend on it.

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
This patch is based on next-20240826.

 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 81ca46e3ab4b..4904bfa73f85 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -657,6 +657,7 @@ CONFIG_GPIO_XGENE_SB=y
 CONFIG_GPIO_MAX732X=y
 CONFIG_GPIO_PCA953X=y
 CONFIG_GPIO_PCA953X_IRQ=y
+CONFIG_GPIO_ADP5585=m
 CONFIG_GPIO_BD9571MWV=m
 CONFIG_GPIO_MAX77620=y
 CONFIG_GPIO_SL28CPLD=m
@@ -738,6 +739,7 @@ CONFIG_UNIPHIER_WATCHDOG=y
 CONFIG_PM8916_WATCHDOG=m
 CONFIG_BCM2835_WDT=y
 CONFIG_BCM7038_WDT=m
+CONFIG_MFD_ADP5585=m
 CONFIG_MFD_ALTERA_SYSMGR=y
 CONFIG_MFD_BD9571MWV=y
 CONFIG_MFD_AXP20X_I2C=y
@@ -1489,6 +1491,7 @@ CONFIG_IIO_ST_MAGN_3AXIS=m
 CONFIG_IIO_CROS_EC_BARO=m
 CONFIG_MPL3115=m
 CONFIG_PWM=y
+CONFIG_PWM_ADP5585=m
 CONFIG_PWM_BCM2835=m
 CONFIG_PWM_BRCMSTB=m
 CONFIG_PWM_CROS_EC=m
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers
  2024-08-27  6:47 ` [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers Liu Ying
@ 2024-08-27 13:30   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-27 13:30 UTC (permalink / raw)
  To: Liu Ying, devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	catalin.marinas, will, quic_bjorande, geert+renesas,
	dmitry.baryshkov, neil.armstrong, arnd, nfraprado

On 27/08/2024 08:47, Liu Ying wrote:
> ADP5585 is found on i.MX93 11x11 EVK base board as a GPIO expander
> and a PWM controller.  Build ADP5585 GPIO and PWM drivers as modules.
> While at it, build ADP5585 MFD driver as a module because the GPIO
> and PWM drivers depend on it.
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> This patch is based on next-20240826.
> 
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
  2024-08-27  6:47 ` [PATCH 1/2] " Liu Ying
@ 2024-08-27 15:13   ` Frank Li
  0 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2024-08-27 15:13 UTC (permalink / raw)
  To: Liu Ying
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
	conor+dt, shawnguo, s.hauer, kernel, festevam, catalin.marinas,
	will, quic_bjorande, geert+renesas, dmitry.baryshkov,
	neil.armstrong, arnd, nfraprado

On Tue, Aug 27, 2024 at 02:47:16PM +0800, Liu Ying wrote:
> J702 on i.MX93 11x11 EVK base board is a 40-pin connector labelled
> "LVDS".  This connector supports PWM backlight with default 12V power
> supply and ADP5585 PWM controller.  Add support for the backlight.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> This patch is based on next-20240826.
>
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 60eb64761392..8d036b3962e9 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -62,6 +62,15 @@ vdevbuffer: vdevbuffer@a4020000 {
>
>  	};
>
> +	reg_vdd_12v: regulator-vdd-12v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VDD_12V";
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
> +		gpio = <&pcal6524 14 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
>  	reg_vref_1v8: regulator-adc-vref {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vref_1v8";
> @@ -81,6 +90,17 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
>  		enable-active-high;
>  	};
>
> +	backlight_lvds: backlight-lvds {
> +		compatible = "pwm-backlight";
> +		pwms = <&adp5585 0 100000 0>;
> +		brightness-levels = <0 100>;
> +		num-interpolated-steps = <100>;
> +		default-brightness-level = <100>;
> +		power-supply = <&reg_vdd_12v>;
> +		enable-gpios = <&adp5585 9 GPIO_ACTIVE_HIGH>;
> +		status = "disabled";
> +	};
> +
>  	bt_sco_codec: bt-sco-codec {
>  		compatible = "linux,bt-sco";
>  		#sound-dai-cells = <1>;
> @@ -302,6 +322,16 @@ ldo5: LDO5 {
>  			};
>  		};
>  	};
> +
> +	adp5585: io-expander@34 {
> +		compatible = "adi,adp5585-00", "adi,adp5585";
> +		reg = <0x34>;
> +		vdd-supply = <&buck4>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		gpio-reserved-ranges = <5 1>;
> +		#pwm-cells = <3>;
> +	};

This part will be conflict with
https://lore.kernel.org/imx/172476183829.3553281.6314012832354346473.robh@kernel.org/T/#m5e2189badf00653200421880c209312fc0aba7f3

Can I merge this to one set?

Frank

>  };
>
>  &lpi2c3 {
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
  2024-08-27  6:47 [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Liu Ying
  2024-08-27  6:47 ` [PATCH 1/2] " Liu Ying
  2024-08-27  6:47 ` [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers Liu Ying
@ 2024-09-01  9:11 ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2024-09-01  9:11 UTC (permalink / raw)
  To: Liu Ying
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, robh, krzk+dt,
	conor+dt, shawnguo, s.hauer, kernel, festevam, catalin.marinas,
	will, quic_bjorande, geert+renesas, dmitry.baryshkov,
	neil.armstrong, arnd, nfraprado

On Tue, Aug 27, 2024 at 02:47:15PM +0800, Liu Ying wrote:
> Hi,
> 
> This patch set adds PWM backlight support for "LVDS" connector on i.MX93
> 11x11 EVK.
> 
> This patch set is based on next-20240826 and targets for v6.12.
> 
> Patch 1 adds device tree support for the PWM backlight.
> Patch 2 updates defconfig for ARM64 to build ADP5585 MFD/GPIO/PWM drivers
> as modules.
> 
> Liu Ying (2):
>   arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector
>   arm64: defconfig: Enable ADP5585 GPIO and PWM drivers

Applied both, thanks!


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-09-01  9:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27  6:47 [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Liu Ying
2024-08-27  6:47 ` [PATCH 1/2] " Liu Ying
2024-08-27 15:13   ` Frank Li
2024-08-27  6:47 ` [PATCH 2/2] arm64: defconfig: Enable ADP5585 GPIO and PWM drivers Liu Ying
2024-08-27 13:30   ` Krzysztof Kozlowski
2024-09-01  9:11 ` [PATCH 0/2] arm64: dts: imx93-11x11-evk: Add PWM backlight for "LVDS" connector Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).