* [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks
2024-09-16 8:23 [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks Johan Hovold
@ 2024-09-16 8:23 ` Johan Hovold
2024-09-18 17:14 ` Rob Herring (Arm)
2024-10-16 7:47 ` Johan Hovold
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Johan Hovold @ 2024-09-16 8:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel, Johan Hovold
The x1e80100 QMP PCIe PHYs all have a pipediv2 clock that needs to be
described.
Fixes: e94b29f2bd73 ("dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHYs")
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
index dcf4fa55fbba..447b379aa83d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
@@ -154,8 +154,6 @@ allOf:
- qcom,sm8550-qmp-gen4x2-pcie-phy
- qcom,sm8650-qmp-gen3x2-pcie-phy
- qcom,sm8650-qmp-gen4x2-pcie-phy
- - qcom,x1e80100-qmp-gen3x2-pcie-phy
- - qcom,x1e80100-qmp-gen4x2-pcie-phy
then:
properties:
clocks:
@@ -171,6 +169,8 @@ allOf:
- qcom,sc8280xp-qmp-gen3x1-pcie-phy
- qcom,sc8280xp-qmp-gen3x2-pcie-phy
- qcom,sc8280xp-qmp-gen3x4-pcie-phy
+ - qcom,x1e80100-qmp-gen3x2-pcie-phy
+ - qcom,x1e80100-qmp-gen4x2-pcie-phy
- qcom,x1e80100-qmp-gen4x4-pcie-phy
then:
properties:
--
2.44.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks
2024-09-16 8:23 ` [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks Johan Hovold
@ 2024-09-18 17:14 ` Rob Herring (Arm)
2024-10-16 7:47 ` Johan Hovold
1 sibling, 0 replies; 11+ messages in thread
From: Rob Herring (Arm) @ 2024-09-18 17:14 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Conor Dooley, Sibi Sankar, linux-phy,
Rajendra Nayak, Abel Vesa, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio, Kishon Vijay Abraham I,
Vinod Koul, linux-arm-msm
On Mon, 16 Sep 2024 10:23:05 +0200, Johan Hovold wrote:
> The x1e80100 QMP PCIe PHYs all have a pipediv2 clock that needs to be
> described.
>
> Fixes: e94b29f2bd73 ("dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHYs")
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks
2024-09-16 8:23 ` [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks Johan Hovold
2024-09-18 17:14 ` Rob Herring (Arm)
@ 2024-10-16 7:47 ` Johan Hovold
1 sibling, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 7:47 UTC (permalink / raw)
To: Vinod Koul
Cc: Bjorn Andersson, Konrad Dybcio, Kishon Vijay Abraham I,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Rajendra Nayak,
Sibi Sankar, linux-arm-msm, linux-phy, devicetree, linux-kernel
Hi Vinod,
On Mon, Sep 16, 2024 at 10:23:05AM +0200, Johan Hovold wrote:
> The x1e80100 QMP PCIe PHYs all have a pipediv2 clock that needs to be
> described.
>
> Fixes: e94b29f2bd73 ("dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHYs")
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Bjorn has now picked up the DT fixes for 6.12, but we need this binding
change too to avoid checker warnings.
Could you pick this one up for 6.12-rc?
Johan
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
2024-09-16 8:23 [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks Johan Hovold
2024-09-16 8:23 ` [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks Johan Hovold
@ 2024-09-16 8:23 ` Johan Hovold
2024-09-16 11:36 ` Abel Vesa
2024-09-16 23:31 ` Konrad Dybcio
2024-09-16 8:23 ` [PATCH 3/3] arm64: dts: qcom: x1e80100: fix PCIe5 " Johan Hovold
` (2 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Johan Hovold @ 2024-09-16 8:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel, Johan Hovold, stable
Add the missing clkref enable and pipediv2 clocks to the PCIe4 and
PCIe6a PHYs.
Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
Cc: stable@vger.kernel.org # 6.9
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 0cf4f3c12428..53e7d1e603cb 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -2980,14 +2980,16 @@ pcie6a_phy: phy@1bfc000 {
clocks = <&gcc GCC_PCIE_6A_PHY_AUX_CLK>,
<&gcc GCC_PCIE_6A_CFG_AHB_CLK>,
- <&rpmhcc RPMH_CXO_CLK>,
+ <&tcsr TCSR_PCIE_4L_CLKREF_EN>,
<&gcc GCC_PCIE_6A_PHY_RCHNG_CLK>,
- <&gcc GCC_PCIE_6A_PIPE_CLK>;
+ <&gcc GCC_PCIE_6A_PIPE_CLK>,
+ <&gcc GCC_PCIE_6A_PIPEDIV2_CLK>;
clock-names = "aux",
"cfg_ahb",
"ref",
"rchng",
- "pipe";
+ "pipe",
+ "pipediv2";
resets = <&gcc GCC_PCIE_6A_PHY_BCR>,
<&gcc GCC_PCIE_6A_NOCSR_COM_PHY_BCR>;
@@ -3232,14 +3234,16 @@ pcie4_phy: phy@1c0e000 {
clocks = <&gcc GCC_PCIE_4_AUX_CLK>,
<&gcc GCC_PCIE_4_CFG_AHB_CLK>,
- <&rpmhcc RPMH_CXO_CLK>,
+ <&tcsr TCSR_PCIE_2L_4_CLKREF_EN>,
<&gcc GCC_PCIE_4_PHY_RCHNG_CLK>,
- <&gcc GCC_PCIE_4_PIPE_CLK>;
+ <&gcc GCC_PCIE_4_PIPE_CLK>,
+ <&gcc GCC_PCIE_4_PIPEDIV2_CLK>;
clock-names = "aux",
"cfg_ahb",
"ref",
"rchng",
- "pipe";
+ "pipe",
+ "pipediv2";
resets = <&gcc GCC_PCIE_4_PHY_BCR>;
reset-names = "phy";
--
2.44.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
@ 2024-09-16 11:36 ` Abel Vesa
2024-09-16 23:31 ` Konrad Dybcio
1 sibling, 0 replies; 11+ messages in thread
From: Abel Vesa @ 2024-09-16 11:36 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy, devicetree,
linux-kernel, stable
On 24-09-16 10:23:06, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the PCIe4 and
> PCIe6a PHYs.
>
> Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
> Cc: stable@vger.kernel.org # 6.9
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 0cf4f3c12428..53e7d1e603cb 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -2980,14 +2980,16 @@ pcie6a_phy: phy@1bfc000 {
>
> clocks = <&gcc GCC_PCIE_6A_PHY_AUX_CLK>,
> <&gcc GCC_PCIE_6A_CFG_AHB_CLK>,
> - <&rpmhcc RPMH_CXO_CLK>,
> + <&tcsr TCSR_PCIE_4L_CLKREF_EN>,
> <&gcc GCC_PCIE_6A_PHY_RCHNG_CLK>,
> - <&gcc GCC_PCIE_6A_PIPE_CLK>;
> + <&gcc GCC_PCIE_6A_PIPE_CLK>,
> + <&gcc GCC_PCIE_6A_PIPEDIV2_CLK>;
> clock-names = "aux",
> "cfg_ahb",
> "ref",
> "rchng",
> - "pipe";
> + "pipe",
> + "pipediv2";
>
> resets = <&gcc GCC_PCIE_6A_PHY_BCR>,
> <&gcc GCC_PCIE_6A_NOCSR_COM_PHY_BCR>;
> @@ -3232,14 +3234,16 @@ pcie4_phy: phy@1c0e000 {
>
> clocks = <&gcc GCC_PCIE_4_AUX_CLK>,
> <&gcc GCC_PCIE_4_CFG_AHB_CLK>,
> - <&rpmhcc RPMH_CXO_CLK>,
> + <&tcsr TCSR_PCIE_2L_4_CLKREF_EN>,
> <&gcc GCC_PCIE_4_PHY_RCHNG_CLK>,
> - <&gcc GCC_PCIE_4_PIPE_CLK>;
> + <&gcc GCC_PCIE_4_PIPE_CLK>,
> + <&gcc GCC_PCIE_4_PIPEDIV2_CLK>;
> clock-names = "aux",
> "cfg_ahb",
> "ref",
> "rchng",
> - "pipe";
> + "pipe",
> + "pipediv2";
>
> resets = <&gcc GCC_PCIE_4_PHY_BCR>;
> reset-names = "phy";
> --
> 2.44.2
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
2024-09-16 11:36 ` Abel Vesa
@ 2024-09-16 23:31 ` Konrad Dybcio
1 sibling, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2024-09-16 23:31 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel, stable
On 16.09.2024 10:23 AM, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the PCIe4 and
> PCIe6a PHYs.
>
> Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
> Cc: stable@vger.kernel.org # 6.9
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
I reckon you split it like you day so that it's easier to backport..
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: x1e80100: fix PCIe5 PHY clocks
2024-09-16 8:23 [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks Johan Hovold
2024-09-16 8:23 ` [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks Johan Hovold
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
@ 2024-09-16 8:23 ` Johan Hovold
2024-09-16 23:31 ` Konrad Dybcio
2024-10-07 14:25 ` (subset) [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe " Bjorn Andersson
2024-10-17 15:31 ` Vinod Koul
4 siblings, 1 reply; 11+ messages in thread
From: Johan Hovold @ 2024-09-16 8:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel, Johan Hovold
Add the missing clkref enable and pipediv2 clocks to the PCIe5 PHY.
Fixes: 62ab23e15508 ("arm64: dts: qcom: x1e80100: add PCIe5 nodes")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 53e7d1e603cb..d1bb14a375c3 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -3104,14 +3104,16 @@ pcie5_phy: phy@1c06000 {
clocks = <&gcc GCC_PCIE_5_AUX_CLK>,
<&gcc GCC_PCIE_5_CFG_AHB_CLK>,
- <&rpmhcc RPMH_CXO_CLK>,
+ <&tcsr TCSR_PCIE_2L_5_CLKREF_EN>,
<&gcc GCC_PCIE_5_PHY_RCHNG_CLK>,
- <&gcc GCC_PCIE_5_PIPE_CLK>;
+ <&gcc GCC_PCIE_5_PIPE_CLK>,
+ <&gcc GCC_PCIE_5_PIPEDIV2_CLK>;
clock-names = "aux",
"cfg_ahb",
"ref",
"rchng",
- "pipe";
+ "pipe",
+ "pipediv2";
resets = <&gcc GCC_PCIE_5_PHY_BCR>;
reset-names = "phy";
--
2.44.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: x1e80100: fix PCIe5 PHY clocks
2024-09-16 8:23 ` [PATCH 3/3] arm64: dts: qcom: x1e80100: fix PCIe5 " Johan Hovold
@ 2024-09-16 23:31 ` Konrad Dybcio
0 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2024-09-16 23:31 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On 16.09.2024 10:23 AM, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the PCIe5 PHY.
>
> Fixes: 62ab23e15508 ("arm64: dts: qcom: x1e80100: add PCIe5 nodes")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks
2024-09-16 8:23 [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks Johan Hovold
` (2 preceding siblings ...)
2024-09-16 8:23 ` [PATCH 3/3] arm64: dts: qcom: x1e80100: fix PCIe5 " Johan Hovold
@ 2024-10-07 14:25 ` Bjorn Andersson
2024-10-17 15:31 ` Vinod Koul
4 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2024-10-07 14:25 UTC (permalink / raw)
To: Konrad Dybcio, Vinod Koul, Johan Hovold
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On Mon, 16 Sep 2024 10:23:04 +0200, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the x1e80100 PCIe
> PHYs as needed for functional PCIe (e.g. without relying on boot
> firmware to have left these on).
>
> Johan
>
>
> [...]
Applied, thanks!
[2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
commit: 27727cb6604e0998d03d9ec063b517b239d2bb0f
[3/3] arm64: dts: qcom: x1e80100: fix PCIe5 PHY clocks
commit: 0b80b3c0f6d20f1bc1f7fea6176a8df15619e884
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: (subset) [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks
2024-09-16 8:23 [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe PHY clocks Johan Hovold
` (3 preceding siblings ...)
2024-10-07 14:25 ` (subset) [PATCH 0/3] arm64: dts: qcom: x1e80100: fix missing PCIe " Bjorn Andersson
@ 2024-10-17 15:31 ` Vinod Koul
4 siblings, 0 replies; 11+ messages in thread
From: Vinod Koul @ 2024-10-17 15:31 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Johan Hovold
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On Mon, 16 Sep 2024 10:23:04 +0200, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the x1e80100 PCIe
> PHYs as needed for functional PCIe (e.g. without relying on boot
> firmware to have left these on).
>
> Johan
>
>
> [...]
Applied, thanks!
[1/3] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: add missing x1e80100 pipediv2 clocks
commit: 938ade15abaea765dfab32d906de45657067c11f
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 11+ messages in thread