From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC131547E1; Wed, 18 Sep 2024 09:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726651756; cv=none; b=JHfy80Z+FsQOMrCVQBJlFlTkDWSa6yYQ/DUvOGiFWWv/meV/0KrE+SwukGnyuq3YQb+jmWRk9zfS4Kp740BbDqBcAPIqRvJUXRs2zXqD/KnUK9kLE8aYDo3DOT1AqCDVRyJKkE9Mw2nP722nXPmUIQ53GHO5JINS057b8q7EDdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726651756; c=relaxed/simple; bh=49jKeQJsL3Uv3oaN2Hnvr9pW2xAjMqMoWaw0AEwgOPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qgc4WhpqXL6aL0EBXgjOA0ubb0xilnU1g0ke59pAzzisH2XbyHd4BjGohcUL238ciUp8BOFRL8tQr0KU47uid8rOCyeP9HdkPpUvwMm/1pBpmDl5rlP/eCKtjsR7XXkH31w/soKdPzUJrvk+T0gQg3qdrvKnYFMEOGzUiVNWD/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VLrEY4+Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VLrEY4+Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16635C4CEC3; Wed, 18 Sep 2024 09:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726651756; bh=49jKeQJsL3Uv3oaN2Hnvr9pW2xAjMqMoWaw0AEwgOPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VLrEY4+Q9HW3zyAIxZI9mXVDnMMLfWsld4aGYOLrhgrZk/ymrg/rr8DPtYrY5dUJ/ CDJXwM5xWspG11bw1VTegTKibhzmgUIkcvylEwNgXmUbERItBqylGAacFSYds4FtAs S2UIU1OowvXHKubP2h5SLA++xLCvhSBGeunyQtetjHZa85G4JSifCUlM45spQHpn3I LwBumlaj0v3HcfyrRQJ/NxzBM4Xq1RKe6TaDTpdBmjWWlWYY3MZT0ESNgnejd95Hlj 7THB6hD5Hbl63jsdjbTDAYMvmN0A7xTrZdjhK0LUspxnuy+bme8N5d8uXzmUCvuV/j ok9B/3JWTsrcA== Received: from johan by theta with local (Exim 4.98) (envelope-from ) id 1sqqzo-000000000st-1qiO; Wed, 18 Sep 2024 11:29:12 +0200 Date: Wed, 18 Sep 2024 11:29:12 +0200 From: Johan Hovold To: Srinivas Kandagatla Cc: andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, abel.vesa@linaro.org Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support Message-ID: References: <20240917150049.3110-1-srinivas.kandagatla@linaro.org> <5932fc68-3afd-448b-99b8-65ee9ef5dda6@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5932fc68-3afd-448b-99b8-65ee9ef5dda6@kernel.org> On Wed, Sep 18, 2024 at 01:32:34AM +0200, Konrad Dybcio wrote: > On 17.09.2024 5:00 PM, srinivas.kandagatla@linaro.org wrote: > > From: Srinivas Kandagatla > > > > Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is > > at I2C address 0x2c add this to be able to get it working on these laptops. > > > > Signed-off-by: Srinivas Kandagatla > > --- > > Changes since v1: > > - moved pinctrl to parent node so that pinctrl can be claimed globally. > > &i2c0 { > > clock-frequency = <400000>; > > > > + pinctrl-0 = <&tpad_default>; > > + pinctrl-names = "default"; > > You're dropping the QUP pins, please include them too (like in c630.dtsi) And make sure to CC people that provide feedback on your patches when respinning. Johan