From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michael Wu <Michael.Wu@kneron.us>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
morgan chang <morgan.chang@kneron.us>,
"mvp.kutali@gmail.com" <mvp.kutali@gmail.com>
Subject: Re: [PATCH v3 2/2] i2c: dwsignware: determine HS tHIGH and tLOW based on HW parameters
Date: Wed, 2 Oct 2024 17:17:44 +0300 [thread overview]
Message-ID: <Zv1WCAROWamTfI4z@smile.fi.intel.com> (raw)
In-Reply-To: <IA1PR14MB62241CADFE580EC861C591F58A702@IA1PR14MB6224.namprd14.prod.outlook.com>
On Wed, Oct 02, 2024 at 09:31:00AM +0000, Michael Wu wrote:
> > On Tue, Oct 01, 2024 at 04:29:34PM +0800, Michael Wu wrote:
...
> > > + * @bus_capacitance_pf: bus capacitance in picofarads
> >
> > Since it seems a new version of the series is warranted, and looking into
> > the current kernel source (no other users of this unit were observed),
> > I think we may do correct capitalisation here for the sake of physics
> > and unit system, i.e.
> >
> > * @bus_capacitance_pF: bus capacitance in picofarads
>
> Are you serious?
Are we in the circus?
> I have never seen capital letters used to declare a
> variable name. Although checkpatch.pl does not consider this as an issue,
> is this against everyone's custom or unspoken rules?
I do not really care about checkpatch or any rules as any good rule will have
a few exceptions anyway. The rationale here is to follow the science with much
longer history than anything related to the computer programming.
Now, since you haven't looked for the existing examples, try this
git grep -n _u[AV]\;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-02 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 8:29 [PATCH v3 0/2] Compute HS HCNT and LCNT based on HW parameters Michael Wu
2024-10-01 8:29 ` [PATCH v3 1/2] dt-bindings: i2c: snps,designware-i2c: declare bus capacitance and clk freq optimized Michael Wu
2024-10-02 6:08 ` Krzysztof Kozlowski
2024-10-02 9:20 ` Michael Wu
2024-10-02 9:50 ` Krzysztof Kozlowski
2024-10-02 9:36 ` Michael Wu
2024-10-01 8:29 ` [PATCH v3 2/2] i2c: dwsignware: determine HS tHIGH and tLOW based on HW parameters Michael Wu
2024-10-01 11:14 ` Andi Shyti
2024-10-01 13:00 ` Andy Shevchenko
2024-10-02 9:31 ` Michael Wu
2024-10-02 14:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1WCAROWamTfI4z@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Wu@kneron.us \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=morgan.chang@kneron.us \
--cc=mvp.kutali@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).