From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Divya.Koppera@microchip.com, hkallweit1@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux@armlinux.org.uk, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add timing-role role property for ethernet PHYs
Date: Thu, 3 Oct 2024 15:08:09 +0200 [thread overview]
Message-ID: <Zv6XOXveg-dU_t8V@pengutronix.de> (raw)
In-Reply-To: <a11860cc-5804-4a15-9603-624406a29dba@lunn.ch>
On Thu, Oct 03, 2024 at 02:08:00PM +0200, Andrew Lunn wrote:
> > > + - 'force-master': The PHY is forced to operate as a master.
> > > + - 'force-slave': The PHY is forced to operate as a slave.
> > > + - 'prefer-master': Prefer the PHY to be master but allow negotiation.
> > > + - 'prefer-slave': Prefer the PHY to be slave but allow negotiation.
> > > +
> >
> > I would suggest to use "preferred" instead of "prefer" to be in sync with existing phy library macros.
>
> How does 802.3 name it?
802.3 use "Multiport device" for "preferred master" and "single-port device"
for "preferred slave". We decided to use other wording back in the past
to avoid confusing and align it with forced master/slave configurations.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-10-03 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 7:37 [PATCH net-next v4 0/2] net: phy: Support master-slave config via device tree Oleksij Rempel
2024-10-01 7:37 ` [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add timing-role role property for ethernet PHYs Oleksij Rempel
2024-10-02 4:29 ` Florian Fainelli
2024-10-03 10:49 ` Divya.Koppera
2024-10-03 12:08 ` Andrew Lunn
2024-10-03 13:08 ` Oleksij Rempel [this message]
2024-10-03 17:05 ` Andrew Lunn
2024-10-04 16:51 ` Jakub Kicinski
2024-10-07 5:15 ` Oleksij Rempel
2024-10-01 7:37 ` [PATCH net-next v4 2/2] net: phy: Add support for PHY timing-role configuration via device tree Oleksij Rempel
2024-10-02 4:29 ` Florian Fainelli
2024-10-03 10:45 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv6XOXveg-dU_t8V@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Divya.Koppera@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).