From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DA8A10A1E for ; Thu, 3 Oct 2024 13:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727960926; cv=none; b=Xrw0Ub8NgTFn2F8w18uTRvCLmqRT/RmB3Sb7r+HSBvSGMrfFyR3FNaf/YyFD7xKJhMFdyiJNZU+q4GF8ugstuOInR9eC4+ZiihYjQVdNGMn1+TQDEK4J+REk4W3Ywcqc9OoiN3smU7Z052cyaIsmK8ClmlXATT9PC/upA8G0mWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727960926; c=relaxed/simple; bh=SelwsqHaGZaURAnqjiIGoBucyH/dMkn416f0nfBim8k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p/qelaic4iL65n7QX1qjHvuPs6ZowRIkws95OM50OHCzcNbp8yefAz7VMYEu0FE0CfR6yXwPi8FXuUc3oLGtp47Vc/e/GAXCcqOMF+STRWisP/+5eyXE1H6tClRM8DE7NU6dT74bS7hcPmnp/jWZ6X5ANWEtVPaPf1iOlXZPvFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swLYx-0005pi-7l; Thu, 03 Oct 2024 15:08:11 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1swLYv-003LUY-Ga; Thu, 03 Oct 2024 15:08:09 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1swLYv-008kld-1I; Thu, 03 Oct 2024 15:08:09 +0200 Date: Thu, 3 Oct 2024 15:08:09 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Divya.Koppera@microchip.com, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux@armlinux.org.uk, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add timing-role role property for ethernet PHYs Message-ID: References: <20241001073704.1389952-1-o.rempel@pengutronix.de> <20241001073704.1389952-2-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Thu, Oct 03, 2024 at 02:08:00PM +0200, Andrew Lunn wrote: > > > + - 'force-master': The PHY is forced to operate as a master. > > > + - 'force-slave': The PHY is forced to operate as a slave. > > > + - 'prefer-master': Prefer the PHY to be master but allow negotiation. > > > + - 'prefer-slave': Prefer the PHY to be slave but allow negotiation. > > > + > > > > I would suggest to use "preferred" instead of "prefer" to be in sync with existing phy library macros. > > How does 802.3 name it? 802.3 use "Multiport device" for "preferred master" and "single-port device" for "preferred slave". We decided to use other wording back in the past to avoid confusing and align it with forced master/slave configurations. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |