From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Rob Herring <robh@kernel.org>
Cc: Kunwu Chan <chentao@kylinos.cn>,
saravanak@google.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/2] amba: Add dev_is_amba() function and export it for modules
Date: Tue, 24 Sep 2024 23:43:59 +0100 [thread overview]
Message-ID: <ZvNAr0d5gYmuM+Zt@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240924222857.GA404805-robh@kernel.org>
On Tue, Sep 24, 2024 at 05:28:57PM -0500, Rob Herring wrote:
> On Mon, Sep 23, 2024 at 05:42:47PM +0800, Kunwu Chan wrote:
> > Add dev_is_amba() function to determine
> > whether the device is a AMBA device.
> >
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> > ---
> > drivers/amba/bus.c | 6 ++++++
> > include/linux/amba/bus.h | 5 +++++
> > 2 files changed, 11 insertions(+)
>
> Russell, Can I get an ack for this to take it with patch #2.
Would be nice to discuss "how shall we merge this cross-subsystem
patch series" first, hmm?
The reason I didn't take patch 1 originally is because it was submitted
to me without any users, and the general principle is not to accept
patches without users. Too many times, I've merged code where there's
been a "promise" that it will be used, only to have the author go
silent and users never come along. So now, my rule is... any code that
adds something must also come with its user.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-09-24 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 9:42 [PATCH 0/2] Add dev_is_amba and replace the usage in platform Kunwu Chan
2024-09-23 9:42 ` [PATCH 1/2] amba: Add dev_is_amba() function and export it for modules Kunwu Chan
2024-09-23 11:11 ` Andy Shevchenko
2024-09-23 11:12 ` Andy Shevchenko
2024-09-24 22:28 ` Rob Herring
2024-09-24 22:43 ` Russell King (Oracle) [this message]
2024-09-30 1:39 ` Kunwu Chan
2024-10-02 2:11 ` Rob Herring
2024-09-23 9:42 ` [PATCH 2/2] of/platform: PCI: Use dev_is_platform/dev_is_amba to identify platform/amba devices Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvNAr0d5gYmuM+Zt@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chentao@kylinos.cn \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).