From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D92C1AD3E0; Tue, 24 Sep 2024 22:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727217853; cv=none; b=aI60vPg1jCXsyy7CU2v4SMCJi7Oo7heYi/aN08JAT/jGJQ5mZgP8nZW2kvVcQ494jrHbzNrqMpmj/luTv9LHFfQCVLxsFHEJezZUkQcEsVs//2juR7UH89SrNGwSPKfc0w5TR8vtwZFNm8+SFlyd09B5MBKSfhInbAKlaR8c5q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727217853; c=relaxed/simple; bh=1kak7Papg+REt0YX9qEAPqyd0bv8zJRl0skoenBu4Es=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hsuot/I8OkNjlYB5WNMMQzMgbPTXYoZ17RAY7btCl22wMB0OIHJ344Zy+Xi0gw2X2MYvW5eHL4yd7ZUvuddnFytnxSAY+z+AMIxC6RXHRj4Og2Jw831IeqtbsMdBMqEnq310oHBxgjwL925FJSEzKbbogxTOanUIZCqK71aI7QM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=UMVXgnwR; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="UMVXgnwR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IIQp0fRS7W4DUEIrqrSf6cHBI+Xpz5AzpoihIU8mkY0=; b=UMVXgnwRJoohfetEiSKOCMwFSf 9exaMvMbJWlLxNI2qwm1q/J7FFqtVvH7OEzUP31x47dJPc3t+VVQpNrBxoj6CUlmATQ8mgqqZRqw1 0GsxMl8cO2R3vx23sKuatXPMQwf4yIbp2GdwGfzcakpD4e8rWIc615AubZjeUkSu3VvxeJeAgd5WF D9mKzyFYnZ5a+G51Xo/pbeulxQ2CHvNNzcVkY2OJBslnGBsiRX71Q9oitwXA4b/8Tp2FCL9vpVUjh 6/RxNwLCmri8W5hesrDL1DwjafIH3L3shMteym3zHNN8gDveoyaSYlYNNBTnmbkyMMSvdW6qdP0aN iGBwSoXg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39768) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1stEGJ-0005vY-1Z; Tue, 24 Sep 2024 23:44:03 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1stEGF-0006ki-3D; Tue, 24 Sep 2024 23:44:00 +0100 Date: Tue, 24 Sep 2024 23:43:59 +0100 From: "Russell King (Oracle)" To: Rob Herring Cc: Kunwu Chan , saravanak@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH 1/2] amba: Add dev_is_amba() function and export it for modules Message-ID: References: <20240923094249.80399-1-chentao@kylinos.cn> <20240923094249.80399-2-chentao@kylinos.cn> <20240924222857.GA404805-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924222857.GA404805-robh@kernel.org> Sender: Russell King (Oracle) On Tue, Sep 24, 2024 at 05:28:57PM -0500, Rob Herring wrote: > On Mon, Sep 23, 2024 at 05:42:47PM +0800, Kunwu Chan wrote: > > Add dev_is_amba() function to determine > > whether the device is a AMBA device. > > > > Suggested-by: Andy Shevchenko > > Signed-off-by: Kunwu Chan > > --- > > drivers/amba/bus.c | 6 ++++++ > > include/linux/amba/bus.h | 5 +++++ > > 2 files changed, 11 insertions(+) > > Russell, Can I get an ack for this to take it with patch #2. Would be nice to discuss "how shall we merge this cross-subsystem patch series" first, hmm? The reason I didn't take patch 1 originally is because it was submitted to me without any users, and the general principle is not to accept patches without users. Too many times, I've merged code where there's been a "promise" that it will be used, only to have the author go silent and users never come along. So now, my rule is... any code that adds something must also come with its user. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!