Devicetree
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property
Date: Wed, 25 Sep 2024 14:19:06 -0400	[thread overview]
Message-ID: <ZvRUGvX9ZL4YVeMf@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240925173438.1906339-1-robh@kernel.org>

On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> If this is not correct, then #interrupt-cells needs to be added.
> ---
>  .../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml  | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> index 799ae5c3e32a..b5282c857f44 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> @@ -62,8 +62,6 @@ properties:
>        - const: processor-a-side
>        - const: processor-b-side
>
> -  interrupt-controller: true
> -
>    msi-controller: true
>
>    "#msi-cells":
> @@ -73,7 +71,6 @@ required:
>    - compatible
>    - reg
>    - interrupts
> -  - interrupt-controller
>    - msi-controller
>    - "#msi-cells"
>
> @@ -88,7 +85,6 @@ examples:
>          compatible = "fsl,imx6sx-mu-msi";
>          msi-controller;
>          #msi-cells = <0>;
> -        interrupt-controller;
>          reg = <0x5d270000 0x10000>,     /* A side */
>                <0x5d300000 0x10000>;     /* B side */
>          reg-names = "processor-a-side", "processor-b-side";
> --
> 2.45.2
>

  reply	other threads:[~2024-09-25 18:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 17:34 [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property Rob Herring (Arm)
2024-09-25 18:19 ` Frank Li [this message]
2024-09-26 16:57 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvRUGvX9ZL4YVeMf@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox