From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F9081AB6E3 for ; Thu, 26 Sep 2024 09:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727344308; cv=none; b=bYs6wdawSQUClLxjCa6d1qtW2Dm2Lc4OmARn+unTDbkiYNMVxHyUlkKtgHeYyEsiY5TLmeYEUWqht1x/ZtW4cHkRxtvGzY5Gvcc6JvBZJzhCvXA/ij7pmSe5g+b14Jjzu/ei6mtQ4VLu1ws9u28GH+zaUeqH6fcfIGWe1VXTSMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727344308; c=relaxed/simple; bh=MeZglqA06DnL1H7gm+Zs18dfjnpbHKT50cVInRoBADM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HGlwUSPK3xsCDilQDc2EyCV/eian/B0SUd6vtNpfQlkGSND4lH/BmDPrhrwExjEPfnps9/pi3FEOOkYNmetIrFoq2BkOCMirN/Ivh7Suh15amhp8eDW8hwOZTCyD/9sEsn4VNo7OJZEKUQt8BdbMaB//p7CJtC1uJ3WZQbmlf9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stl9p-00074F-OI; Thu, 26 Sep 2024 11:51:33 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stl9o-001ekP-60; Thu, 26 Sep 2024 11:51:32 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1stl9o-00D9Vs-0H; Thu, 26 Sep 2024 11:51:32 +0200 Date: Thu, 26 Sep 2024 11:51:32 +0200 From: Sascha Hauer To: Pankaj Gupta Cc: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [EXT] Re: [PATCH v7 4/5] firmware: imx: add driver for NXP EdgeLock Enclave Message-ID: References: <20240904-imx-se-if-v7-0-5afd2ab74264@nxp.com> <20240904-imx-se-if-v7-4-5afd2ab74264@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Pankaj, On Wed, Sep 25, 2024 at 12:00:28PM +0000, Pankaj Gupta wrote: > >> Yes. > > > > > Don't do this. > > > >> Shall the retry counter to be removed, to make it predictable? > >>Or am I missing something. > > >Either compile the firmware into the kernel or the ELE driver as module. > > Cannot compile as part of Firmware. > There are OTA scenarios where the latest FW, that is downloaded to replace > the image in RFS, and FW needs to be re-init with this new image, by putting > the Linux to power-down state. > > ELE driver is compiled as module only, by default. But if someone like to > make it as in-line to kernel image, still it should work. I am also not very happy with the situation that we can't compile drivers into the kernel and just get the firmware later once it is available. That's the situation we are in though and if you want to change it you have to discuss this with the firmware maintainers. What you've done in the ELE driver is a hack and I doubt that you get this through. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |