From: Andy Shevchenko <andy@kernel.org>
To: Ramona Alexandra Nechita <ramona.nechita@analog.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sa" <nuno.sa@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Dumitru Ceclan" <mitrutzceclan@gmail.com>,
"Matteo Martelli" <matteomartelli3@gmail.com>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/3] Documentation: ABI: added filter mode doc in sysfs-bus-iio
Date: Thu, 26 Sep 2024 17:12:01 +0300 [thread overview]
Message-ID: <ZvVrsXrm8XBYGeRn@smile.fi.intel.com> (raw)
In-Reply-To: <20240926135418.8342-3-ramona.nechita@analog.com>
On Thu, Sep 26, 2024 at 04:53:56PM +0300, Ramona Alexandra Nechita wrote:
> The filter mode / filter type property is used for ad4130
> and ad7779 drivers, therefore the ABI doc file for ad4130
> was removed, merging both of them in the sysfs-bus-iio.
> Since one of the drivers is available from 6.1, the version
> has been set to 6.1 for these attributes.
...
> +Description:
> + Reading returns a list with the possible filter modes. Options
> + for the attribute:
> + * "sinc3" - The digital sinc3 filter. Moderate 1st conversion time.
> + Good noise performance.
> + * "sinc4" - Sinc 4. Excellent noise performance. Long
> + 1st conversion time.
> + * "sinc5" - The digital sinc5 filter. Excellent noise performance
> + * "sinc4+sinc1" - Sinc4 + averaging by 8. Low 1st conversion
> + time.
> + * "sinc3+rej60" - Sinc3 + 60Hz rejection.
> + * "sinc3+sinc1" - Sinc3 + averaging by 8. Low 1st conversion
> + time.
> + * "sinc3+pf1" - Sinc3 + device specific Post Filter 1.
> + * "sinc3+pf2" - Sinc3 + device specific Post Filter 2.
> + * "sinc3+pf3" - Sinc3 + device specific Post Filter 3.
> + * "sinc3+pf4" - Sinc3 + device specific Post Filter 4.
I still think that a compromise to leave the existing values as an example in
the existing bindings is a good to have.
But if Jonathan thinks otherwise, I'm not against it.
For the rest
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-26 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 13:53 [PATCH v6 0/3] add support for ad777x family Ramona Alexandra Nechita
2024-09-26 13:53 ` [PATCH v6 1/3] dt-bindings: iio: adc: add a7779 doc Ramona Alexandra Nechita
2024-09-26 15:40 ` Conor Dooley
2024-09-26 13:53 ` [PATCH v6 2/3] Documentation: ABI: added filter mode doc in sysfs-bus-iio Ramona Alexandra Nechita
2024-09-26 14:12 ` Andy Shevchenko [this message]
2024-09-26 14:12 ` Andy Shevchenko
2024-09-28 17:52 ` Jonathan Cameron
2024-09-26 13:53 ` [PATCH v6 3/3] drivers: iio: adc: add support for ad777x family Ramona Alexandra Nechita
2024-09-26 14:58 ` Andy Shevchenko
2024-10-10 14:32 ` Nechita, Ramona
2024-10-10 17:45 ` Jonathan Cameron
2024-10-10 18:25 ` Andy Shevchenko
2024-10-12 10:42 ` Jonathan Cameron
2024-10-15 11:08 ` Andy Shevchenko
2024-10-10 17:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvVrsXrm8XBYGeRn@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marius.cristea@microchip.com \
--cc=matteomartelli3@gmail.com \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).