From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629E3158219 for ; Sat, 28 Sep 2024 20:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727556357; cv=none; b=Mk+HUuma2Hg+MAQPpdefnRnuQUAYLWry4vtTGRxghTCJCaTqhPcjT8gL/rrKjKSqWaLtvMayD1cXj5WOV62G0KeQAKbB8TaGQwzMZG6+OCSu+FMI3rnS3NPn8eulOil6Rrwo0yHyFN+bnQvOnt9Ti2+1cySC++6meOctbh4dHUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727556357; c=relaxed/simple; bh=++L5szp7rHdLiJY+uwC07z9zRCqc0llaxr7Vs9fQq8M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BoGTroOgHuycfCw0US3AFMsar0998Pa14PDuXrD4BWuNRvXc2F3NlJVX86tGtg0H0D576x79cB77+d1WCNA2wW3guQISKfcwLOAflC4NhkMr52oIBt+b3ygxl4NoOtNqYH2Pw5gdPyKKSe6Gm/9gamD809+aTTlcOQHcwTzdC9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com; spf=pass smtp.mailfrom=tenstorrent.com; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b=UBzmOwSP; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b="UBzmOwSP" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2068acc8b98so34639725ad.3 for ; Sat, 28 Sep 2024 13:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1727556355; x=1728161155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B1wN4Mv6KTR3klc618UZyJIvaPfyrd+I69sEqUZILgs=; b=UBzmOwSP/YKctCDsjP4uYRZteL4kgfzYxygXMbk5sRIWM7u9ADTibOjXACg8gtSMuo VrYUrxprZNCjtKEf7btXU7uozTY3UWkmFxRXiZsLpHuHh8C+GaTclbDrS6NBxtjISICq Ja3w2T59/qdaKnytqf0tqUZgNZKmZMB3DAZgEvCFvZSJgfHwQHUAa0q3k5oEY1FGo116 M08vBzgK9F6/kX4ESMpmHOON/nGegHfp4LW8dBNGj32M4i5uSL2d4vW5OoYsfET8pOGa 8nTHaA3eJKsQXdgkQ64D9sAi0wr6Do3LxpNlH4gsg+2IJonY05am9R2BKoOn4rcV1BWA g3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727556355; x=1728161155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B1wN4Mv6KTR3klc618UZyJIvaPfyrd+I69sEqUZILgs=; b=YdLWZSZ/bJ1yEK8HrqALVPHW/W2Zv+0T13pkRlEzH4E7g/fYDOsIVchoM0Zik/4i5B ofEKwUQxqTk6adgUs8kNdzavIXGTQgxzDDuvuyOFE30TKynctOZUskidSoP96FxlAcXS 6SSoilHGOjUhFmZIU0GWHKh7eyJkLIJrKP0AamnBwQ5GxYAoGdRAksqOsdyGAHLK/9rf f9Sxb4DukFsnx2ItWB3+2ktENKQWhRPhQ/Z8nFmsu5b7ifK7kxmvni63sX+2dxxdLS7r fiTkP99WP6GoXMBsZUyGfmpPD+HGz9KzRpdosA6qxY4Xb6J1lcVeGWp8BF9/dynQt3N3 YehA== X-Forwarded-Encrypted: i=1; AJvYcCULjzbHoXag71G7xiqgUAfZ3kYFFvZmGwGFANtmW3fcAnYyeiK+/5EJhRp8bOE4X4bBOq0GxCtgkQvG@vger.kernel.org X-Gm-Message-State: AOJu0Yx9m1dIgPAqrDh2iqjYVmsJzVI/FIlSpUhKyO8DunEhuj6htTYw fx+M2tNye7WQ8VxJRLdh8Eh0AHZIL3NeZJONO8axMGyCyIFwmhn6wk+iCVyY8mI= X-Google-Smtp-Source: AGHT+IHYe5C2dCeMbXLolGkdYVgGv6vaXYzm7QHCg36ZJ1QQJYHSFNwHxNkSM+iWKcxoee+lJlo/DA== X-Received: by 2002:a17:902:c952:b0:20b:6a57:bf3a with SMTP id d9443c01a7336-20b6a57c137mr21788895ad.1.1727556354766; Sat, 28 Sep 2024 13:45:54 -0700 (PDT) Received: from x1 (71-34-69-82.ptld.qwest.net. [71.34.69.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e2f382sm30487635ad.182.2024.09.28.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2024 13:45:54 -0700 (PDT) Date: Sat, 28 Sep 2024 13:45:52 -0700 From: Drew Fustini To: Emil Renner Berthing Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Jisheng Zhang , Maxime Coquelin , Drew Fustini , Guo Ren , Fu Wei , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 3/3] riscv: dts: thead: Add TH1520 ethernet nodes Message-ID: References: <20240926-th1520-dwmac-v2-0-f34f28ad1dc9@tenstorrent.com> <20240926-th1520-dwmac-v2-3-f34f28ad1dc9@tenstorrent.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 27, 2024 at 05:55:04AM -0700, Emil Renner Berthing wrote: > Drew Fustini wrote: > > From: Emil Renner Berthing > > > > Signed-off-by: Emil Renner Berthing > > [drew: change apb registers from syscon to second reg of gmac node] > > [drew: add phy reset delay properties for beaglev ahead] > > Signed-off-by: Drew Fustini > > --- > > arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 91 ++++++++++++++ > > .../boot/dts/thead/th1520-lichee-module-4a.dtsi | 135 +++++++++++++++++++++ > > arch/riscv/boot/dts/thead/th1520.dtsi | 50 ++++++++ > > 3 files changed, 276 insertions(+) > > ... > > > diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > index ca84bc2039ef..d9d2e1f4dc68 100644 > > --- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > +++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi > > @@ -11,6 +11,11 @@ / { > > model = "Sipeed Lichee Module 4A"; > > compatible = "sipeed,lichee-module-4a", "thead,th1520"; > > > > + aliases { > > + ethernet0 = &gmac0; > > + ethernet1 = &gmac1; > > + }; > > + > > memory@0 { > > device_type = "memory"; > > reg = <0x0 0x00000000 0x2 0x00000000>; > > @@ -25,6 +30,16 @@ &osc_32k { > > clock-frequency = <32768>; > > }; > > > > +&dmac0 { > > + status = "okay"; > > +}; > > + > > +&aogpio { > > + gpio-line-names = "", "", "", > > + "GPIO00", > > + "GPIO04"; > > +}; > > + > > These GPIO line names does not belong in this patch. They should > already be included in your other patchset adding the names for the > other lines. > > /Emil Thanks, yeah, those sneaked in here. Drew