From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mtd: davinci: add support for on-die ECC engine type
Date: Wed, 2 Oct 2024 09:49:44 +0200 [thread overview]
Message-ID: <Zvz7GDA278Vam4nQ@gmail.com> (raw)
In-Reply-To: <20241001221032.525be1e4@xps-13>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
Hi Miquel,
On Tue, Oct 01, 2024 at 10:10:32PM +0200, Miquel Raynal wrote:
> Hi Marcus,
>
> marcus.folkesson@gmail.com wrote on Tue, 01 Oct 2024 12:42:27 +0200:
>
> > Some chips, e.g. Micron MT29F1G08ABBFAH4, has a mandatory on-die ECC.
> > Add "on-die" as ECC engine type in order to be compatible with those.
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
> > Documentation/devicetree/bindings/mtd/davinci-nand.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > index eb8e2ff4dbd2901b3c396f2e66c1f590a32dcf67..9afda5cd956494c6b3171bdbaecaeb289acd64ea 100644
> > --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > @@ -44,6 +44,7 @@ Recommended properties :
> > - "none"
> > - "soft"
> > - "hw"
> > + - "on-die"
>
> This file is very legacy and this addition would be totally unneeded if
> that file had been converted to yaml earlier. Just referencing
> nand-controller.yaml will authorize nand-ecc-mode = "on-die" (while
> still marking it legacy). Would you mind converting this file please?
Sure, I will give it a try.
I will send out a v2 later today.
>
> Thanks,
> Miquèl
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-10-02 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 10:42 [PATCH 0/2] Add support for "on-die" ECC on Davinci Marcus Folkesson
2024-10-01 10:42 ` [PATCH 1/2] mtd: nand: davinci: add support for on-die ECC engine type Marcus Folkesson
2024-10-01 10:42 ` [PATCH 2/2] dt-bindings: mtd: " Marcus Folkesson
2024-10-01 20:10 ` Miquel Raynal
2024-10-02 7:49 ` Marcus Folkesson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvz7GDA278Vam4nQ@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).