From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bayard.4d2.org (bayard.4d2.org [5.78.89.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7FD206E71; Wed, 16 Oct 2024 12:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.78.89.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729080676; cv=none; b=gNVT0HFVFIH8p3t74+OOTqy0qYYsnYHJXO72JdVxdshsUdnMBxO1eL0JQSXQFKRK+gpu981tvRSbTSlYX66cSuEjqB3XO/TYpDQuMLeUOdqh4m6q7tMycljN98H5s1Gp7mV/Odfn/pnd+r67ogjNbWmJVYfStELjT7dXw1NFRTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729080676; c=relaxed/simple; bh=5au/Y6lHx9RILAX4XAzjvna8Dcwx0ccjy4QV4i4w1h8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gavWSA3iSaIzPnLuKlruEeyCJQXkp3ckvaKKHd6POWfXoVq+F9l7VM2TzfG6iW1PPG9H8gJYCbLSgq5vcF0hZ5TJFkI6Q3H0uqt64e5a88B9S6H7sno3NHUsto3lxU2Y5LMxmDrEotwAUlRqFe+pg2iFyt50D6iKLtA7+Rbo+Ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=4d2.org; spf=pass smtp.mailfrom=4d2.org; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b=UqEFLH55; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b=fLjWDXVy; arc=none smtp.client-ip=5.78.89.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=4d2.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=4d2.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b="UqEFLH55"; dkim=pass (2048-bit key) header.d=4d2.org header.i=@4d2.org header.b="fLjWDXVy" Received: from bayard.4d2.org (bayard.4d2.org [127.0.0.1]) by bayard.4d2.org (Postfix) with ESMTP id 8DD8E122FE21; Wed, 16 Oct 2024 05:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=4d2.org; s=mail; t=1729080672; bh=5au/Y6lHx9RILAX4XAzjvna8Dcwx0ccjy4QV4i4w1h8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UqEFLH55uaSOX/NeuD3TfOJu5iWZLazr0D5+gLMdSSMHupSAZ79soHUA7Q84COpdh KAWJQVaT3W5sgPWnB09fC8D/kREVaiYmeOyhfgvhVWFMKE5Z2nEs3KpOM+aa8oIgy9 6GejQQrBkj+qxjIY88l8pLXZHXlMRjE5wj4UCu0890+9CJimxROb4oQg33ANIGTjGk iOzimKfk3CiUPPrOo1/6fTkG1Ef4dzaPO4BOM0WBGCcZ7v/8loT7aTDoUe8V2n+Hhr S+CivcllVybAe6i/EoYV4XfxPN86E4qzNzxvInADvgNMmjRLTL04WQtGqWEmTOuwcI /0bvTdkgF+/XA== X-Virus-Scanned: amavisd-new at 4d2.org Received: from bayard.4d2.org ([127.0.0.1]) by bayard.4d2.org (bayard.4d2.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HfPDK2MCEsy1; Wed, 16 Oct 2024 05:11:05 -0700 (PDT) Received: from ketchup (unknown [110.52.220.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) (Authenticated sender: heylenay@4d2.org) by bayard.4d2.org (Postfix) with ESMTPSA id 573C5122FE1A; Wed, 16 Oct 2024 05:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=4d2.org; s=mail; t=1729080665; bh=5au/Y6lHx9RILAX4XAzjvna8Dcwx0ccjy4QV4i4w1h8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fLjWDXVydOzI2+TjesEQT1OGRb+Fga4ioSMX4+jV+dPMTUhYGL1SHxeJgp7V1+Csj AoTEKw7+GVe6YQfmQgiGklKuc11pgcE1Jwpu8RPhfVtis/zUiGDqo3ZpTySTmZrAKh RhNV5dK2gg9oloym95LE6a/QH3/wllbdrfI7Wl8a30riesx5HxwnFZtc6BEGsHU7E+ eYGn62p/W2lJc9lyel7pXUiKKxst/QmIV97gCKs6GdzH8PcZK962cpQ1JxyvFUoOSs J4ewNTnXZmRz5maFWo6kNx0L0CAjTgOLE/8kCoYl2EGsMxupBHxjbQVPGWAfCQTcuz BI+Afi1mVbqAQ== Date: Wed, 16 Oct 2024 12:10:52 +0000 From: Haylen Chu To: Krzysztof Kozlowski , Haylen Chu Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Inochi Amaoto , Chen Wang , Jisheng Zhang Subject: Re: [PATCH v2 2/3] dt-bindings: clock: spacemit: Add clock controllers of Spacemit K1 SoC Message-ID: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 17, 2024 at 08:39:37AM +0200, Krzysztof Kozlowski wrote: > On Mon, Sep 16, 2024 at 10:23:09PM +0000, Haylen Chu wrote: > > Add definition for the clock controllers of Spacemit K1 SoC. The clock > > tree is managed by several SoC parts, thus different compatible strings > > are added for each. > > > > spacemit,k1-syscon.yaml is updated as well to allow clock controller > > being its subnode. > > > > Signed-off-by: Haylen Chu > > Please order patches correctly. First this, then the parent so you will > not submit incomplete binding. > > You still must test it, though :( Thanks for the tip. > > --- > > .../bindings/clock/spacemit,k1-ccu.yaml | 71 +++++++ > > .../soc/spacemit/spacemit,k1-syscon.yaml | 4 + > > include/dt-bindings/clock/spacemit,k1-ccu.h | 198 ++++++++++++++++++ > > 3 files changed, 273 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/spacemit,k1-ccu.yaml > > create mode 100644 include/dt-bindings/clock/spacemit,k1-ccu.h > > > > diff --git a/Documentation/devicetree/bindings/clock/spacemit,k1-ccu.yaml b/Documentation/devicetree/bindings/clock/spacemit,k1-ccu.yaml > > new file mode 100644 > > index 000000000000..0186722cfd87 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/spacemit,k1-ccu.yaml > > @@ -0,0 +1,71 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/spacemit,k1-ccu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Spacemit K1 SoC Clock Controller > > + > > +maintainers: > > + - Haylen Chu > > + > > +properties: > > + compatible: > > + enum: > > + - spacemit,k1-ccu-apbs > > + - spacemit,k1-ccu-mpmu > > + - spacemit,k1-ccu-apbc > > + - spacemit,k1-ccu-apmu > > + > > + clocks: > > + minItems: 4 > > Drop > > > + maxItems: 4 > > + > > + clock-names: > > + items: > > + - const: clk_32k > > + - const: vctcxo_1 > > + - const: vctcxo_24 > > + - const: vctcxo_3 > > + > > + spacemit,mpmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing "Main PMU (MPMU)" registers. It is used to > > + check PLL lock status. > > + > > + "#clock-cells": > > + const: 1 > > + description: > > + See for valid indices. > > + > > +required: > > + - compatible > > + - "#clock-cells" > > + > > +additionalProperties: false > > Move it after allOf block > > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: spacemit,k1-ccu-apbs > > + then: > > + required: > > + - compatible > > + - "#clock-cells" > > Drop both, redundant > > > > + - spacemit,mpmu > > + > > +examples: > > + - | > > + syscon_apbs: system-control@d4090000 { > > Only one example, keep it in parent node. Should I drop the example block in this binding completely and move it to its parent's binding (the syscon) or just drop the parent here? > > + compatible = "spacemit,k1-apbs-syscon", "syscon", "simple-mfd"; > > + reg = <0x0 0xd4090000 0x0 0x1000>; > > + > > + clk_apbs: clock-controller { > > + compatible = "spacemit,k1-ccu-apbs"; > > + #clock-cells = <1>; > > + spacemit,mpmu = <&syscon_mpmu>; > > + }; > > + }; > > diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > index 4e3a72b48aff..08efda207101 100644 > > --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml > > @@ -27,6 +27,10 @@ properties: > > reg: > > maxItems: 1 > > > > + clock-controller: > > + $ref: /schemas/clock/spacemit,k1-ccu.yaml# > > + type: object > > + > > This MUST be part of other patch. > > Best regards, > Krzysztof > I will adapt all the comments in next version. Best regards, Haylen Chu