From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Troy Mitchell <troymitchell988@gmail.com>,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC
Date: Tue, 15 Oct 2024 11:21:57 +0200 [thread overview]
Message-ID: <Zw40NajLjMa_AnY4@shikoro> (raw)
In-Reply-To: <eb4112aa-21d0-4537-a18c-940d8832711a@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
> > +static inline u32 spacemit_i2c_read_reg(struct spacemit_i2c_dev *i2c, int reg)
> > +{
> > + return readl(i2c->base + reg);
>
> So basically short and obvious code like this:
>
> readl(i2c->base + reg);
>
> you replace with:
>
> spacemit_i2c_read_reg(i2c, reg)
>
> how is this helpful?
I always have the same question when I see this. However, I don't blame
Troy. We have quite some occurances of this in the kernel, so I wouldn't
be surprised if people think this is a kernel-style-pattern :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-10-15 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 7:51 [PATCH v1 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2024-10-15 7:51 ` [PATCH v1 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-10-15 8:02 ` Krzysztof Kozlowski
2024-10-15 16:47 ` Conor Dooley
2024-10-16 2:45 ` Troy Mitchell
2024-10-16 7:44 ` Krzysztof Kozlowski
2024-10-15 9:22 ` Rob Herring (Arm)
2024-10-15 7:51 ` [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2024-10-15 8:08 ` Krzysztof Kozlowski
2024-10-15 9:21 ` Wolfram Sang [this message]
2024-10-18 5:17 ` Troy Mitchell
2024-10-18 6:05 ` Krzysztof Kozlowski
2024-10-18 8:33 ` Troy Mitchell
2024-10-18 8:39 ` Krzysztof Kozlowski
2024-10-15 9:17 ` Wolfram Sang
2024-10-16 2:26 ` Troy Mitchell
2024-10-16 7:06 ` Wolfram Sang
2024-10-16 9:39 ` Uwe Kleine-König
2024-10-21 7:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw40NajLjMa_AnY4@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox