[PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Richard Zhu]

v5 changes:
- Correct subject prefix.

v4 changes:
- Add Frank's reviewed tag, and re-format the commit message.

v3 changes:
- Refine the commit descriptions.

v2 changes:
Thanks for Conor's comments.
- Place the new added properties at the end.

Ideally, dbi2 and atu base addresses should be fetched from DT.
Add dbi2 and atu base addresses for i.MX8M PCIe EP here.

[PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
[PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ
[PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP
[PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM

Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++----
arch/arm64/boot/dts/freescale/imx8mm.dtsi                    |  8 +++++---
arch/arm64/boot/dts/freescale/imx8mp.dtsi                    |  7 +++++--
arch/arm64/boot/dts/freescale/imx8mq.dtsi                    |  8 +++++---
4 files changed, 24 insertions(+), 12 deletions(-)

[PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Richard Zhu]

Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.

For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.

In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
preparation to do that for i.MX8M PCIe EP.

These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according base
addresses from DT directly. If only two reg properties are provided, i.MX
PCIe driver would fall back to the old method.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
index a06f75df8458..84ca12e8b25b 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
@@ -65,12 +65,14 @@ allOf:
     then:
       properties:
         reg:
-          minItems: 2
-          maxItems: 2
+          minItems: 4
+          maxItems: 4
         reg-names:
           items:
             - const: dbi
             - const: addr_space
+            - const: dbi2
+            - const: atu
 
   - if:
       properties:
@@ -129,8 +131,11 @@ examples:
 
     pcie_ep: pcie-ep@33800000 {
       compatible = "fsl,imx8mp-pcie-ep";
-      reg = <0x33800000 0x000400000>, <0x18000000 0x08000000>;
-      reg-names = "dbi", "addr_space";
+      reg = <0x33800000 0x100000>,
+            <0x18000000 0x8000000>,
+            <0x33900000 0x100000>,
+            <0x33b00000 0x100000>;
+      reg-names = "dbi", "addr_space", "dbi2", "atu";
       clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
                <&clk IMX8MP_CLK_HSIO_AXI>,
                <&clk IMX8MP_CLK_PCIE_ROOT>;
-- 
2.37.1

[PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ PCIe EP

[Richard Zhu]

Add dbi2 and iatu reg for i.MX8MQ PCIe EP.

For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.

In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
preparation to do that for i.MX8MQ PCIe EP.

These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according base
addresses from DT directly. If only two reg properties are provided, i.MX
PCIe driver would fall back to the old method.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index e03186bbc415..d51de8d899b2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1819,9 +1819,11 @@ pcie1: pcie@33c00000 {
 
 		pcie1_ep: pcie-ep@33c00000 {
 			compatible = "fsl,imx8mq-pcie-ep";
-			reg = <0x33c00000 0x000400000>,
-			      <0x20000000 0x08000000>;
-			reg-names = "dbi", "addr_space";
+			reg = <0x33c00000 0x100000>,
+			      <0x20000000 0x8000000>,
+			      <0x33d00000 0x100000>,
+			      <0x33f00000 0x100000>;
+			reg-names = "dbi", "addr_space", "dbi2", "atu";
 			num-lanes = <1>;
 			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "dma";
-- 
2.37.1

[PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP PCIe EP

[Richard Zhu]

Add dbi2 and iatu reg for i.MX8MP PCIe EP.

For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.

In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
preparation to do that for i.MX8MP PCIe EP.

These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according base
addresses from DT directly. If only two reg properties are provided, i.MX
PCIe driver would fall back to the old method.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 603dfe80216f..53748227db10 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -2125,8 +2125,11 @@ pcie: pcie@33800000 {
 
 		pcie_ep: pcie-ep@33800000 {
 			compatible = "fsl,imx8mp-pcie-ep";
-			reg = <0x33800000 0x000400000>, <0x18000000 0x08000000>;
-			reg-names = "dbi", "addr_space";
+			reg = <0x33800000 0x100000>,
+			      <0x18000000 0x8000000>,
+			      <0x33900000 0x100000>,
+			      <0x33b00000 0x100000>;
+			reg-names = "dbi", "addr_space", "dbi2", "atu";
 			clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
 				 <&clk IMX8MP_CLK_HSIO_AXI>,
 				 <&clk IMX8MP_CLK_PCIE_ROOT>;
-- 
2.37.1

[PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM PCIe EP

[Richard Zhu]

Add dbi2 and iatu reg for i.MX8MM PCIe EP.

For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.

In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
preparation to do that for i.MX8MM PCIe EP.

These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according base
addresses from DT directly. If only two reg properties are provided, i.MX
PCIe driver would fall back to the old method.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 9535dedcef59..4de3bf22902b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -1375,9 +1375,11 @@ pcie0: pcie@33800000 {
 
 		pcie0_ep: pcie-ep@33800000 {
 			compatible = "fsl,imx8mm-pcie-ep";
-			reg = <0x33800000 0x400000>,
-			      <0x18000000 0x8000000>;
-			reg-names = "dbi", "addr_space";
+			reg = <0x33800000 0x100000>,
+			      <0x18000000 0x8000000>,
+			      <0x33900000 0x100000>,
+			      <0x33b00000 0x100000>;
+			reg-names = "dbi", "addr_space", "dbi2", "atu";
 			num-lanes = <1>;
 			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "dma";
-- 
2.37.1

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Krzysztof Kozlowski]

On 13/08/2024 09:42, Richard Zhu wrote:
> Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> 
> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> driver. This method is not good.
> 
> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
> preparation to do that for i.MX8M PCIe EP.
> 
> These changes wouldn't break driver function. When "dbi2" and "atu"
> properties are present, i.MX PCIe driver would fetch the according base
> addresses from DT directly. If only two reg properties are provided, i.MX
> PCIe driver would fall back to the old method.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>

This is some random tagging! You add tags, then drop, then add other
people. No, it does not work like this.

Where was this tag given?

Where are other tags?

Why did you drop them? Why this is not explained?

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

Re: [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ PCIe EP

[Krzysztof Kozlowski]

On 13/08/2024 09:42, Richard Zhu wrote:
> Add dbi2 and iatu reg for i.MX8MQ PCIe EP.
> 
> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> driver. This method is not good.
> 
> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
> preparation to do that for i.MX8MQ PCIe EP.
> 
> These changes wouldn't break driver function. When "dbi2" and "atu"
> properties are present, i.MX PCIe driver would fetch the according base
> addresses from DT directly. If only two reg properties are provided, i.MX
> PCIe driver would fall back to the old method.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>

Stop adding fake tags. This never happened. If it happened, provide lore
link.

Best regards,
Krzysztof

Re: [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ PCIe EP

[Krzysztof Kozlowski]

On 13/08/2024 10:54, Krzysztof Kozlowski wrote:
> On 13/08/2024 09:42, Richard Zhu wrote:
>> Add dbi2 and iatu reg for i.MX8MQ PCIe EP.
>>
>> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
>> driver. This method is not good.
>>
>> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
>> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
>> preparation to do that for i.MX8MQ PCIe EP.
>>
>> These changes wouldn't break driver function. When "dbi2" and "atu"
>> properties are present, i.MX PCIe driver would fetch the according base
>> addresses from DT directly. If only two reg properties are provided, i.MX
>> PCIe driver would fall back to the old method.
>>
>> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> 
> Stop adding fake tags. This never happened. If it happened, provide lore
> link.
> 

Ah, my bad, now I see it. It's fine, sorry.

Best regards,
Krzysztof

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Rob Herring (Arm)]

On Tue, 13 Aug 2024 15:42:20 +0800, Richard Zhu wrote:
> Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> 
> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> driver. This method is not good.
> 
> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
> preparation to do that for i.MX8M PCIe EP.
> 
> These changes wouldn't break driver function. When "dbi2" and "atu"
> properties are present, i.MX PCIe driver would fetch the according base
> addresses from DT directly. If only two reg properties are provided, i.MX
> PCIe driver would fall back to the old method.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

RE: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Hongxing Zhu]

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: 2024年8月14日 0:33
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: shawnguo@kernel.org; linux-pci@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> conor+dt@kernel.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de; l.stach@pengutronix.de; krzk+dt@kernel.org
> Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> "atu" for i.MX8M PCIe Endpoint
> 
> 
> On Tue, 13 Aug 2024 15:42:20 +0800, Richard Zhu wrote:
> > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> >
> > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> > driver. This method is not good.
> >
> > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> > Frank suggests to fetch the dbi2 and atu from DT directly. This commit
> > is preparation to do that for i.MX8M PCIe EP.
> >
> > These changes wouldn't break driver function. When "dbi2" and "atu"
> > properties are present, i.MX PCIe driver would fetch the according
> > base addresses from DT directly. If only two reg properties are
> > provided, i.MX PCIe driver would fall back to the old method.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13
> > +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> Missing tags:
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Hi Rob:
Oops, I'm really sorry about that I missing this reviewed-by tag in v5 by
 my mistake.
Thank you very much for your notice and kindly help.

Hi Shawn:
Can you help to pick-up Rob's reviewed-by tag?
Thanks in advanced.

Best Regards
Richard Zhu
> 
> 

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Shawn Guo]

On Wed, Aug 14, 2024 at 01:49:30AM +0000, Hongxing Zhu wrote:
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> > 
> > If a tag was not added on purpose, please state why and what changed.
> > 
> > Missing tags:
> > 
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Hi Rob:
> Oops, I'm really sorry about that I missing this reviewed-by tag in v5 by
>  my mistake.
> Thank you very much for your notice and kindly help.
> 
> Hi Shawn:
> Can you help to pick-up Rob's reviewed-by tag?
> Thanks in advanced.

Hmm, this one should go via PCI tree.

Shawn

Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Shawn Guo]

On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> v5 changes:
> - Correct subject prefix.
> 
> v4 changes:
> - Add Frank's reviewed tag, and re-format the commit message.
> 
> v3 changes:
> - Refine the commit descriptions.
> 
> v2 changes:
> Thanks for Conor's comments.
> - Place the new added properties at the end.
> 
> Ideally, dbi2 and atu base addresses should be fetched from DT.
> Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> 
> [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP
> [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM

Applied 3 DTS patches, thanks!

RE: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Hongxing Zhu]

Hi Shawn:
Thanks for your help.

Hi Krzysztof:
Can you help to pick up the #1 patch?
Thanks in advanced.

Best Regards
Richard Zhu

> -----Original Message-----
> From: Shawn Guo <shawnguo2@yeah.net>
> Sent: 2024年8月31日 21:00
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>; shawnguo@kernel.org;
> linux-pci@vger.kernel.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; conor+dt@kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org; kernel@pengutronix.de;
> l.stach@pengutronix.de; krzk+dt@kernel.org
> Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> "atu" for i.MX8M PCIe Endpoint
> 
> On Wed, Aug 14, 2024 at 01:49:30AM +0000, Hongxing Zhu wrote:
> > > Please add Acked-by/Reviewed-by tags when posting new versions.
> > > However, there's no need to repost patches *only* to add the tags.
> > > The upstream maintainer will do that for acks received on the version they
> apply.
> > >
> > > If a tag was not added on purpose, please state why and what changed.
> > >
> > > Missing tags:
> > >
> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Hi Rob:
> > Oops, I'm really sorry about that I missing this reviewed-by tag in v5
> > by  my mistake.
> > Thank you very much for your notice and kindly help.
> >
> > Hi Shawn:
> > Can you help to pick-up Rob's reviewed-by tag?
> > Thanks in advanced.
> 
> Hmm, this one should go via PCI tree.
> 
> Shawn

Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Shawn Guo]

On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote:
> On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> > v5 changes:
> > - Correct subject prefix.
> > 
> > v4 changes:
> > - Add Frank's reviewed tag, and re-format the commit message.
> > 
> > v3 changes:
> > - Refine the commit descriptions.
> > 
> > v2 changes:
> > Thanks for Conor's comments.
> > - Place the new added properties at the end.
> > 
> > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> > 
> > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> > [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP
> > [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM
> 
> Applied 3 DTS patches, thanks!

I have to take them out from my branch for now.  Ping me when bindings
change gets applied.

Shawn

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Frank Li]

On Mon, Sep 02, 2024 at 02:08:05AM +0000, Hongxing Zhu wrote:
> Hi Shawn:
> Thanks for your help.
>
> Hi Krzysztof:
> Can you help to pick up the #1 patch?
> Thanks in advanced.

Add Bjorn Helgaas, I am not sure why origial To/Cc list have not bjorn.

Bjorn:
	Could you please take care this patch, which already acked by Rob?
	We don't want to missed this merge windows for this trivial binding
change.

Frank

>
> Best Regards
> Richard Zhu
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo2@yeah.net>
> > Sent: 2024年8月31日 21:00
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: Rob Herring (Arm) <robh@kernel.org>; shawnguo@kernel.org;
> > linux-pci@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; conor+dt@kernel.org;
> > imx@lists.linux.dev; linux-kernel@vger.kernel.org; kernel@pengutronix.de;
> > l.stach@pengutronix.de; krzk+dt@kernel.org
> > Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> > "atu" for i.MX8M PCIe Endpoint
> >
> > On Wed, Aug 14, 2024 at 01:49:30AM +0000, Hongxing Zhu wrote:
> > > > Please add Acked-by/Reviewed-by tags when posting new versions.
> > > > However, there's no need to repost patches *only* to add the tags.
> > > > The upstream maintainer will do that for acks received on the version they
> > apply.
> > > >
> > > > If a tag was not added on purpose, please state why and what changed.
> > > >
> > > > Missing tags:
> > > >
> > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > > Hi Rob:
> > > Oops, I'm really sorry about that I missing this reviewed-by tag in v5
> > > by  my mistake.
> > > Thank you very much for your notice and kindly help.
> > >
> > > Hi Shawn:
> > > Can you help to pick-up Rob's reviewed-by tag?
> > > Thanks in advanced.
> >
> > Hmm, this one should go via PCI tree.
> >
> > Shawn
>

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Krzysztof Wilczyński]

Hello,

> Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> 
> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> driver. This method is not good.
> 
> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
> preparation to do that for i.MX8M PCIe EP.
> 
> These changes wouldn't break driver function. When "dbi2" and "atu"
> properties are present, i.MX PCIe driver would fetch the according base
> addresses from DT directly. If only two reg properties are provided, i.MX
> PCIe driver would fall back to the old method.

Applied to dt-bindings, thank you!

[1/1] dt-bindings: PCI: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint
      https://git.kernel.org/pci/pci/c/2f309c988b7c

	Krzysztof

RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Hongxing Zhu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1871 bytes --]

> -----Original Message-----
> From: Shawn Guo <shawnguo2@yeah.net>
> Sent: 2024Äê9ÔÂ4ÈÕ 17:39
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> Subject: Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
>
> On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote:
> > On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> > > v5 changes:
> > > - Correct subject prefix.
> > >
> > > v4 changes:
> > > - Add Frank's reviewed tag, and re-format the commit message.
> > >
> > > v3 changes:
> > > - Refine the commit descriptions.
> > >
> > > v2 changes:
> > > Thanks for Conor's comments.
> > > - Place the new added properties at the end.
> > >
> > > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> > >
> > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> > > [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP
> > > [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM
> >
> > Applied 3 DTS patches, thanks!
>
> I have to take them out from my branch for now.  Ping me when bindings
> change gets applied.

Hi Shawn:
The dts bindings change had been merged by Krzysztof Wilczy¨½ski.
Can you help to merge the others?
Thanks in advanced.

[1/1] dt-bindings: PCI: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint
      https://git.kernel.org/pci/pci/c/2f309c988b7c

Best Regards
Richard Zhu
>
> Shawn

RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Hongxing Zhu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2848 bytes --]

> -----Original Message-----
> From: Hongxing Zhu
> Sent: 2024Äê9ÔÂ9ÈÕ 9:44
> To: Shawn Guo <shawnguo2@yeah.net>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> Subject: RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo2@yeah.net>
> > Sent: 2024Äê9ÔÂ4ÈÕ 17:39
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> > shawnguo@kernel.org; l.stach@pengutronix.de;
> > devicetree@vger.kernel.org; linux-pci@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de;
> > imx@lists.linux.dev
> > Subject: Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
> >
> > On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote:
> > > On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> > > > v5 changes:
> > > > - Correct subject prefix.
> > > >
> > > > v4 changes:
> > > > - Add Frank's reviewed tag, and re-format the commit message.
> > > >
> > > > v3 changes:
> > > > - Refine the commit descriptions.
> > > >
> > > > v2 changes:
> > > > Thanks for Conor's comments.
> > > > - Place the new added properties at the end.
> > > >
> > > > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > > > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> > > >
> > > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > > > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for
> > > > i.MX8MQ [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg
> > > > for i.MX8MP [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu
> > > > reg for i.MX8MM
> > >
> > > Applied 3 DTS patches, thanks!
> >
> > I have to take them out from my branch for now.  Ping me when bindings
> > change gets applied.
>
> Hi Shawn:
> The dts bindings change had been merged by Krzysztof Wilczy¨½ski.
> Can you help to merge the others?
> Thanks in advanced.
>
> [1/1] dt-bindings: PCI: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M
> PCIe Endpoint
>
> https://git.kernel/
> .org%2Fpci%2Fpci%2Fc%2F2f309c988b7c&data=05%7C02%7Chongxing.zhu%4
> 0nxp.com%7Cc3d67d4240204d73f20a08dcce3d81dc%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C638612010789051203%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
> n0%3D%7C0%7C%7C%7C&sdata=OQIwkZwJQWDo9YhVHboSEkUIyVdKS0ULGrz
> dJH2YGEc%3D&reserved=0

Hi Shawn:
Ping.

Best Regards
Richard Zhu

>
> Best Regards
> Richard Zhu
> >
> > Shawn

RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Hongxing Zhu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2432 bytes --]

> -----Original Message-----
> From: Hongxing Zhu
> Sent: 2024Äê9ÔÂ9ÈÕ 9:44
> To: Shawn Guo <shawnguo2@yeah.net>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> Subject: RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo2@yeah.net>
> > Sent: 2024Äê9ÔÂ4ÈÕ 17:39
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> > shawnguo@kernel.org; l.stach@pengutronix.de;
> > devicetree@vger.kernel.org; linux-pci@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de;
> > imx@lists.linux.dev
> > Subject: Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
> >
> > On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote:
> > > On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> > > > v5 changes:
> > > > - Correct subject prefix.
> > > >
> > > > v4 changes:
> > > > - Add Frank's reviewed tag, and re-format the commit message.
> > > >
> > > > v3 changes:
> > > > - Refine the commit descriptions.
> > > >
> > > > v2 changes:
> > > > Thanks for Conor's comments.
> > > > - Place the new added properties at the end.
> > > >
> > > > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > > > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> > > >
> > > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > > > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for
> > > > i.MX8MQ [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg
> > > > for i.MX8MP [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu
> > > > reg for i.MX8MM
> > >
> > > Applied 3 DTS patches, thanks!
> >
> > I have to take them out from my branch for now.  Ping me when bindings
> > change gets applied.
> 
> Hi Shawn:
> The dts bindings change had been merged by Krzysztof Wilczy¨½ski.
> Can you help to merge the others?
> Thanks in advanced.
> 
Don't know why can't send the email out successfully.
Remove the url, re-send again.

Best Regards
Richard Zhu

> 
> Best Regards
> Richard Zhu
> >
> > Shawn

RE: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Hongxing Zhu]

> -----Original Message-----
> From: Shawn Guo <shawnguo2@yeah.net>
> Sent: 2024年9月4日 17:39
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> Subject: Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP
> 
> On Sat, Aug 31, 2024 at 09:02:38PM +0800, Shawn Guo wrote:
> > On Tue, Aug 13, 2024 at 03:42:19PM +0800, Richard Zhu wrote:
> > > v5 changes:
> > > - Correct subject prefix.
> > >
> > > v4 changes:
> > > - Add Frank's reviewed tag, and re-format the commit message.
> > >
> > > v3 changes:
> > > - Refine the commit descriptions.
> > >
> > > v2 changes:
> > > Thanks for Conor's comments.
> > > - Place the new added properties at the end.
> > >
> > > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> > >
> > > [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > > [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> > > [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP
> > > [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM
> >
> > Applied 3 DTS patches, thanks!
> 
> I have to take them out from my branch for now.  Ping me when bindings
> change gets applied.
> 
Hi Shawn:
The dts bindings change had been merged on Sep 06.
Can you help to merge the others?
I don't know why my ping email sent on Sep 09 is missing.
Re-send email again here.
Thanks in advanced.

Best Regards
Richard Zhu

> Shawn

Re: [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP

[Shawn Guo]

On Wed, Sep 25, 2024 at 04:03:03AM +0000, Hongxing Zhu wrote:
> Hi Shawn:
> The dts bindings change had been merged on Sep 06.
> Can you help to merge the others?

Applied, thanks!

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Niklas Cassel]

On Tue, Aug 13, 2024 at 03:42:20PM +0800, Richard Zhu wrote:
> Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> 
> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> driver. This method is not good.
> 
> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
> preparation to do that for i.MX8M PCIe EP.
> 
> These changes wouldn't break driver function. When "dbi2" and "atu"
> properties are present, i.MX PCIe driver would fetch the according base
> addresses from DT directly. If only two reg properties are provided, i.MX
> PCIe driver would fall back to the old method.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> index a06f75df8458..84ca12e8b25b 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> @@ -65,12 +65,14 @@ allOf:
>      then:
>        properties:
>          reg:
> -          minItems: 2
> -          maxItems: 2
> +          minItems: 4
> +          maxItems: 4

Now it seems like this patch has already been picked up,
but how is this not breaking DT backwards compatibility?

You are here increasing minItems, which means that an older DT
should now fail to validate using the new schema?

I thought that it was only acceptable to add new optional properties
after the DT binding has been accepted.

What am I missing?


If the specific compatible isn't used by any DTS in a released kernel,
then I think that the commit log should have clearly stated so,
and explained that that is the reason why it is okay to break DT backwards
compatibility.


Kind regards,
Niklas

>          reg-names:
>            items:
>              - const: dbi
>              - const: addr_space
> +            - const: dbi2
> +            - const: atu
>  
>    - if:
>        properties:
> @@ -129,8 +131,11 @@ examples:
>  
>      pcie_ep: pcie-ep@33800000 {
>        compatible = "fsl,imx8mp-pcie-ep";
> -      reg = <0x33800000 0x000400000>, <0x18000000 0x08000000>;
> -      reg-names = "dbi", "addr_space";
> +      reg = <0x33800000 0x100000>,
> +            <0x18000000 0x8000000>,
> +            <0x33900000 0x100000>,
> +            <0x33b00000 0x100000>;
> +      reg-names = "dbi", "addr_space", "dbi2", "atu";
>        clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
>                 <&clk IMX8MP_CLK_HSIO_AXI>,
>                 <&clk IMX8MP_CLK_PCIE_ROOT>;
> -- 
> 2.37.1
> 

RE: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Hongxing Zhu]

> -----Original Message-----
> From: Niklas Cassel <cassel@kernel.org>
> Sent: 2024年10月9日 23:00
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> "atu" for i.MX8M PCIe Endpoint
> 
> On Tue, Aug 13, 2024 at 03:42:20PM +0800, Richard Zhu wrote:
> > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> >
> > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> > driver. This method is not good.
> >
> > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> > Frank suggests to fetch the dbi2 and atu from DT directly. This commit
> > is preparation to do that for i.MX8M PCIe EP.
> >
> > These changes wouldn't break driver function. When "dbi2" and "atu"
> > properties are present, i.MX PCIe driver would fetch the according
> > base addresses from DT directly. If only two reg properties are
> > provided, i.MX PCIe driver would fall back to the old method.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13
> > +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > index a06f75df8458..84ca12e8b25b 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > @@ -65,12 +65,14 @@ allOf:
> >      then:
> >        properties:
> >          reg:
> > -          minItems: 2
> > -          maxItems: 2
> > +          minItems: 4
> > +          maxItems: 4
> 
> Now it seems like this patch has already been picked up, but how is this not
> breaking DT backwards compatibility?
> 
> You are here increasing minItems, which means that an older DT should now fail
> to validate using the new schema?
> 
> I thought that it was only acceptable to add new optional properties after the
> DT binding has been accepted.
> 
> What am I missing?
> 
> 
> If the specific compatible isn't used by any DTS in a released kernel, then I think
> that the commit log should have clearly stated so, and explained that that is the
> reason why it is okay to break DT backwards compatibility.
> 
Hi Niklas:
Thanks for your comments and concerns.
Up to now, the pcie_ep of i.MX8MP is only present in i.mx8mp.dtsi file.
And it isn't used by any DTS in the release kernels.
So, this series wouldn't break DT backwards compatibility.

Best Regards
Richard Zhu
> 
> Kind regards,
> Niklas
> 
> >          reg-names:
> >            items:
> >              - const: dbi
> >              - const: addr_space
> > +            - const: dbi2
> > +            - const: atu
> >
> >    - if:
> >        properties:
> > @@ -129,8 +131,11 @@ examples:
> >
> >      pcie_ep: pcie-ep@33800000 {
> >        compatible = "fsl,imx8mp-pcie-ep";
> > -      reg = <0x33800000 0x000400000>, <0x18000000 0x08000000>;
> > -      reg-names = "dbi", "addr_space";
> > +      reg = <0x33800000 0x100000>,
> > +            <0x18000000 0x8000000>,
> > +            <0x33900000 0x100000>,
> > +            <0x33b00000 0x100000>;
> > +      reg-names = "dbi", "addr_space", "dbi2", "atu";
> >        clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
> >                 <&clk IMX8MP_CLK_HSIO_AXI>,
> >                 <&clk IMX8MP_CLK_PCIE_ROOT>;
> > --
> > 2.37.1
> >

Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint

[Niklas Cassel]

On Thu, Oct 10, 2024 at 02:17:25AM +0000, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Niklas Cassel <cassel@kernel.org>
> > Sent: 2024年10月9日 23:00
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> > shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org;
> > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev
> > Subject: Re: [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and
> > "atu" for i.MX8M PCIe Endpoint
> > 
> > On Tue, Aug 13, 2024 at 03:42:20PM +0800, Richard Zhu wrote:
> > > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
> > >
> > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
> > > driver. This method is not good.
> > >
> > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
> > > Frank suggests to fetch the dbi2 and atu from DT directly. This commit
> > > is preparation to do that for i.MX8M PCIe EP.
> > >
> > > These changes wouldn't break driver function. When "dbi2" and "atu"
> > > properties are present, i.MX PCIe driver would fetch the according
> > > base addresses from DT directly. If only two reg properties are
> > > provided, i.MX PCIe driver would fall back to the old method.
> > >
> > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml  | 13
> > > +++++++++----
> > >  1 file changed, 9 insertions(+), 4 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > > index a06f75df8458..84ca12e8b25b 100644
> > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > > @@ -65,12 +65,14 @@ allOf:
> > >      then:
> > >        properties:
> > >          reg:
> > > -          minItems: 2
> > > -          maxItems: 2
> > > +          minItems: 4
> > > +          maxItems: 4
> > 
> > Now it seems like this patch has already been picked up, but how is this not
> > breaking DT backwards compatibility?
> > 
> > You are here increasing minItems, which means that an older DT should now fail
> > to validate using the new schema?
> > 
> > I thought that it was only acceptable to add new optional properties after the
> > DT binding has been accepted.
> > 
> > What am I missing?
> > 
> > 
> > If the specific compatible isn't used by any DTS in a released kernel, then I think
> > that the commit log should have clearly stated so, and explained that that is the
> > reason why it is okay to break DT backwards compatibility.
> > 
> Hi Niklas:
> Thanks for your comments and concerns.
> Up to now, the pcie_ep of i.MX8MP is only present in i.mx8mp.dtsi file.
> And it isn't used by any DTS in the release kernels.
> So, this series wouldn't break DT backwards compatibility.

Ok, this information should have been in the commit message IMO.
(Too late now, but for the next patch affecting i.mx8mp.dtsi)

In the normal case, someone reviewing a DT binding patch will of course
assume there thre is actually a DTS using the binding, thus in the
(non-normal) case where there is no DTS using the binding, I think that
you should explicitly mention that in the commit message.


Kind regards,
Niklas