[PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
indicate the number of clocks, but it is not part of the ABI, so
it should be moved to clk driver.

---
Change for v2:
- Use pre-processor define to simplify code.
- link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/

Pengfei Li (2):
  clk: imx93: Move IMX93_CLK_END macro to clk driver
  dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition

 drivers/clk/imx/clk-imx93.c             | 2 ++
 include/dt-bindings/clock/imx93-clock.h | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

IMX93_CLK_END was previously defined in imx93-clock.h to indicate
the number of clocks, but it is not part of the ABI, so it should
be moved to clk driver.

Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
---

Notes:
    Change for v2:
    - Use pre-processor define to simplify code.

 drivers/clk/imx/clk-imx93.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
index c6a9bc8ecc1f..c8b65146e76e 100644
--- a/drivers/clk/imx/clk-imx93.c
+++ b/drivers/clk/imx/clk-imx93.c
@@ -15,6 +15,8 @@
 
 #include "clk.h"
 
+#define IMX93_CLK_END 202
+
 enum clk_sel {
 	LOW_SPEED_IO_SEL,
 	NON_IO_SEL,
-- 
2.34.1

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Krzysztof Kozlowski]

On 27/06/2024 10:24, Pengfei Li wrote:
> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> the number of clocks, but it is not part of the ABI, so it should
> be moved to clk driver.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> ---
> 
> Notes:
>     Change for v2:
>     - Use pre-processor define to simplify code.
> 
>  drivers/clk/imx/clk-imx93.c | 2 ++
>  1 file changed, 2 insertions(+)

Are you sure this builds fine? If you need to define it here, it means
some part of that unit file already uses the define. If so, you include
the header. If you include the header, you should see fat warning.

Really, people, just build your patches...

Best regards,
Krzysztof

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Fri, Jun 28, 2024 at 09:38:54AM +0200, Krzysztof Kozlowski wrote:
> On 27/06/2024 10:24, Pengfei Li wrote:
> > IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> > the number of clocks, but it is not part of the ABI, so it should
> > be moved to clk driver.
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> > ---
> > 
> > Notes:
> >     Change for v2:
> >     - Use pre-processor define to simplify code.
> > 
> >  drivers/clk/imx/clk-imx93.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Are you sure this builds fine? If you need to define it here, it means
> some part of that unit file already uses the define. If so, you include
> the header. If you include the header, you should see fat warning.
> 
> Really, people, just build your patches...
> 
> Best regards,
> Krzysztof
> 
> 

Hi Krzysztof,

Yes, you're right, this macro definition has indeed been used. But
this clk-imx93.c driver file is the only place where this macro is
used. So maybe it would be more appropriate to define this macro in
C rather than in the header file. Meanwhile, I also built my patch,
but no warnings were found.

BR,
Pengfei Li

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Sat, Jun 29, 2024 at 10:49:49AM +0800, Pengfei Li wrote:
> On Fri, Jun 28, 2024 at 09:38:54AM +0200, Krzysztof Kozlowski wrote:
> > On 27/06/2024 10:24, Pengfei Li wrote:
> > > IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> > > the number of clocks, but it is not part of the ABI, so it should
> > > be moved to clk driver.
> > > 
> > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> > > ---
> > > 
> > > Notes:
> > >     Change for v2:
> > >     - Use pre-processor define to simplify code.
> > > 
> > >  drivers/clk/imx/clk-imx93.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > Are you sure this builds fine? If you need to define it here, it means
> > some part of that unit file already uses the define. If so, you include
> > the header. If you include the header, you should see fat warning.
> > 
> > Really, people, just build your patches...
> > 
> > Best regards,
> > Krzysztof
> > 
> > 
> 
> Hi Krzysztof,
> 
> Yes, you're right, this macro definition has indeed been used. But
> this clk-imx93.c driver file is the only place where this macro is
> used. So maybe it would be more appropriate to define this macro in
> C rather than in the header file. Meanwhile, I also built my patch,
> but no warnings were found.
> 
> BR,
> Pengfei Li
> 

Hi Krzysztof,

I've built my patches, but no warnings were found. This C file is the only place where this macro definition is used, so why would I see fat warning?

BR,
Pengfei

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Krzysztof Kozlowski]

On 19/07/2024 08:08, Pengfei Li wrote:
> On Sat, Jun 29, 2024 at 10:49:49AM +0800, Pengfei Li wrote:
>> On Fri, Jun 28, 2024 at 09:38:54AM +0200, Krzysztof Kozlowski wrote:
>>> On 27/06/2024 10:24, Pengfei Li wrote:
>>>> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
>>>> the number of clocks, but it is not part of the ABI, so it should
>>>> be moved to clk driver.
>>>>
>>>> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
>>>> ---
>>>>
>>>> Notes:
>>>>     Change for v2:
>>>>     - Use pre-processor define to simplify code.
>>>>
>>>>  drivers/clk/imx/clk-imx93.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>
>>> Are you sure this builds fine? If you need to define it here, it means
>>> some part of that unit file already uses the define. If so, you include
>>> the header. If you include the header, you should see fat warning.
>>>
>>> Really, people, just build your patches...
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>>
>>
>> Hi Krzysztof,
>>
>> Yes, you're right, this macro definition has indeed been used. But
>> this clk-imx93.c driver file is the only place where this macro is
>> used. So maybe it would be more appropriate to define this macro in
>> C rather than in the header file. Meanwhile, I also built my patch,
>> but no warnings were found.
>>
>> BR,
>> Pengfei Li
>>
> 
> Hi Krzysztof,
> 
> I've built my patches, but no warnings were found. This C file is the only place where this macro definition is used, so why would I see fat warning?

I could be wrong, I really thought there should be a warning of
duplicated define. But if there is none, sure, sounds good.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Sat, Jul 20, 2024 at 08:28:14PM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2024 08:08, Pengfei Li wrote:
> > On Sat, Jun 29, 2024 at 10:49:49AM +0800, Pengfei Li wrote:
> >> On Fri, Jun 28, 2024 at 09:38:54AM +0200, Krzysztof Kozlowski wrote:
> >>> On 27/06/2024 10:24, Pengfei Li wrote:
> >>>> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> >>>> the number of clocks, but it is not part of the ABI, so it should
> >>>> be moved to clk driver.
> >>>>
> >>>> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> >>>> ---
> >>>>
> >>>> Notes:
> >>>>     Change for v2:
> >>>>     - Use pre-processor define to simplify code.
> >>>>
> >>>>  drivers/clk/imx/clk-imx93.c | 2 ++
> >>>>  1 file changed, 2 insertions(+)
> >>>
> >>> Are you sure this builds fine? If you need to define it here, it means
> >>> some part of that unit file already uses the define. If so, you include
> >>> the header. If you include the header, you should see fat warning.
> >>>
> >>> Really, people, just build your patches...
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>>
> >>>
> >>
> >> Hi Krzysztof,
> >>
> >> Yes, you're right, this macro definition has indeed been used. But
> >> this clk-imx93.c driver file is the only place where this macro is
> >> used. So maybe it would be more appropriate to define this macro in
> >> C rather than in the header file. Meanwhile, I also built my patch,
> >> but no warnings were found.
> >>
> >> BR,
> >> Pengfei Li
> >>
> > 
> > Hi Krzysztof,
> > 
> > I've built my patches, but no warnings were found. This C file is the only place where this macro definition is used, so why would I see fat warning?
> 
> I could be wrong, I really thought there should be a warning of
> duplicated define. But if there is none, sure, sounds good.
> 
> Best regards,
> Krzysztof
> 
> 

Hi Krzysztof,

If this patchset is ok, could you help merge it? Otherwise I won't be able to send subsequent patches.

BR,
Pengfei

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Krzysztof Kozlowski]

On 06/08/2024 10:36, Pengfei Li wrote:
> Hi Krzysztof,
> 
> If this patchset is ok, could you help merge it? Otherwise I won't be able to send subsequent patches.

Sure, let me apply it to my clk tree. Oh wait...

Best regards,
Krzysztof

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Tue, Aug 06, 2024 at 11:39:18AM +0200, Krzysztof Kozlowski wrote:
> On 06/08/2024 10:36, Pengfei Li wrote:
> > Hi Krzysztof,
> > 
> > If this patchset is ok, could you help merge it? Otherwise I won't be able to send subsequent patches.
> 
> Sure, let me apply it to my clk tree. Oh wait...
> 
> Best regards,
> Krzysztof
> 
> 
Hi Krzysztof,

These patches are still not merged into linux-next, can you help with that? Then I'll be able to send the subsequent patches!

BR,
Pengfei Li

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Krzysztof Kozlowski]

On 25/09/2024 00:54, Pengfei Li wrote:
> On Tue, Aug 06, 2024 at 11:39:18AM +0200, Krzysztof Kozlowski wrote:
>> On 06/08/2024 10:36, Pengfei Li wrote:
>>> Hi Krzysztof,
>>>
>>> If this patchset is ok, could you help merge it? Otherwise I won't be able to send subsequent patches.
>>
>> Sure, let me apply it to my clk tree. Oh wait...
>>
>> Best regards,
>> Krzysztof
>>
>>
> Hi Krzysztof,
> 
> These patches are still not merged into linux-next, can you help with that? Then I'll be able to send the subsequent patches!

What do you need from me?

Anyway, why are you pinging during merge window?

Best regards,
Krzysztof

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Abel Vesa]

On 24-06-27 16:24:25, Pengfei Li wrote:
> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> the number of clocks, but it is not part of the ABI, so it should
> be moved to clk driver.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> ---
> 
> Notes:
>     Change for v2:
>     - Use pre-processor define to simplify code.
> 
>  drivers/clk/imx/clk-imx93.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index c6a9bc8ecc1f..c8b65146e76e 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -15,6 +15,8 @@
>  
>  #include "clk.h"
>  
> +#define IMX93_CLK_END 202
> +

TBH, I don't like this. And I still don't understand the reason.

Where are the clocks you want to add ?

And why wouldn't it be OK to just keep this in the bindings header even
if you need to add more clocks ?

For the moment, I don't see the value of this change.

Sorry, but NACK.

>  enum clk_sel {
>  	LOW_SPEED_IO_SEL,
>  	NON_IO_SEL,
> -- 
> 2.34.1
> 

Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Wed, Oct 09, 2024 at 02:51:41PM +0300, Abel Vesa wrote:
> On 24-06-27 16:24:25, Pengfei Li wrote:
> > IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> > the number of clocks, but it is not part of the ABI, so it should
> > be moved to clk driver.
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> > ---
> > 
> > Notes:
> >     Change for v2:
> >     - Use pre-processor define to simplify code.
> > 
> >  drivers/clk/imx/clk-imx93.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> > index c6a9bc8ecc1f..c8b65146e76e 100644
> > --- a/drivers/clk/imx/clk-imx93.c
> > +++ b/drivers/clk/imx/clk-imx93.c
> > @@ -15,6 +15,8 @@
> >  
> >  #include "clk.h"
> >  
> > +#define IMX93_CLK_END 202
> > +
> 
> TBH, I don't like this. And I still don't understand the reason.
> 
> Where are the clocks you want to add ?

Hi Abel,

I re-sent a new version of the patch set which includes changes to add the new clocks:
https://lore.kernel.org/all/20241011045736.308338-1-pengfei.li_1@nxp.com/

> 
> And why wouldn't it be OK to just keep this in the bindings header even
> if you need to add more clocks ?

Krzysztof has help explained this:
https://lore.kernel.org/all/a07828a4-8040-42cb-8c62-8939cac4d9de@kernel.org/.

> 
> For the moment, I don't see the value of this change.
> 
> Sorry, but NACK.
> 
> >  enum clk_sel {
> >  	LOW_SPEED_IO_SEL,
> >  	NON_IO_SEL,
> > -- 
> > 2.34.1
> > 
> 

[PATCH v2 2/2] dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition

[Pengfei Li]

IMX93_CLK_END should be dropped as it is not part of the ABI.

Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
---
 include/dt-bindings/clock/imx93-clock.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
index 787c9e74dc96..a1d0b326bb6b 100644
--- a/include/dt-bindings/clock/imx93-clock.h
+++ b/include/dt-bindings/clock/imx93-clock.h
@@ -204,6 +204,5 @@
 #define IMX93_CLK_A55_SEL		199
 #define IMX93_CLK_A55_CORE		200
 #define IMX93_CLK_PDM_IPG		201
-#define IMX93_CLK_END			202
 
 #endif
-- 
2.34.1

Re: [PATCH v2 2/2] dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Thu, Jun 27, 2024 at 04:24:26PM +0800, Pengfei Li wrote:
> IMX93_CLK_END should be dropped as it is not part of the ABI.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Abel Vesa]

On 24-06-27 16:24:24, Pengfei Li wrote:
> 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
> indicate the number of clocks, but it is not part of the ABI, so
> it should be moved to clk driver.
> 

Right, why?

All other providers have been using the _CLK_END from the bindings
header. What is so special about this ? AFAICT, nothing.

> ---
> Change for v2:
> - Use pre-processor define to simplify code.
> - link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/
> 
> Pengfei Li (2):
>   clk: imx93: Move IMX93_CLK_END macro to clk driver
>   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition
> 
>  drivers/clk/imx/clk-imx93.c             | 2 ++
>  include/dt-bindings/clock/imx93-clock.h | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> -- 
> 2.34.1
> 

Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Krzysztof Kozlowski]

On 29/08/2024 09:07, Abel Vesa wrote:
> On 24-06-27 16:24:24, Pengfei Li wrote:
>> 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
>> indicate the number of clocks, but it is not part of the ABI, so
>> it should be moved to clk driver.
>>
> 
> Right, why?
> 
> All other providers have been using the _CLK_END from the bindings
> header. What is so special about this ? AFAICT, nothing.

Because usually we do no consider number of clocks as an ABI. For
starters it does no really appear in DTS. But what's more important -
new clocks are described later, which contradicts this define. So either
this is an ABI or it is not. If it is, you are not allowed to add any
new clock. If it is not, then this should have never been part of bindings.

We did the same (removal of END/NUM macros) for several other platforms
already.

Best regards,
Krzysztof

Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Thu, Aug 29, 2024 at 10:07:05AM +0300, Abel Vesa wrote:
> On 24-06-27 16:24:24, Pengfei Li wrote:
> > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
> > indicate the number of clocks, but it is not part of the ABI, so
> > it should be moved to clk driver.
> > 
> 
> Right, why?
> 
> All other providers have been using the _CLK_END from the bindings
> header. What is so special about this ? AFAICT, nothing.
> 
> > ---
> > Change for v2:
> > - Use pre-processor define to simplify code.
> > - link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/
> > 
> > Pengfei Li (2):
> >   clk: imx93: Move IMX93_CLK_END macro to clk driver
> >   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition
> > 
> >  drivers/clk/imx/clk-imx93.c             | 2 ++
> >  include/dt-bindings/clock/imx93-clock.h | 1 -
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > -- 
> > 2.34.1
> > 
> 

Hi Abel,

This is a modification based on previous comments: https://lore.kernel.org/all/20240604150447.GA604729-robh@kernel.org/
Actually, whether this _CLK_END macro change is added or not, both is ok for me.
I just want to add some new clocks to bindings header.

BR,
Pengfei Li

Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Pengfei Li]

On Fri, Sep 20, 2024 at 05:04:19PM -0700, Pengfei Li wrote:
> On Thu, Aug 29, 2024 at 10:07:05AM +0300, Abel Vesa wrote:
> > On 24-06-27 16:24:24, Pengfei Li wrote:
> > > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to
> > > indicate the number of clocks, but it is not part of the ABI, so
> > > it should be moved to clk driver.
> > > 
> > 
> > Right, why?
> > 
> > All other providers have been using the _CLK_END from the bindings
> > header. What is so special about this ? AFAICT, nothing.
> > 
> > > ---
> > > Change for v2:
> > > - Use pre-processor define to simplify code.
> > > - link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/
> > > 
> > > Pengfei Li (2):
> > >   clk: imx93: Move IMX93_CLK_END macro to clk driver
> > >   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition
> > > 
> > >  drivers/clk/imx/clk-imx93.c             | 2 ++
> > >  include/dt-bindings/clock/imx93-clock.h | 1 -
> > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > 
> 
> Hi Abel,
> 
> This is a modification based on previous comments: https://lore.kernel.org/all/20240604150447.GA604729-robh@kernel.org/
> Actually, whether this _CLK_END macro change is added or not, both is ok for me.
> I just want to add some new clocks to bindings header.
> 
> BR,
> Pengfei Li
> 

Hi Abel, you are the maintainer of clk-imx93.c, so if this patchset is ok,
could you help apply it. and then I will send subsequent patchset to add some new clocks.

BR,
Pengfei Li

RE: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Peng Fan]

> Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro
> to clk driver
> 
> On Fri, Sep 20, 2024 at 05:04:19PM -0700, Pengfei Li wrote:
> > On Thu, Aug 29, 2024 at 10:07:05AM +0300, Abel Vesa wrote:
> > > On 24-06-27 16:24:24, Pengfei Li wrote:
> > > > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h
> to
> > > > indicate the number of clocks, but it is not part of the ABI, so
> > > > it should be moved to clk driver.
> > > >
> > >
> > > Right, why?
> > >
> > > All other providers have been using the _CLK_END from the
> bindings
> > > header. What is so special about this ? AFAICT, nothing.
> > >
> > > > ---
> > > > Change for v2:
> > > > - Use pre-processor define to simplify code.
> > > > - link to v1:
> > > > https://lore.kernel.org/all/20240625175147.94985-1-
> pengfei.li_1@nx
> > > > p.com/
> > > >
> > > > Pengfei Li (2):
> > > >   clk: imx93: Move IMX93_CLK_END macro to clk driver
> > > >   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro
> definition
> > > >
> > > >  drivers/clk/imx/clk-imx93.c             | 2 ++
> > > >  include/dt-bindings/clock/imx93-clock.h | 1 -
> > > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > >
> >
> > Hi Abel,
> >
> > This is a modification based on previous comments:
> > https://lore.kernel.org/all/20240604150447.GA604729-
> robh@kernel.org/
> > Actually, whether this _CLK_END macro change is added or not, both
> is ok for me.
> > I just want to add some new clocks to bindings header.
> >
> > BR,
> > Pengfei Li
> >
> 
> Hi Abel, you are the maintainer of clk-imx93.c, so if this patchset is ok,
> could you help apply it. and then I will send subsequent patchset to
> add some new clocks.

There is no good way here. I think you v1 patch is fine:
https://lore.kernel.org/all/20240625175147.94985-2-pengfei.li_1@nxp.com/

Moving END to driver indeed is a bit weird.

Abel,

When you have time, please give a look at upper v1.
I not find a better way to drop _END from bindings.

Thanks,
Peng.

> 
> BR,
> Pengfei Li