Re: [PATCH v1 00/13]: chemical: bme680: 2nd set of clean and add

Andy Shevchenko
2024-10-11T10:42:09Z

On Thu, Oct 10, 2024 at 11:00:17PM +0200, vamoirid wrote:
> This patch series is continuing the work that started on [1] by
> improving some small issues of the driver in the commits 1,2,3.
>
> Commits 4,5 are refactorizing existing code.
>
> Commits 6,7,8 are adding DT, regulator and PM support.
>
> Commit 9 is refactorizing one macro to attribute.
>
> Commit 10,11,12 are refactorizing the read/compensate functions
> to become generic and add triggered buffer support.
>
> Finally, commit 13 adds support for an *output* channel of type
> IIO_CURRENT in order to preheat the plate that is used to measure the
> quality of the air.
>
> This and the previous series [1] started with the idea to add support
> for the new bme688 device but due to the structure of the driver I
> decided that it is better to restructure and improve some things before
> adding extra funcitonalities.

Besides the small comments here and there I think you need to rearrange the
patches layout in the series.

In general it should go in these blocks:
1) bug fixes (if any);
2) cleanups (note, whitespace-cleanup-like are the last);
3) new feature.

Note that PM runtime belongs to the last group quite close to the patches
where you more or less start using it more.

--
With Best Regards,
Andy Shevchenko