From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B38146590 for ; Sat, 12 Oct 2024 20:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728766076; cv=none; b=iURfjD8XnvhdgWBGuVN4wUEYR09NFNp5x8y7cfkf5Teyu56fhK/KWWsCMHvO+xhUw9MSCzG/pn9UVEvuqXFrOBjRTRDS3D3/PfHzaF3+O+n1GygckFNKq8ZyCy1abA0RrbT2jZxK5noWulmLFAA6JzpQDMoEG482QJxpaw4cu1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728766076; c=relaxed/simple; bh=AisCTrykfdwchnw9oOUCd822oZfY0675duc3AmxHqY0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pvAM/LJoddZbrt2uwi3aramJxt6ayeO/MoL3UZIGP59RF86ElG8aNYmGjFZLjKSN3MLQTZqheTuNGrtoyLqFvgX8x3yKCHyHXQjNRF3nniqJhV7EcTDsLC1K90RYoL52A8xkaFDDOGHd9hvgv+FGdwX0zMqJE7+P70IXZcpa7hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-26-56.elisa-laajakaista.fi [88.113.26.56]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 3d7686c2-88db-11ef-8861-005056bdd08f; Sat, 12 Oct 2024 23:47:48 +0300 (EEST) From: Andy Shevchenko Date: Sat, 12 Oct 2024 23:47:48 +0300 To: Vasileios Aoiridis Cc: Andy Shevchenko , jic23@kernel.org, lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, anshulusr@gmail.com, gustavograzs@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 13/13] iio: chemical: bme680: Add support for preheat current Message-ID: References: <20241010210030.33309-1-vassilisamir@gmail.com> <20241010210030.33309-14-vassilisamir@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Fri, Oct 11, 2024 at 09:08:51PM +0200, Vasileios Aoiridis kirjoitti: > On Fri, Oct 11, 2024 at 01:39:29PM +0300, Andy Shevchenko wrote: > > On Thu, Oct 10, 2024 at 11:00:30PM +0200, vamoirid wrote: ... > > > + data->preheat_curr = 0; /* milliamps */ > > > > Instead of the comment, make it better to any appearance of the variable in the > > code by adding unit suffix. > > > > data->preheat_curr_mA = 0; > > > > (yes, capital 'A'). > > I used the comment here because it is exactly like this above and I > though it is more consistent if I do the same. But I guess repeating a > not so good design choice for consistency might not be the best > decision. Right. I would rather see an additional patch that adds unit suffixes here and there... -- With Best Regards, Andy Shevchenko