[PATCH v3 3/7] dt-bindings: firmware: arm,scmi: Introduce more transport properties

[PATCH v3 3/7] dt-bindings: firmware: arm,scmi: Introduce more transport properties

[Cristian Marussi]

Depending on specific hardware and firmware design choices, it may be
possible for different platforms to end up having different requirements
regarding the same transport characteristics.

Introduce max-msg-size and max-msg properties to describe such platform
specific transport constraints, since they cannot be discovered otherwise.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
Cc: devicetree@vger.kernel.org
---
v1 --> v2
- added vendor prefix
- dropped warnings about resonable minimum max-msg-size
- clarified the intended usage of max-msg
- fixed Cc to include all maintainers and using correct e-mails
---
 .../devicetree/bindings/firmware/arm,scmi.yaml    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
index 54d7d11bfed4..9d6e1147f9e9 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -131,6 +131,21 @@ properties:
       be a non-zero value if set.
     minimum: 1
 
+  arm,max-msg-size:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      An optional value, expressed in bytes, representing the maximum size
+      allowed for the payload of messages transmitted on this transport.
+
+  arm,max-msg:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      An optional value representing the maximum number of concurrent in-flight
+      messages allowed by this transport; this number represents the maximum
+      number of concurrently outstanding messages that the server can handle on
+      this platform. If set, the value should be non-zero.
+    minimum: 1
+
   arm,smc-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
-- 
2.47.0

[PATCH v3 6/7] dt-bindings: firmware: arm,scmi: Add missing vendor string

[Cristian Marussi]

Recently introduced max-rx-timeout-ms optionao property is missing a
vendor prefix.

Add the vendor prefix from the original committer.

Fixes: 3a5e6ab06eab ("dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
Note that this fixes a commit that has been merged in v6.12-rc1...so it
should not present any backward compatibility issue.
---
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
index 9d6e1147f9e9..e331da4d606b 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -124,7 +124,7 @@ properties:
       atomic mode of operation, even if requested.
     default: 0
 
-  max-rx-timeout-ms:
+  nxp,max-rx-timeout-ms:
     description:
       An optional time value, expressed in milliseconds, representing the
       transport maximum timeout value for the receive channel. The value should
-- 
2.47.0

Re: [PATCH v3 6/7] dt-bindings: firmware: arm,scmi: Add missing vendor string

[Sudeep Holla]

On Mon, Oct 28, 2024 at 12:01:50PM +0000, Cristian Marussi wrote:
> Recently introduced max-rx-timeout-ms optionao property is missing a
> vendor prefix.
>
> Add the vendor prefix from the original committer.
>

It should be "arm," not "nxp," just because NXP happens to introduce that.
It just highlight that the property is X vendor specific and here it is
associated with SCMI and specifically Arm SCMI, so "arm,". If for some
reason nxp or any other vendor overrides this definition and need to add
additional property then they can add their own vendor name into that
property.

If there are no objections, I can fix it up when applying.

> Fixes: 3a5e6ab06eab ("dt-bindings: firmware: arm,scmi: Introduce property max-rx-timeout-ms")
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> Note that this fixes a commit that has been merged in v6.12-rc1...so it
> should not present any backward compatibility issue.
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 9d6e1147f9e9..e331da4d606b 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -124,7 +124,7 @@ properties:
>        atomic mode of operation, even if requested.
>      default: 0
>  
> -  max-rx-timeout-ms:
> +  nxp,max-rx-timeout-ms:
>      description:
>        An optional time value, expressed in milliseconds, representing the
>        transport maximum timeout value for the receive channel. The value should
> -- 
> 2.47.0
> 

--
Regards,
Sudeep

Re: [PATCH v3 6/7] dt-bindings: firmware: arm,scmi: Add missing vendor string

[Cristian Marussi]

On Mon, Oct 28, 2024 at 12:22:54PM +0000, Sudeep Holla wrote:
> On Mon, Oct 28, 2024 at 12:01:50PM +0000, Cristian Marussi wrote:
> > Recently introduced max-rx-timeout-ms optionao property is missing a
> > vendor prefix.
> >
> > Add the vendor prefix from the original committer.
> >
> 
> It should be "arm," not "nxp," just because NXP happens to introduce that.
> It just highlight that the property is X vendor specific and here it is
> associated with SCMI and specifically Arm SCMI, so "arm,". If for some
> reason nxp or any other vendor overrides this definition and need to add
> additional property then they can add their own vendor name into that
> property.
> 
> If there are no objections, I can fix it up when applying.

My bad. Sure go for it.

Thanks,
Cristian