From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C6613B2B8 for ; Sun, 27 Oct 2024 11:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730028751; cv=none; b=Ww6qA7ddveUWrbCnszuDNmjyaSAgBk20UMutRruMC11xIo6lAPIFn5YP54jb0ib9DO0ITnKDh+8rRahQSSRYXwFguTwPwxFv4pqVw6fNJrdz/eYA27o4a/mGiK66QHa13OYFjRSMYKiTVQmRBARGyWAlJFrUz/CvhoTgk0VcadY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730028751; c=relaxed/simple; bh=kTHkP+pw95v9Q9sC8dmhm0Y1Njg3SQZdvxggj1A8yUM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s9hho3aM544iobIqL6hyYJMuCzfW+KysCt8X+xIWmv8Rk8GWIwv1WUQQmoKKO7snrzMcGR6EjSywp0+cekia4GBUdDlKzertq7j4J8yCsczoPtK/++276pd/7b1SBHTdUos/2g2oW0AD5/yxnyfAOlrJgdqZ9A8JyoeJ1OqBmw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gm9iBTrl; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gm9iBTrl" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a99ebb390a5so825278966b.1 for ; Sun, 27 Oct 2024 04:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730028747; x=1730633547; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=kU0MCV0TeQuQC16GsgNJVVDz80GIbnmau4vhLNXnG6c=; b=gm9iBTrlAdFDgy6nGIsU9gmysckxtx356qDlT7/Kzgt2lKJzc1bhT8X0vvyxuBWed2 tVB2zce4+tAi3zdCsoZ50YVE6pRXNs3j5eDl4QtJneyHvU1CeC9k333Lcb793rbYK3T4 4NtigsNVAtzgNeRxhyzsybcnQRH/VZSwVwH1skjThuu/x8C2qbNZHnhETImDVk7fdoF9 StA593+iCtSXNtM6zpCA/OGDQ/4oTdrK6PzS3DDMYJwOGgzWIQ5iYwLr02XS330/J+J/ nc2F+WFb23uALjJkB4HBg/rxmNNRZV7W/qjusuQiFKLkXsoMLBT8iVirjCHfCIh+3CYa FSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730028747; x=1730633547; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kU0MCV0TeQuQC16GsgNJVVDz80GIbnmau4vhLNXnG6c=; b=q6onEjFtwRmaloTQya8FSFcCS6hmG7a3/rMLrRWStjKBNTCO7GnK00FOf9OJBCsgmk vPhUhZH0Kx02WoEjZ/BHxKCSniFbOqOyQ02KgHYk+y00RlpLYF4AQUbZBloz39YAhepj Do7MuWwo8GckomSH6drmIEygrEl4FYfQewMcd7EdZ8S2O+VO3fyxpgzwJHA4DVFyFlHq PIBKevDSl3rQ+X7pwJBH6M250OS1sVYheB87RqrdGguI0zX+YezA9HsR1B1Z0tAa0APi SmYXU4k0UqCuK1hfqC0VQLbhKgiWv0XXlnAX8/arlQTfOn2m10Z9HEFZWaGCNBWndg/1 tBbA== X-Forwarded-Encrypted: i=1; AJvYcCVCR0g0Y9yHAxo/r/XlVK4y616/5SdjvQgL210LoJxlUI4Z1gUjU4qKXjyx3qRdQZc/OYHfNbleMaoM@vger.kernel.org X-Gm-Message-State: AOJu0YxDgs4rox9ty6AD+yItTpEbZf2EwAMw/UdzmyZGj919TjY3rHcO HAQMsUu8TTJqTF88BXaJaXqCYysDp6Y9Iq92I1RBUKUaysWOpFaFJ+JfR9cBCoQ= X-Google-Smtp-Source: AGHT+IGFhxYKhcZGmct80kmOogS47m5N8se2XFqf8zdUkxnrd0dqlLKBimSbOYXFuOLdT6TQJTi2mw== X-Received: by 2002:a17:906:f592:b0:a9a:babb:b916 with SMTP id a640c23a62f3a-a9de3612eccmr487030466b.15.1730028747291; Sun, 27 Oct 2024 04:32:27 -0700 (PDT) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f0292c2sm269235466b.69.2024.10.27.04.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 04:32:26 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Sun, 27 Oct 2024 12:32:50 +0100 To: Stefan Wahren Cc: Linus Walleij , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v2 09/14] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: References: <199a4994312b120c73c95fa368954ad5a2a8aee6.1728300190.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Stefan, On 12:08 Fri 11 Oct , Stefan Wahren wrote: > Am 11.10.24 um 11:03 schrieb Linus Walleij: > > On Mon, Oct 7, 2024 at 2:39 PM Andrea della Porta wrote: > > > > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > > Add minimum support for the gpio only portion. The driver is in > > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > > support where the gpio part can be seen as an addition. > > > > > > Signed-off-by: Andrea della Porta > > This is a nice driver and I find no issues with it, what causes > > an issue is gpiochip_set_names() as pointed out by Bartosz. > > If you can live without the names you can remove that part for > > now and we can merge the driver, then you can add the names > > later when we sorted out how to share that function. > I raised the concerns about missing gpio line names in the first version > of patch, without knowing the real efforts. > > So I'm fine with Linus' suggestion, because I don't want to delay the > upstreaming effort unnecessarily. Perfect, thanks. Regards, Andrea > > Regards > > > > Yours, > > Linus Walleij >