From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CEA11D2704 for ; Mon, 28 Oct 2024 10:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730111800; cv=none; b=RLiASUzJt+uh3jXZaxAeMCb7CXNvW/3s80zF71+RZl5UH3iQcX7K+fS8d+gobDpYzfo2HaBoR8hOg4RpXt/n3h55KEzrDeB2Wezh+yVhBjgl0VDuRu5YsqvSzKUxASgQ7A4g2G/yROmQGuurul3vil05OQ57KDAp+TNuXT6EVV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730111800; c=relaxed/simple; bh=oEn8z9MqoHTTS3d/0dOtXTLMxxBwRriKpl2xUYLAhn8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QvFt0Rp6p8zqwPkxd5Z2X69kDlu1KeAdT2UBl99IMnuY0lcHt/K3F9bbHBIsPnaTSTNKXW5mmG2He5VUpwcgkpawjAeZKfAzyAI4BZQsoHD5jBAO5123oNjCC8hU+gVNYCGVmv3MQHZ+v1kH9rhkGr1XXhAKabIXVaIj/oBPY7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Az0ar+/R; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Az0ar+/R" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a99eb8b607aso519786866b.2 for ; Mon, 28 Oct 2024 03:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730111797; x=1730716597; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=YMofVo8hbKk0Swbq8g7Wqb/qoQ7xBjUn4m5ktsUGG78=; b=Az0ar+/RPKbMQqOe9q/yQsE/CYIfJJxn6q5tMKx9ryOBZso0yCtpx3JUCObpnviMfc UQwQXkO9slpKHs1s7GtvhwzQ4y5fMkxXCxY857a4Q0+jBi2Jf6/Mzozv+UbqRur7jOG0 4ibAYe2v8L0jfFTZ+tZOY7A2zrIwsi/zgxBSRDaZSjhuxt9Vcnn1RO0WIioPaNxpNQui imIHAEb23sY3tBaiaqjZMBzI1IkecMc9eBL7QaCEnVxGGo6VcUdeXc1SwqxRzvfv6jXw GzQks1DpQnVnm1R7SFBws2Np9AjS717w+UQM+Q10g9xGYNYM5F/KVx/Kx3B6UdkiOw9i C5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730111797; x=1730716597; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YMofVo8hbKk0Swbq8g7Wqb/qoQ7xBjUn4m5ktsUGG78=; b=QZms/YQF28gVSUoqmtYRWvwZ0vbj2QntjBx0pFjAr4Yxnt7cyDdLYt3T2q6DF5XNBE ahwrRkZ39VKV7ymrTkbdWYGaqchPw+rQkLF3ZTny2VFifw5yJ5EBLHIQw8Ix8gIgw9em /qLX/DoAhT5n85NiGfotMzYTOw4Xo2CmXCpxjhCKxkrTKYPQfFvXnQQvTIADR9cN4orW THDY95gTZSv5TTIZtEAOM7HaLcz6PO7nbdr0DO1WEgTjq5BJ17Q49GbYltOHT1pcpOUJ xWr1LDWvXfyDCZ9NoHte1wRM5W/V8X3HtIhUjYfFxDxtplRJOsjAtXBZRHUrfCztHO6v 6zsQ== X-Forwarded-Encrypted: i=1; AJvYcCWynkCeoB+EjZnRlvGTqGScCt3bGjWavT8JcJ6iIBjgEBvBTiZ3o+vVkWC/J/rpUv0YYyyU3jCZDhP/@vger.kernel.org X-Gm-Message-State: AOJu0YzJZTVAa6EnwtX2tcPbCXzD8hMq9lQHHxCOEox0wimu9Hhsn39D +/UQwK3CXA1jx5PKmLup6pl+krNO65ildE5akKJWzyFNykbYkJHwhfUhI6kKyVQ= X-Google-Smtp-Source: AGHT+IE71P+Tc8wEJl1++AmZI7Lie6dR5rgB/dlxrq9d7RRZ7akirpK4bMRLI/OEdqic/AucIdtIBA== X-Received: by 2002:a17:907:7da2:b0:a9a:6752:ba80 with SMTP id a640c23a62f3a-a9de5d6e1dcmr779581466b.5.1730111796750; Mon, 28 Oct 2024 03:36:36 -0700 (PDT) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b30c7af41sm362413266b.157.2024.10.28.03.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 03:36:36 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 28 Oct 2024 11:36:59 +0100 To: Krzysztof Kozlowski Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v2 14/14] arm64: defconfig: Enable RP1 misc/clock/gpio drivers Message-ID: References: <6964b1728d155b85c9c97fe26726e8ee2c04abf8.1728300190.git.andrea.porta@suse.com> <7y4rgefxfst5y7xgvtwhv6dulxjd7ieou5jlqi3waqwyw6vpuq@xken3govscld> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7y4rgefxfst5y7xgvtwhv6dulxjd7ieou5jlqi3waqwyw6vpuq@xken3govscld> Hi Krzysztof, On 08:32 Tue 08 Oct , Krzysztof Kozlowski wrote: > On Mon, Oct 07, 2024 at 02:39:57PM +0200, Andrea della Porta wrote: > > Select the RP1 drivers needed to operate the PCI endpoint containing > > several peripherals such as Ethernet and USB Controller. This chip is > > present on RaspberryPi 5. > > > > Signed-off-by: Andrea della Porta > > --- > > arch/arm64/configs/defconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 5fdbfea7a5b2..5fcd9ae0d373 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -609,6 +609,7 @@ CONFIG_PINCTRL_QCM2290=y > > CONFIG_PINCTRL_QCS404=y > > CONFIG_PINCTRL_QDF2XXX=y > > CONFIG_PINCTRL_QDU1000=y > > +CONFIG_PINCTRL_RP1=y > > Module, that's not a SoC component. This driver was born as a builtin only one, indeed it is bool and not tristate in Kconfig and is registered through builtin_platform_driver(). Hence I've set it =y in defconfig. A quick check transforming it to be dynamically loaded as a module confirm that something is not working, and I agree with you that, in theory, this should also be a loadable module. I need some investigation on that though... Many thanks, Andrea > > > CONFIG_PINCTRL_SA8775P=y > > CONFIG_PINCTRL_SC7180=y > > Best regards, > Krzysztof >