* [PATCH 2/6] arm64: dts: imx8qxp-mek: add esai, cs42888 and related node
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
@ 2024-09-30 21:25 ` Frank Li
2024-10-21 3:01 ` Shawn Guo
2024-09-30 21:26 ` [PATCH 3/6] arm64: dts: imx8qxp-mek: enable jpeg encode and deconde Frank Li
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Frank Li @ 2024-09-30 21:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Add audio codec cs42888 and related node.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: esai@59010000: Unevaluated properties are not allowed ('power-domains' was unexpected)
update binding patch already sent
https://lore.kernel.org/linux-devicetree/20240927205618.4093591-1-Frank.Li@nxp.com/#R
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 84 +++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index d8d9e2883caf7..9b9ad389a807a 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -50,6 +50,13 @@ usb3_data_ss: endpoint {
};
};
+ reg_audio: regulator-audio {
+ compatible = "regulator-fixed";
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-name = "cs42888_supply";
+ };
+
sound-bt-sco {
compatible = "simple-audio-card";
simple-audio-card,bitclock-inversion;
@@ -69,6 +76,28 @@ btcpu: simple-audio-card,cpu {
};
};
+ sound-cs42888 {
+ compatible = "fsl,imx-audio-cs42888";
+ audio-asrc = <&asrc0>;
+ audio-codec = <&cs42888>;
+ audio-cpu = <&esai0>;
+ audio-routing =
+ "Line Out Jack", "AOUT1L",
+ "Line Out Jack", "AOUT1R",
+ "Line Out Jack", "AOUT2L",
+ "Line Out Jack", "AOUT2R",
+ "Line Out Jack", "AOUT3L",
+ "Line Out Jack", "AOUT3R",
+ "Line Out Jack", "AOUT4L",
+ "Line Out Jack", "AOUT4R",
+ "AIN1L", "Line In Jack",
+ "AIN1R", "Line In Jack",
+ "AIN2L", "Line In Jack",
+ "AIN2R", "Line In Jack";
+ model = "imx-cs42888";
+ status = "okay";
+ };
+
sound-wm8960 {
compatible = "fsl,imx-audio-wm8960";
model = "wm8960-audio";
@@ -86,6 +115,15 @@ sound-wm8960 {
};
};
+&amix {
+ status = "okay";
+};
+
+&asrc0 {
+ fsl,asrc-rate = <48000>;
+ status = "okay";
+};
+
&dsp {
memory-region = <&dsp_reserved>;
status = "okay";
@@ -95,6 +133,19 @@ &dsp_reserved {
status = "okay";
};
+&esai0 {
+ assigned-clocks = <&acm IMX_ADMA_ACM_ESAI0_MCLK_SEL>,
+ <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
+ <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_SLV_BUS>,
+ <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_MST_BUS>,
+ <&esai0_lpcg 0>;
+ assigned-clock-parents = <&aud_pll_div0_lpcg 0>;
+ assigned-clock-rates = <0>, <786432000>, <49152000>, <12288000>, <49152000>;
+ pinctrl-0 = <&pinctrl_esai0>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&fec1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_fec1>;
@@ -264,6 +315,24 @@ pca6416: gpio@20 {
gpio-controller;
#gpio-cells = <2>;
};
+
+ cs42888: audio-codec@48 {
+ compatible = "cirrus,cs42888";
+ reg = <0x48>;
+ clocks = <&mclkout0_lpcg 0>;
+ clock-names = "mclk";
+ assigned-clocks = <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
+ <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_SLV_BUS>,
+ <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_MST_BUS>,
+ <&mclkout0_lpcg 0>;
+ assigned-clock-rates = <786432000>, <49152000>, <12288000>, <12288000>;
+ reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>;
+ VA-supply = <®_audio>;
+ VD-supply = <®_audio>;
+ VLC-supply = <®_audio>;
+ VLS-supply = <®_audio>;
+
+ };
};
&cm40_intmux {
@@ -458,6 +527,21 @@ IMX8QXP_ADC_IN0_LSIO_GPIO1_IO10 0xc600004c
>;
};
+ pinctrl_esai0: esai0grp {
+ fsl,pins = <
+ IMX8QXP_ESAI0_FSR_ADMA_ESAI0_FSR 0xc6000040
+ IMX8QXP_ESAI0_FST_ADMA_ESAI0_FST 0xc6000040
+ IMX8QXP_ESAI0_SCKR_ADMA_ESAI0_SCKR 0xc6000040
+ IMX8QXP_ESAI0_SCKT_ADMA_ESAI0_SCKT 0xc6000040
+ IMX8QXP_ESAI0_TX0_ADMA_ESAI0_TX0 0xc6000040
+ IMX8QXP_ESAI0_TX1_ADMA_ESAI0_TX1 0xc6000040
+ IMX8QXP_ESAI0_TX2_RX3_ADMA_ESAI0_TX2_RX3 0xc6000040
+ IMX8QXP_ESAI0_TX3_RX2_ADMA_ESAI0_TX3_RX2 0xc6000040
+ IMX8QXP_ESAI0_TX4_RX1_ADMA_ESAI0_TX4_RX1 0xc6000040
+ IMX8QXP_ESAI0_TX5_RX0_ADMA_ESAI0_TX5_RX0 0xc6000040
+ >;
+ };
+
pinctrl_fec1: fec1grp {
fsl,pins = <
IMX8QXP_ENET0_MDC_CONN_ENET0_MDC 0x06000020
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8qxp-mek: add esai, cs42888 and related node
2024-09-30 21:25 ` [PATCH 2/6] arm64: dts: imx8qxp-mek: add esai, cs42888 and related node Frank Li
@ 2024-10-21 3:01 ` Shawn Guo
0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2024-10-21 3:01 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, Sep 30, 2024 at 05:25:59PM -0400, Frank Li wrote:
> Add audio codec cs42888 and related node.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: esai@59010000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> update binding patch already sent
> https://lore.kernel.org/linux-devicetree/20240927205618.4093591-1-Frank.Li@nxp.com/#R
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 84 +++++++++++++++++++
> 1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index d8d9e2883caf7..9b9ad389a807a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -50,6 +50,13 @@ usb3_data_ss: endpoint {
> };
> };
>
> + reg_audio: regulator-audio {
> + compatible = "regulator-fixed";
> + regulator-max-microvolt = <3300000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-name = "cs42888_supply";
> + };
> +
> sound-bt-sco {
> compatible = "simple-audio-card";
> simple-audio-card,bitclock-inversion;
> @@ -69,6 +76,28 @@ btcpu: simple-audio-card,cpu {
> };
> };
>
> + sound-cs42888 {
> + compatible = "fsl,imx-audio-cs42888";
> + audio-asrc = <&asrc0>;
> + audio-codec = <&cs42888>;
> + audio-cpu = <&esai0>;
> + audio-routing =
> + "Line Out Jack", "AOUT1L",
> + "Line Out Jack", "AOUT1R",
> + "Line Out Jack", "AOUT2L",
> + "Line Out Jack", "AOUT2R",
> + "Line Out Jack", "AOUT3L",
> + "Line Out Jack", "AOUT3R",
> + "Line Out Jack", "AOUT4L",
> + "Line Out Jack", "AOUT4R",
> + "AIN1L", "Line In Jack",
> + "AIN1R", "Line In Jack",
> + "AIN2L", "Line In Jack",
> + "AIN2R", "Line In Jack";
> + model = "imx-cs42888";
> + status = "okay";
Unneeded "okay" status.
> + };
> +
> sound-wm8960 {
> compatible = "fsl,imx-audio-wm8960";
> model = "wm8960-audio";
> @@ -86,6 +115,15 @@ sound-wm8960 {
> };
> };
>
> +&amix {
> + status = "okay";
> +};
> +
> +&asrc0 {
> + fsl,asrc-rate = <48000>;
Double space before =
Shawn
> + status = "okay";
> +};
> +
> &dsp {
> memory-region = <&dsp_reserved>;
> status = "okay";
> @@ -95,6 +133,19 @@ &dsp_reserved {
> status = "okay";
> };
>
> +&esai0 {
> + assigned-clocks = <&acm IMX_ADMA_ACM_ESAI0_MCLK_SEL>,
> + <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
> + <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_SLV_BUS>,
> + <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_MST_BUS>,
> + <&esai0_lpcg 0>;
> + assigned-clock-parents = <&aud_pll_div0_lpcg 0>;
> + assigned-clock-rates = <0>, <786432000>, <49152000>, <12288000>, <49152000>;
> + pinctrl-0 = <&pinctrl_esai0>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> &fec1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_fec1>;
> @@ -264,6 +315,24 @@ pca6416: gpio@20 {
> gpio-controller;
> #gpio-cells = <2>;
> };
> +
> + cs42888: audio-codec@48 {
> + compatible = "cirrus,cs42888";
> + reg = <0x48>;
> + clocks = <&mclkout0_lpcg 0>;
> + clock-names = "mclk";
> + assigned-clocks = <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
> + <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_SLV_BUS>,
> + <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_MST_BUS>,
> + <&mclkout0_lpcg 0>;
> + assigned-clock-rates = <786432000>, <49152000>, <12288000>, <12288000>;
> + reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>;
> + VA-supply = <®_audio>;
> + VD-supply = <®_audio>;
> + VLC-supply = <®_audio>;
> + VLS-supply = <®_audio>;
> +
> + };
> };
>
> &cm40_intmux {
> @@ -458,6 +527,21 @@ IMX8QXP_ADC_IN0_LSIO_GPIO1_IO10 0xc600004c
> >;
> };
>
> + pinctrl_esai0: esai0grp {
> + fsl,pins = <
> + IMX8QXP_ESAI0_FSR_ADMA_ESAI0_FSR 0xc6000040
> + IMX8QXP_ESAI0_FST_ADMA_ESAI0_FST 0xc6000040
> + IMX8QXP_ESAI0_SCKR_ADMA_ESAI0_SCKR 0xc6000040
> + IMX8QXP_ESAI0_SCKT_ADMA_ESAI0_SCKT 0xc6000040
> + IMX8QXP_ESAI0_TX0_ADMA_ESAI0_TX0 0xc6000040
> + IMX8QXP_ESAI0_TX1_ADMA_ESAI0_TX1 0xc6000040
> + IMX8QXP_ESAI0_TX2_RX3_ADMA_ESAI0_TX2_RX3 0xc6000040
> + IMX8QXP_ESAI0_TX3_RX2_ADMA_ESAI0_TX3_RX2 0xc6000040
> + IMX8QXP_ESAI0_TX4_RX1_ADMA_ESAI0_TX4_RX1 0xc6000040
> + IMX8QXP_ESAI0_TX5_RX0_ADMA_ESAI0_TX5_RX0 0xc6000040
> + >;
> + };
> +
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> IMX8QXP_ENET0_MDC_CONN_ENET0_MDC 0x06000020
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/6] arm64: dts: imx8qxp-mek: enable jpeg encode and deconde
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
2024-09-30 21:25 ` [PATCH 2/6] arm64: dts: imx8qxp-mek: add esai, cs42888 and related node Frank Li
@ 2024-09-30 21:26 ` Frank Li
2024-09-30 21:26 ` [PATCH 4/6] arm64: dts: imx8qxp-mek: add flexcan1 and flexcan2 Frank Li
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-09-30 21:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Enable jpeg encode and decode.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 9b9ad389a807a..505015f91c823 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -339,6 +339,14 @@ &cm40_intmux {
status = "okay";
};
+&jpegdec {
+ status = "okay";
+};
+
+&jpegenc {
+ status = "okay";
+};
+
&lpuart0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_lpuart0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/6] arm64: dts: imx8qxp-mek: add flexcan1 and flexcan2
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
2024-09-30 21:25 ` [PATCH 2/6] arm64: dts: imx8qxp-mek: add esai, cs42888 and related node Frank Li
2024-09-30 21:26 ` [PATCH 3/6] arm64: dts: imx8qxp-mek: enable jpeg encode and deconde Frank Li
@ 2024-09-30 21:26 ` Frank Li
2024-09-30 21:26 ` [PATCH 5/6] arm64: dts: imx8qxp-mek: add usbotg1 and related node Frank Li
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-09-30 21:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Add flexcan1 and flexcan2.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 505015f91c823..621ad618aee7b 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -57,6 +57,25 @@ reg_audio: regulator-audio {
regulator-name = "cs42888_supply";
};
+ reg_can_en: regulator-can-en {
+ compatible = "regulator-fixed";
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-name = "can-en";
+ gpio = <&pca6416 3 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ reg_can_stby: regulator-can-stby {
+ compatible = "regulator-fixed";
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-name = "can-stby";
+ gpio = <&pca6416 5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ vin-supply = <®_can_en>;
+ };
+
sound-bt-sco {
compatible = "simple-audio-card";
simple-audio-card,bitclock-inversion;
@@ -339,6 +358,20 @@ &cm40_intmux {
status = "okay";
};
+&flexcan1 {
+ pinctrl-0 = <&pinctrl_flexcan1>;
+ pinctrl-names = "default";
+ xceiver-supply = <®_can_stby>;
+ status = "okay";
+};
+
+&flexcan2 {
+ pinctrl-0 = <&pinctrl_flexcan2>;
+ pinctrl-names = "default";
+ xceiver-supply = <®_can_stby>;
+ status = "okay";
+};
+
&jpegdec {
status = "okay";
};
@@ -569,6 +602,20 @@ IMX8QXP_ENET0_RGMII_RXD3_CONN_ENET0_RGMII_RXD3 0x06000020
>;
};
+ pinctrl_flexcan1: flexcan0grp {
+ fsl,pins = <
+ IMX8QXP_FLEXCAN0_TX_ADMA_FLEXCAN0_TX 0x21
+ IMX8QXP_FLEXCAN0_RX_ADMA_FLEXCAN0_RX 0x21
+ >;
+ };
+
+ pinctrl_flexcan2: flexcan1grp {
+ fsl,pins = <
+ IMX8QXP_FLEXCAN1_TX_ADMA_FLEXCAN1_TX 0x21
+ IMX8QXP_FLEXCAN1_RX_ADMA_FLEXCAN1_RX 0x21
+ >;
+ };
+
pinctrl_ioexp_rst: ioexprstgrp {
fsl,pins = <
IMX8QXP_SPI2_SDO_LSIO_GPIO1_IO01 0x06000021
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/6] arm64: dts: imx8qxp-mek: add usbotg1 and related node
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
` (2 preceding siblings ...)
2024-09-30 21:26 ` [PATCH 4/6] arm64: dts: imx8qxp-mek: add flexcan1 and flexcan2 Frank Li
@ 2024-09-30 21:26 ` Frank Li
2024-09-30 21:26 ` [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes Frank Li
2024-10-02 3:51 ` [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Rob Herring (Arm)
5 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-09-30 21:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Add usbotg1, usbphy1 and related regulator nodes.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 621ad618aee7b..bbb94adfd64f0 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -76,6 +76,15 @@ reg_can_stby: regulator-can-stby {
vin-supply = <®_can_en>;
};
+ reg_usb_otg1_vbus: regulator-usbotg1-vbus {
+ compatible = "regulator-fixed";
+ regulator-max-microvolt = <5000000>;
+ regulator-min-microvolt = <5000000>;
+ regulator-name = "usb_otg1_vbus";
+ gpio = <&pca9557_b 2 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
sound-bt-sco {
compatible = "simple-audio-card";
simple-audio-card,bitclock-inversion;
@@ -518,6 +527,20 @@ &usb3_phy {
status = "okay";
};
+&usbphy1 {
+ status = "okay";
+};
+
+&usbotg1 {
+ adp-disable;
+ hnp-disable;
+ srp-disable;
+ disable-over-current;
+ power-active-high;
+ vbus-supply = <®_usb_otg1_vbus>;
+ status = "okay";
+};
+
&usbotg3 {
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
` (3 preceding siblings ...)
2024-09-30 21:26 ` [PATCH 5/6] arm64: dts: imx8qxp-mek: add usbotg1 and related node Frank Li
@ 2024-09-30 21:26 ` Frank Li
2024-10-21 3:06 ` Shawn Guo
2024-10-02 3:51 ` [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Rob Herring (Arm)
5 siblings, 1 reply; 10+ messages in thread
From: Frank Li @ 2024-09-30 21:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Add cm4 and related nodes.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index bbb94adfd64f0..83e8393a34a0c 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -21,6 +21,21 @@ chosen {
stdout-path = &lpuart0;
};
+ imx8x_cm4: imx8x_cm4 {
+ compatible = "fsl,imx8qxp-cm4";
+ mbox-names = "tx", "rx", "rxdb";
+ mboxes = <&lsio_mu5 0 1
+ &lsio_mu5 1 1
+ &lsio_mu5 3 1>;
+ memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
+ <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
+ power-domains = <&pd IMX_SC_R_M4_0_PID0>,
+ <&pd IMX_SC_R_M4_0_MU_1A>;
+ fsl,entry-address = <0x34fe0000>;
+ fsl,resource-id = <IMX_SC_R_M4_0_PID0>;
+ status = "okay";
+ };
+
memory@80000000 {
device_type = "memory";
reg = <0x00000000 0x80000000 0 0x40000000>;
@@ -85,6 +100,48 @@ reg_usb_otg1_vbus: regulator-usbotg1-vbus {
enable-active-high;
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ vdev0vring0: memory@90000000 {
+ reg = <0 0x90000000 0 0x8000>;
+ no-map;
+ };
+
+ vdev0vring1: memory@90008000 {
+ reg = <0 0x90008000 0 0x8000>;
+ no-map;
+ };
+
+ vdev1vring0: memory@90010000 {
+ reg = <0 0x90010000 0 0x8000>;
+ no-map;
+ };
+
+ vdev1vring1: memory@90018000 {
+ reg = <0 0x90018000 0 0x8000>;
+ no-map;
+ };
+
+ rsc_table: memory@900ff000 {
+ reg = <0 0x900ff000 0 0x1000>;
+ no-map;
+ };
+
+ vdevbuffer: memory@90400000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x90400000 0 0x100000>;
+ no-map;
+ };
+
+ gpu_reserved: gpu_reserved@880000000 {
+ no-map;
+ reg = <0x8 0x80000000 0 0x10000000>;
+ };
+ };
+
sound-bt-sco {
compatible = "simple-audio-card";
simple-audio-card,bitclock-inversion;
@@ -407,6 +464,10 @@ &lpuart3 {
status = "okay";
};
+&lsio_mu5 {
+ status = "okay";
+};
+
&mu_m0 {
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes
2024-09-30 21:26 ` [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes Frank Li
@ 2024-10-21 3:06 ` Shawn Guo
0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2024-10-21 3:06 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, Sep 30, 2024 at 05:26:03PM -0400, Frank Li wrote:
> Add cm4 and related nodes.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index bbb94adfd64f0..83e8393a34a0c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -21,6 +21,21 @@ chosen {
> stdout-path = &lpuart0;
> };
>
> + imx8x_cm4: imx8x_cm4 {
Hyphen instead of underscore in node name.
> + compatible = "fsl,imx8qxp-cm4";
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&lsio_mu5 0 1
> + &lsio_mu5 1 1
> + &lsio_mu5 3 1>;
> + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
> + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
> + power-domains = <&pd IMX_SC_R_M4_0_PID0>,
> + <&pd IMX_SC_R_M4_0_MU_1A>;
> + fsl,entry-address = <0x34fe0000>;
> + fsl,resource-id = <IMX_SC_R_M4_0_PID0>;
> + status = "okay";
> + };
> +
> memory@80000000 {
> device_type = "memory";
> reg = <0x00000000 0x80000000 0 0x40000000>;
> @@ -85,6 +100,48 @@ reg_usb_otg1_vbus: regulator-usbotg1-vbus {
> enable-active-high;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + vdev0vring0: memory@90000000 {
> + reg = <0 0x90000000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev0vring1: memory@90008000 {
> + reg = <0 0x90008000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev1vring0: memory@90010000 {
> + reg = <0 0x90010000 0 0x8000>;
> + no-map;
> + };
> +
> + vdev1vring1: memory@90018000 {
> + reg = <0 0x90018000 0 0x8000>;
> + no-map;
> + };
> +
> + rsc_table: memory@900ff000 {
> + reg = <0 0x900ff000 0 0x1000>;
> + no-map;
> + };
> +
> + vdevbuffer: memory@90400000 {
> + compatible = "shared-dma-pool";
Use tabs instead of spaces for indent.
> + reg = <0 0x90400000 0 0x100000>;
> + no-map;
> + };
> +
> + gpu_reserved: gpu_reserved@880000000 {
"memory" for node name?
Shawn
> + no-map;
> + reg = <0x8 0x80000000 0 0x10000000>;
> + };
> + };
> +
> sound-bt-sco {
> compatible = "simple-audio-card";
> simple-audio-card,bitclock-inversion;
> @@ -407,6 +464,10 @@ &lpuart3 {
> status = "okay";
> };
>
> +&lsio_mu5 {
> + status = "okay";
> +};
> +
> &mu_m0 {
> status = "okay";
> };
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec
2024-09-30 21:25 [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Frank Li
` (4 preceding siblings ...)
2024-09-30 21:26 ` [PATCH 6/6] arm64: dts: imx8qxp-mek: add cm4 and related nodes Frank Li
@ 2024-10-02 3:51 ` Rob Herring (Arm)
2024-10-18 19:39 ` Frank Li
5 siblings, 1 reply; 10+ messages in thread
From: Rob Herring (Arm) @ 2024-10-02 3:51 UTC (permalink / raw)
To: Frank Li
Cc: linux-arm-kernel, imx, Shawn Guo, linux-kernel, Fabio Estevam,
Pengutronix Kernel Team, Sascha Hauer, devicetree, Conor Dooley,
Krzysztof Kozlowski
On Mon, 30 Sep 2024 17:25:58 -0400, Frank Li wrote:
> Add bluetooth audio codec.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y freescale/imx8qxp-mek.dtb' for 20240930212604.118756-1-Frank.Li@nxp.com:
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: usbphy@5b100000: 'nxp,sim' is a required property
from schema $id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec
2024-10-02 3:51 ` [PATCH 1/6] arm64: dts: imx8qxp-mek: add bluetooth audio codec Rob Herring (Arm)
@ 2024-10-18 19:39 ` Frank Li
0 siblings, 0 replies; 10+ messages in thread
From: Frank Li @ 2024-10-18 19:39 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: linux-arm-kernel, imx, Shawn Guo, linux-kernel, Fabio Estevam,
Pengutronix Kernel Team, Sascha Hauer, devicetree, Conor Dooley,
Krzysztof Kozlowski
On Tue, Oct 01, 2024 at 10:51:01PM -0500, Rob Herring (Arm) wrote:
>
> On Mon, 30 Sep 2024 17:25:58 -0400, Frank Li wrote:
> > Add bluetooth audio codec.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 24 +++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
shawn:
Do you have chance to check these patches. The below warning is not
caused by these patches. And this warning's fixed patch already in mail
list.
Frank
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y freescale/imx8qxp-mek.dtb' for 20240930212604.118756-1-Frank.Li@nxp.com:
>
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: usbphy@5b100000: 'nxp,sim' is a required property
> from schema $id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml#
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread