devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk
@ 2024-10-12  2:52 Peng Fan (OSS)
  2024-10-12  3:14 ` Fabio Estevam
  2024-10-22  1:27 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2024-10-12  2:52 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, s.hauer
  Cc: kernel, festevam, devicetree, linux-kernel, imx, linux-arm-kernel,
	Peng Fan

From: Peng Fan <peng.fan@nxp.com>

The ipg clk for sdhc sources from IPG_CLK_ROOT per i.MX 8M Plus
Applications Processor Reference Manual, Table 5-2. System Clocks.

Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 3b02c6e2988c..2ea2fbf2bc20 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1261,7 +1261,7 @@ usdhc1: mmc@30b40000 {
 				compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b40000 0x10000>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_DUMMY>,
+				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
 					 <&clk IMX8MP_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MP_CLK_USDHC1_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -1275,7 +1275,7 @@ usdhc2: mmc@30b50000 {
 				compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b50000 0x10000>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_DUMMY>,
+				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
 					 <&clk IMX8MP_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MP_CLK_USDHC2_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -1289,7 +1289,7 @@ usdhc3: mmc@30b60000 {
 				compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b60000 0x10000>;
 				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_DUMMY>,
+				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
 					 <&clk IMX8MP_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MP_CLK_USDHC3_ROOT>;
 				clock-names = "ipg", "ahb", "per";
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk
  2024-10-12  2:52 [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk Peng Fan (OSS)
@ 2024-10-12  3:14 ` Fabio Estevam
  2024-10-22  1:27 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-10-12  3:14 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, devicetree,
	linux-kernel, imx, linux-arm-kernel, Peng Fan

On Fri, Oct 11, 2024 at 11:43 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:

> -                               clocks = <&clk IMX8MP_CLK_DUMMY>,
> +                               clocks = <&clk IMX8MP_CLK_IPG_ROOT>,

This looks good and aligns with the imx8mm/mn/mq dtsi files:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk
  2024-10-12  2:52 [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk Peng Fan (OSS)
  2024-10-12  3:14 ` Fabio Estevam
@ 2024-10-22  1:27 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-10-22  1:27 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	devicetree, linux-kernel, imx, linux-arm-kernel, Peng Fan

On Sat, Oct 12, 2024 at 10:52:21AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The ipg clk for sdhc sources from IPG_CLK_ROOT per i.MX 8M Plus
> Applications Processor Reference Manual, Table 5-2. System Clocks.
> 
> Fixes: 6d9b8d20431f ("arm64: dts: freescale: Add i.MX8MP dtsi support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-22  1:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-12  2:52 [PATCH] arm64: dts: imx8mp: correct sdhc ipg clk Peng Fan (OSS)
2024-10-12  3:14 ` Fabio Estevam
2024-10-22  1:27 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).