* [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys
@ 2024-10-15 22:44 Marek Vasut
2024-10-16 8:28 ` Christoph Niedermaier
2024-10-22 1:45 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2024-10-15 22:44 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Christoph Niedermaier, Conor Dooley, Fabio Estevam,
Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Shawn Guo, devicetree, imx, kernel
Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
is not a bus, see dtbs_check warning:
"
arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
"
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
index 6248b126b5578..773fdcfcd0015 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
@@ -56,7 +56,6 @@ lcd_display_out: endpoint {
};
gpio-keys {
- #size-cells = <0>;
compatible = "gpio-keys";
button-0 {
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys
2024-10-15 22:44 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys Marek Vasut
@ 2024-10-16 8:28 ` Christoph Niedermaier
2024-10-22 1:45 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Niedermaier @ 2024-10-16 8:28 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel@lists.infradead.org
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree@vger.kernel.org, imx@lists.linux.dev, kernel
From: Marek Vasut <marex@denx.de>
Sent: Wednesday, October 16, 2024 12:45 AM
> Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
> is not a bus, see dtbs_check warning:
>
> "
> arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-
> cells' do not match any of the regexes:
> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-
> (button|event|key|switch))$', 'pinctrl-[0-9]+'
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> index 6248b126b5578..773fdcfcd0015 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> @@ -56,7 +56,6 @@ lcd_display_out: endpoint {
> };
>
> gpio-keys {
> - #size-cells = <0>;
> compatible = "gpio-keys";
>
> button-0 {
Reviewed-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys
2024-10-15 22:44 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys Marek Vasut
2024-10-16 8:28 ` Christoph Niedermaier
@ 2024-10-22 1:45 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-10-22 1:45 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel
On Wed, Oct 16, 2024 at 12:44:52AM +0200, Marek Vasut wrote:
> Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
> is not a bus, see dtbs_check warning:
>
> "
> arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 22:44 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys Marek Vasut
2024-10-16 8:28 ` Christoph Niedermaier
2024-10-22 1:45 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).