* [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
@ 2024-10-15 23:24 Marek Vasut
2024-10-16 8:32 ` Christoph Niedermaier
2024-10-22 1:47 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2024-10-15 23:24 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Christoph Niedermaier, Conor Dooley, Fabio Estevam,
Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Shawn Guo, devicetree, imx, kernel, linux-kernel
Add missing panel power-supply property to DT to fix the following warning.
The power supply on this device is very simple chain of regulators from the
main 24V input, describe those.
"
arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required property
"
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
.../boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
index 773fdcfcd0015..d7c2b30aecfd1 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
@@ -143,6 +143,7 @@ led-8 {
panel {
backlight = <&display_bl>;
compatible = "edt,etm0700g0edh6";
+ power-supply = <®_panel_3v3>;
port {
lcd_panel_in: endpoint {
@@ -151,6 +152,25 @@ lcd_panel_in: endpoint {
};
};
+ /* Filtered supply voltage */
+ reg_pdk2_24v: regulator-pdk2-24v {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-max-microvolt = <24000000>;
+ regulator-min-microvolt = <24000000>;
+ regulator-name = "24V_PDK2";
+ };
+
+ /* 560-200 U1 */
+ reg_panel_3v3: regulator-panel-3v3 {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "3V3_PANEL";
+ vin-supply = <®_pdk2_24v>;
+ };
+
sound {
audio-codec = <&sgtl5000>;
audio-routing =
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
2024-10-15 23:24 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply Marek Vasut
@ 2024-10-16 8:32 ` Christoph Niedermaier
2024-10-22 1:47 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Niedermaier @ 2024-10-16 8:32 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel@lists.infradead.org
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree@vger.kernel.org, imx@lists.linux.dev, kernel,
linux-kernel@vger.kernel.org
From: Marek Vasut <marex@denx.de>
Sent: Wednesday, October 16, 2024 1:25 AM
> Add missing panel power-supply property to DT to fix the following warning.
> The power supply on this device is very simple chain of regulators from the
> main 24V input, describe those.
>
> "
> arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required
> property
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> .../boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> index 773fdcfcd0015..d7c2b30aecfd1 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> @@ -143,6 +143,7 @@ led-8 {
> panel {
> backlight = <&display_bl>;
> compatible = "edt,etm0700g0edh6";
> + power-supply = <®_panel_3v3>;
>
> port {
> lcd_panel_in: endpoint {
> @@ -151,6 +152,25 @@ lcd_panel_in: endpoint {
> };
> };
>
> + /* Filtered supply voltage */
> + reg_pdk2_24v: regulator-pdk2-24v {
> + compatible = "regulator-fixed";
> + regulator-always-on;
> + regulator-max-microvolt = <24000000>;
> + regulator-min-microvolt = <24000000>;
> + regulator-name = "24V_PDK2";
> + };
> +
> + /* 560-200 U1 */
> + reg_panel_3v3: regulator-panel-3v3 {
> + compatible = "regulator-fixed";
> + regulator-always-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "3V3_PANEL";
> + vin-supply = <®_pdk2_24v>;
> + };
> +
> sound {
> audio-codec = <&sgtl5000>;
> audio-routing =
Reviewed-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
2024-10-15 23:24 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply Marek Vasut
2024-10-16 8:32 ` Christoph Niedermaier
@ 2024-10-22 1:47 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-10-22 1:47 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel,
linux-kernel
On Wed, Oct 16, 2024 at 01:24:51AM +0200, Marek Vasut wrote:
> Add missing panel power-supply property to DT to fix the following warning.
> The power supply on this device is very simple chain of regulators from the
> main 24V input, describe those.
>
> "
> arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required property
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 23:24 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply Marek Vasut
2024-10-16 8:32 ` Christoph Niedermaier
2024-10-22 1:47 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).