From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32955191F95 for ; Tue, 22 Oct 2024 08:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729585777; cv=none; b=ZIzf5PTGWRA/D1Zk+oZamci4o4R4CbWCWE16t13+qmP+jIoZjY7oQhtA2iOIY7s9YDVzbs5S/ol+KGoNzo0AHf1u2NxBzzavGO9KWUHNqvuWfZgCbdrsEYER5Gsa8KQqhRA2D4SywjfHIXET+YmLUrawKXJUgf24iMLX4WhPfWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729585777; c=relaxed/simple; bh=bEKAEeDjsfkpr3NXf7w6RwcSc/+oBytWAMh+Aw1PHdE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sU5VsZ9ppKg2yW5KxFlgsixK9sKAdHBfdgBaaKSLAeWq3EwsWrWpQZkwIe9gLMJ09uxd3V2AStLIaQ8dC1eTQyNpoD76X/dJNMVzegIfHLbwBxG9lMF9aWJtLMbftl73vnVrt7/DnHh6rZlIIKZAtxGUJkNYEEBYvA6W3ubpLzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DjTlnATo; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DjTlnATo" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4314fa33a35so55145105e9.1 for ; Tue, 22 Oct 2024 01:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729585773; x=1730190573; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HjDsS+1q07DHK+ymYm6GkZX2xnCRVZpDlWCzY/btsRo=; b=DjTlnATopK3LAp4B+C7Lk76+DAinha90NdCnVnQY/xXsMir7sYe5t56DdeiHZPFx2+ Yau/n7vbH1PERND7D294K7K4kCGXC9p9HFvrEsYIQgEgQwGcc9hU4QrF+n72wzeKxoB0 awVEp/AKsbyrmvUlw5IVfK67HVCNe+Zo2HP8ASKXaewTD0vBjJEj2gH9wxAe7FFsbbp/ okyCF9Wj9zPDc4n8ZagzYM/TTZmhvRx6V3Pn4XKs/g6zCkGOmvUGb0ktevi05/NFG4Ld KxJcgV49nze9F0/pUSVmwwAYHiOvi2Sf3N7FQWpDhK8/2W+e+2ipT+aFKmPJhYPLiMDI k03A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729585773; x=1730190573; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HjDsS+1q07DHK+ymYm6GkZX2xnCRVZpDlWCzY/btsRo=; b=OSuADdJfW3BF6GKeK52fLQnrkZu65+bHsNQPp6OZhAKdmXEsWC3SklaTm+VNOgF/Ks ycVaBYYCH9V4wTWHJW7ph4ZHTyv2s5YbnwDNNwUq3kinxiI+HWGq4Qkr8kboitoHYUxm zXTJyTnkCjjUVALN+kwFF+PgNzFMjdcM8N533S7oX40T8YsWJTOZdIPHvuy4uMUGwmOP Rdr2o2AwTPUYD7aCog4dT0IXh1oQXi9yOotpUGOrNxCuaPEVFJKiWjf1PuWmgIWrQjLa KHYGSOwm84i+lJ02rT8/1k6JS3E56jZhR2fzKBWQt4vjHGeFbjUPRB3kU8LdtKvfGIyr oyTw== X-Forwarded-Encrypted: i=1; AJvYcCWCKgoWiiqM0K8pyHxr8kVsnxSJGfllbZG6xshFHSSNz9i+BfRC8MXfJodg7zy4tREim6a/pjoMOjCp@vger.kernel.org X-Gm-Message-State: AOJu0YxageqIda7nXxwgjjBJ5EEHSID2g53mmRLbmMQQmNY286yc86R4 CNTQdkCNUGc7urgSlyNMS3W7Vz9hBCu/bMnauH8vpLHNUQiMlZaLLyXilWCurCy0mIu+DhYKNqr X X-Google-Smtp-Source: AGHT+IE+SNDjL4952t77e0RAt7JLi2MDieoW4JvDW20v/QUsIp9vmzVn/LMvIVc+mnRMKtbJnNHGnQ== X-Received: by 2002:a05:600c:3151:b0:431:588a:4498 with SMTP id 5b1f17b1804b1-4317b8dfcfcmr23701415e9.14.1729585773420; Tue, 22 Oct 2024 01:29:33 -0700 (PDT) Received: from linaro.org ([82.76.168.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5c2cb8sm82100105e9.31.2024.10.22.01.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 01:29:32 -0700 (PDT) Date: Tue, 22 Oct 2024 11:29:30 +0300 From: Abel Vesa To: Christophe JAILLET Cc: Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rajendra Nayak , Sibi Sankar , Johan Hovold , Dmitry Baryshkov , Trilok Soni , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/2] usb: typec: Add support for Parade PS8830 Type-C Retimer Message-ID: References: <20241004-x1e80100-ps8830-v2-0-5cd8008c8c40@linaro.org> <20241004-x1e80100-ps8830-v2-2-5cd8008c8c40@linaro.org> <133f0232-6e62-4532-bdeb-85b5927fddc8@wanadoo.fr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <133f0232-6e62-4532-bdeb-85b5927fddc8@wanadoo.fr> On 24-10-22 09:41:42, Christophe JAILLET wrote: > Le 04/10/2024 à 15:57, Abel Vesa a écrit : > > The Parade PS8830 is a Type-C muti-protocol retimer controlled over I2C. > > It provides both altmode and orientation handling. > > > > Add a driver with support for the following modes: > > - DP 4lanes > > - DP 2lanes + USB3 > > - USB3 > > > > Signed-off-by: Abel Vesa > > --- > > Hi, > > > +static int ps8830_retimer_probe(struct i2c_client *client) > > +{ > > + struct device *dev = &client->dev; > > + struct typec_switch_desc sw_desc = { }; > > + struct typec_retimer_desc rtmr_desc = { }; > > + struct ps8830_retimer *retimer; > > + int ret; > > + > > + retimer = devm_kzalloc(dev, sizeof(*retimer), GFP_KERNEL); > > + if (!retimer) > > + return -ENOMEM; > > + > > + retimer->client = client; > > + > > + mutex_init(&retimer->lock); > > + > > + retimer->regmap = devm_regmap_init_i2c(client, &ps8830_retimer_regmap); > > + if (IS_ERR(retimer->regmap)) { > > + dev_err(dev, "failed to allocate register map\n"); > > + return PTR_ERR(retimer->regmap); > > + } > > + > > + ret = ps8830_get_vregs(retimer); > > + if (ret) > > + return ret; > > + > > + retimer->xo_clk = devm_clk_get(dev, "xo"); > > + if (IS_ERR(retimer->xo_clk)) > > + return dev_err_probe(dev, PTR_ERR(retimer->xo_clk), > > + "failed to get xo clock\n"); > > + > > + retimer->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > > + if (IS_ERR(retimer->reset_gpio)) > > + return dev_err_probe(dev, PTR_ERR(retimer->reset_gpio), > > + "failed to get reset gpio\n"); > > + > > + retimer->typec_switch = fwnode_typec_switch_get(dev->fwnode); > > + if (IS_ERR(retimer->typec_switch)) { > > + dev_err(dev, "failed to acquire orientation-switch\n"); > > + return PTR_ERR(retimer->typec_switch); > > + } > > + > > + retimer->typec_mux = fwnode_typec_mux_get(dev->fwnode); > > + if (IS_ERR(retimer->typec_mux)) { > > + dev_err(dev, "failed to acquire mode-mux\n"); > > + goto err_switch_put; > > + } > > + > > + sw_desc.drvdata = retimer; > > + sw_desc.fwnode = dev_fwnode(dev); > > + sw_desc.set = ps8830_sw_set; > > + > > + ret = drm_aux_bridge_register(dev); > > + if (ret) > > + goto err_mux_put; > > + > > + retimer->sw = typec_switch_register(dev, &sw_desc); > > + if (IS_ERR(retimer->sw)) { > > + dev_err(dev, "failed to register typec switch\n"); > > + goto err_aux_bridge_unregister; > > + } > > + > > + rtmr_desc.drvdata = retimer; > > + rtmr_desc.fwnode = dev_fwnode(dev); > > + rtmr_desc.set = ps8830_retimer_set; > > + > > + retimer->retimer = typec_retimer_register(dev, &rtmr_desc); > > + if (IS_ERR(retimer->retimer)) { > > + dev_err(dev, "failed to register typec retimer\n"); > > + goto err_switch_unregister; > > + } > > + > > + ret = clk_prepare_enable(retimer->xo_clk); > > + if (ret) { > > + dev_err(dev, "failed to enable XO: %d\n", ret); > > + goto err_retimer_unregister; > > + } > > + > > + ret = ps8830_enable_vregs(retimer); > > + if (ret) > > + goto err_clk_disable; > > + > > + /* delay needed as per datasheet */ > > + usleep_range(4000, 14000); > > + > > + gpiod_set_value(retimer->reset_gpio, 1); > > + > > + return 0; > > + > > +err_clk_disable: > > + clk_disable_unprepare(retimer->xo_clk); > > + > > +err_retimer_unregister: > > + typec_retimer_unregister(retimer->retimer); > > + > > +err_switch_unregister: > > + typec_switch_unregister(retimer->sw); > > + > > +err_aux_bridge_unregister: > > + gpiod_set_value(retimer->reset_gpio, 0); > > Is this called useful here? > gpiod_set_value(, 1) has not been called yet. > > It made sense to have something like that in v1, but it looks strange in v2. > The devm_gpiod_get() flag sets it to HIGH. Anyway, this will be reworked in v3 as the reset gpio is active low. > CJ > > > + clk_disable_unprepare(retimer->xo_clk); > > + > > +err_mux_put: > > + typec_mux_put(retimer->typec_mux); > > + > > +err_switch_put: > > + typec_switch_put(retimer->typec_switch); > > + > > + return ret; > > +} > > ...