From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Stephan Gerhold <stephan.gerhold@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: x1e80100-crd: describe HID supplies
Date: Fri, 25 Oct 2024 17:22:10 +0200 [thread overview]
Message-ID: <Zxu3orjs9hR5KNc_@hovoldconsulting.com> (raw)
In-Reply-To: <ZxKYp1pGTp/FVGUg@linaro.org>
On Fri, Oct 18, 2024 at 08:19:35PM +0300, Abel Vesa wrote:
> On 24-10-15 16:57:18, Stephan Gerhold wrote:
> > On Tue, Oct 15, 2024 at 02:24:27PM +0200, Johan Hovold wrote:
> > > +&pm8550ve_8_gpios {
> > > + misc_3p3_reg_en: misc-3p3-reg-en-state {
> > > + pins = "gpio6";
> > > + function = "normal";
> > > + bias-disable;
> >
> > Can we add a "power-source" here? PMIC GPIOs can be either ~3.7V
> > (VPH_PWR) or 1.8V, depending on which power-source is selected. Without
> > that, we rely on the firmware to set the voltage level for the GPIO
> > during boot.
>
> AFAIU, the power-source here should be 0, which selects VPH_PWR which is
> 3.3V. In that case I think we can avoid explicitly setting it.
The firmware uses 1.8 V here in fact, but it seems like 3.3 V would work
as well.
> > I'm not sure which one would be suitable here. I guess we can just
> > replicate what the firmware configures during boot.
Let's start with that at least.
Johan
prev parent reply other threads:[~2024-10-25 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:24 [PATCH] arm64: dts: x1e80100-crd: describe HID supplies Johan Hovold
2024-10-15 13:24 ` Dmitry Baryshkov
2024-10-15 13:41 ` Abel Vesa
2024-10-16 16:43 ` Stephan Gerhold
2024-10-25 15:18 ` Johan Hovold
2024-10-15 14:57 ` Stephan Gerhold
2024-10-18 17:19 ` Abel Vesa
2024-10-25 15:22 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxu3orjs9hR5KNc_@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).