From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571441E25E1 for ; Fri, 8 Nov 2024 10:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731060877; cv=none; b=JlKqzHtBsNMZqrFmT7FRuCid+DfADPsBpbx0Z8o3zOh7nkEJ52OzZiLunpTNqeXh/3qJdpKdsguQ78l/JbQgSU4sYe5AX2txGy/8hwVQUPYWdvgXJHQfKPfE7H814qh6RfbDPQ9St3SOtr2i2PO+UXG1P9eOrNnRuQoGw/ytmUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731060877; c=relaxed/simple; bh=XkGgv5eX9hGP/+6vsdILQJodcuwb2z/IVmUjUdqJ/2g=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hAlelaG4ECePwcToTx/cjdFulGSGDa9zsRA3MWnliKe7twP5JbDKa5gcM3mMa/c7UMUAvT3leLfNnKmkfip+q59ovCm5DxjkX7IwAQST92Rm0mQI0Bpj0wFMaEVszxN+ZBzwQ8UYlCcziHX/LCkwNsetjELarIxCZUYmpc2/kPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Y44aBSah; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Y44aBSah" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-a99ebb390a5so562751666b.1 for ; Fri, 08 Nov 2024 02:14:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731060873; x=1731665673; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=SnVZ0emV6bVkYUAc532QwJ4he0bCKDKGP+zZEkPy81k=; b=Y44aBSahMuLEW64kUDU8e5oWPxHX1p3+jAw2IQ+FDwJah7gKRz1KHXo5GAwFdlxy38 ejBhlWG2pwG3x/RFPbF+gHpv3heebEVwAG1jqgJzUP7Vi3IDeP+zqc1xwtn3jO/+WkNG 5lfE9hyQUoAwSgaCY/Eq5oB0FD5uDyCARVECCzN/zovWJAVed5P8cQ9/07gZxrqfmt7y HbRTXNZNfbPg9BzfuqxCkuFFEYP85FJbRTe9g1xblZnEQ8ZMv5U7CsLRLYKyWdZZzPUw QZYjNdeGhnBTwsgxJjs6FM879C+80DX6VT8jDLS1rxnZgdjLgGqF/kBB/hkEUzJ0t2j1 nRkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731060873; x=1731665673; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SnVZ0emV6bVkYUAc532QwJ4he0bCKDKGP+zZEkPy81k=; b=rQ7GWyDY3WzOGFaeAfx/DWAdCPivzpuZJNyOl42MJ2jCck0K9+Nzp6dKJlmW5Ondp6 fcXsAVsrUl903Jnj5w9XHSX6xVNsTnwCm7wl7HySSwGVr737NCAmZcY+8posss5fnbdC gmHUiwINhQB9qtIq8dKGUwMUOGt/WB1oA12ezu6OclcK+1pUQfbt/f719/yQk7fe33Ai 1LWEOiyJ/g1iNzb/3BWfAjJB6URli+aEZDEj4WhWi4xHR8LVl1/1iS54gQlYwLlTm0na 1snBKFlTMF818BXNoUkxYnu1v+NHnHeOvS+VYijWDahWo+RvA7r5SCVrm/LP5h8vqtul pz7w== X-Forwarded-Encrypted: i=1; AJvYcCVP03Kvp8RLSQR6P5WNbAOoZGrHMlnLSMoPwSCH3YWpXaevj4BmTnTRlQlCWN8++sN6GNolXr1zLzh4@vger.kernel.org X-Gm-Message-State: AOJu0YwGOYw8MwuZWq9rkZCWSkLxzON8cxHVzwpMbUVQAboeYCvl9sFe solpJmg20Z3oGb7WCkNKq/EPzHUzx19njBoW26mUaYlwWMwMgdGjw8h4uXZwrqE= X-Google-Smtp-Source: AGHT+IGMkZNj149mgtvYpa+dcdi+Hv2GUHkHisgCOmyCoj4UxPuG3y0YVKFRG6NnyfhzAQT2cBQMhA== X-Received: by 2002:a17:907:9455:b0:a9a:b818:521d with SMTP id a640c23a62f3a-a9eec9cf03dmr279872866b.18.1731060872701; Fri, 08 Nov 2024 02:14:32 -0800 (PST) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0dc4c7asm210184166b.96.2024.11.08.02.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 02:14:32 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 8 Nov 2024 11:14:59 +0100 To: Herve Codina Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH] PCI: of_property: Assign PCI instead of CPU bus address to dynamic PCI nodes Message-ID: References: <20241108094256.28933-1-andrea.porta@suse.com> <20241108110938.622014f5@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241108110938.622014f5@bootlin.com> Hi herve, On 11:09 Fri 08 Nov , Herve Codina wrote: > Hi Andrea, > > On Fri, 8 Nov 2024 10:42:56 +0100 > Andrea della Porta wrote: > > > When populating "ranges" property for a PCI bridge or endpoint, > > of_pci_prop_ranges() incorrectly use the CPU bus address of the resource. > > In such PCI nodes, the window should instead be in PCI address space. Call > > pci_bus_address() on the resource in order to obtain the PCI bus > > address. > > > > Fixes: 407d1a51921e ("PCI: Create device tree node for bridge") > > Cc: stable@vger.kernel.org > > Signed-off-by: Andrea della Porta > > Acked-by: Bjorn Helgaas > > Tested-by: Herve Codina > > --- > > This patch, originally preparatory for a bigger patchset (see [1]), has > > been splitted in a standalone one for better management and because it > > contains a bugfix which is probably of interest to stable branch. > > Nothing to say for the patch itself. > > Just here, you mentioned "see [1]" but you didn't provide the link. > > IMHO, this is not blocking for applying the patch but, just for other people > looking at this email in the mailing list, can you reply providing the link? Thanks for pointing that out, sorry about that. Here it is: [1] - https://lore.kernel.org/all/f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com/ Many thanks, Andrea > > Best regards, > Hervé