* [PATCH 2/3] perf: imx_perf: add support for i.MX91 platform
2024-09-24 6:12 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Xu Yang
@ 2024-09-24 6:12 ` Xu Yang
2024-09-24 18:09 ` Frank Li
2024-09-24 6:12 ` [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Xu Yang
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Xu Yang @ 2024-09-24 6:12 UTC (permalink / raw)
To: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, namhyung, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang
Cc: linux-arm-kernel, devicetree, imx, linux-perf-users
This will add compatible and identifier for i.MX91 platform.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/perf/fsl_imx9_ddr_perf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 69f920b1caf2..fe1a51f64751 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -81,6 +81,10 @@ struct ddr_pmu {
int id;
};
+static const struct imx_ddr_devtype_data imx91_devtype_data = {
+ .identifier = "imx91",
+};
+
static const struct imx_ddr_devtype_data imx93_devtype_data = {
.identifier = "imx93",
};
@@ -100,6 +104,7 @@ static inline bool is_imx95(struct ddr_pmu *pmu)
}
static const struct of_device_id imx_ddr_pmu_dt_ids[] = {
+ { .compatible = "fsl,imx91-ddr-pmu", .data = &imx91_devtype_data },
{ .compatible = "fsl,imx93-ddr-pmu", .data = &imx93_devtype_data },
{ .compatible = "fsl,imx95-ddr-pmu", .data = &imx95_devtype_data },
{ /* sentinel */ }
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 2/3] perf: imx_perf: add support for i.MX91 platform
2024-09-24 6:12 ` [PATCH 2/3] perf: imx_perf: add support for i.MX91 platform Xu Yang
@ 2024-09-24 18:09 ` Frank Li
0 siblings, 0 replies; 15+ messages in thread
From: Frank Li @ 2024-09-24 18:09 UTC (permalink / raw)
To: Xu Yang
Cc: will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, john.g.garry, james.clark, mike.leach, leo.yan,
peterz, mingo, acme, namhyung, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Tue, Sep 24, 2024 at 02:12:50PM +0800, Xu Yang wrote:
> This will add compatible and identifier for i.MX91 platform.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/perf/fsl_imx9_ddr_perf.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 69f920b1caf2..fe1a51f64751 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -81,6 +81,10 @@ struct ddr_pmu {
> int id;
> };
>
> +static const struct imx_ddr_devtype_data imx91_devtype_data = {
> + .identifier = "imx91",
> +};
> +
> static const struct imx_ddr_devtype_data imx93_devtype_data = {
> .identifier = "imx93",
> };
> @@ -100,6 +104,7 @@ static inline bool is_imx95(struct ddr_pmu *pmu)
> }
>
> static const struct of_device_id imx_ddr_pmu_dt_ids[] = {
> + { .compatible = "fsl,imx91-ddr-pmu", .data = &imx91_devtype_data },
> { .compatible = "fsl,imx93-ddr-pmu", .data = &imx93_devtype_data },
> { .compatible = "fsl,imx95-ddr-pmu", .data = &imx95_devtype_data },
> { /* sentinel */ }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-09-24 6:12 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Xu Yang
2024-09-24 6:12 ` [PATCH 2/3] perf: imx_perf: add support for i.MX91 platform Xu Yang
@ 2024-09-24 6:12 ` Xu Yang
2024-09-30 21:07 ` Namhyung Kim
2024-10-29 18:29 ` Namhyung Kim
2024-09-24 16:27 ` [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Conor Dooley
` (2 subsequent siblings)
4 siblings, 2 replies; 15+ messages in thread
From: Xu Yang @ 2024-09-24 6:12 UTC (permalink / raw)
To: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, namhyung, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang
Cc: linux-arm-kernel, devicetree, imx, linux-perf-users
Add JSON metrics for i.MX91 DDR Performance Monitor.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
.../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
.../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
2 files changed, 35 insertions(+)
create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
new file mode 100644
index 000000000000..74ac12660a29
--- /dev/null
+++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
@@ -0,0 +1,9 @@
+[
+ {
+ "BriefDescription": "ddr cycles event",
+ "EventCode": "0x00",
+ "EventName": "imx91_ddr.cycles",
+ "Unit": "imx9_ddr",
+ "Compat": "imx91"
+ }
+]
diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
new file mode 100644
index 000000000000..f0c5911eb2d0
--- /dev/null
+++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
@@ -0,0 +1,26 @@
+[
+ {
+ "BriefDescription": "bandwidth usage for lpddr4 evk board",
+ "MetricName": "imx91_bandwidth_usage.lpddr4",
+ "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (2400 * 1000000 * 2)",
+ "ScaleUnit": "1e2%",
+ "Unit": "imx9_ddr",
+ "Compat": "imx91"
+ },
+ {
+ "BriefDescription": "bytes all masters read from ddr",
+ "MetricName": "imx91_ddr_read.all",
+ "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8",
+ "ScaleUnit": "9.765625e-4KB",
+ "Unit": "imx9_ddr",
+ "Compat": "imx91"
+ },
+ {
+ "BriefDescription": "bytes all masters write to ddr",
+ "MetricName": "imx91_ddr_write.all",
+ "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32",
+ "ScaleUnit": "9.765625e-4KB",
+ "Unit": "imx9_ddr",
+ "Compat": "imx91"
+ }
+]
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-09-24 6:12 ` [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Xu Yang
@ 2024-09-30 21:07 ` Namhyung Kim
2024-10-08 5:49 ` Xu Yang
2024-10-29 18:29 ` Namhyung Kim
1 sibling, 1 reply; 15+ messages in thread
From: Namhyung Kim @ 2024-09-30 21:07 UTC (permalink / raw)
To: Xu Yang
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
Hello,
On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> Add JSON metrics for i.MX91 DDR Performance Monitor.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
How do you want to route this? As it's mixed with kernel changes, I
would generally request to split but it's a change just to add new
files so it should be ok to go with other tree. In that case,
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> new file mode 100644
> index 000000000000..74ac12660a29
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> @@ -0,0 +1,9 @@
> +[
> + {
> + "BriefDescription": "ddr cycles event",
> + "EventCode": "0x00",
> + "EventName": "imx91_ddr.cycles",
> + "Unit": "imx9_ddr",
> + "Compat": "imx91"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> new file mode 100644
> index 000000000000..f0c5911eb2d0
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> @@ -0,0 +1,26 @@
> +[
> + {
> + "BriefDescription": "bandwidth usage for lpddr4 evk board",
> + "MetricName": "imx91_bandwidth_usage.lpddr4",
> + "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (2400 * 1000000 * 2)",
> + "ScaleUnit": "1e2%",
> + "Unit": "imx9_ddr",
> + "Compat": "imx91"
> + },
> + {
> + "BriefDescription": "bytes all masters read from ddr",
> + "MetricName": "imx91_ddr_read.all",
> + "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8",
> + "ScaleUnit": "9.765625e-4KB",
> + "Unit": "imx9_ddr",
> + "Compat": "imx91"
> + },
> + {
> + "BriefDescription": "bytes all masters write to ddr",
> + "MetricName": "imx91_ddr_write.all",
> + "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32",
> + "ScaleUnit": "9.765625e-4KB",
> + "Unit": "imx9_ddr",
> + "Compat": "imx91"
> + }
> +]
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-09-30 21:07 ` Namhyung Kim
@ 2024-10-08 5:49 ` Xu Yang
2024-10-09 6:49 ` Namhyung Kim
0 siblings, 1 reply; 15+ messages in thread
From: Xu Yang @ 2024-10-08 5:49 UTC (permalink / raw)
To: Namhyung Kim
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
Hi Namhyung,
On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> Hello,
>
> On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > Add JSON metrics for i.MX91 DDR Performance Monitor.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > 2 files changed, 35 insertions(+)
> > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
>
> How do you want to route this? As it's mixed with kernel changes, I
> would generally request to split but it's a change just to add new
> files so it should be ok to go with other tree. In that case,
Sorry for late.
How about you pick up this one to perf-tools tree and Will Deacon pick up
the first 2 patches to his tree? I didn't see Will apply perf-tools patch
before.
Thanks,
Xu Yang
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>
> >
> > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > new file mode 100644
> > index 000000000000..74ac12660a29
> > --- /dev/null
> > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > @@ -0,0 +1,9 @@
> > +[
> > + {
> > + "BriefDescription": "ddr cycles event",
> > + "EventCode": "0x00",
> > + "EventName": "imx91_ddr.cycles",
> > + "Unit": "imx9_ddr",
> > + "Compat": "imx91"
> > + }
> > +]
> > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > new file mode 100644
> > index 000000000000..f0c5911eb2d0
> > --- /dev/null
> > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > @@ -0,0 +1,26 @@
> > +[
> > + {
> > + "BriefDescription": "bandwidth usage for lpddr4 evk board",
> > + "MetricName": "imx91_bandwidth_usage.lpddr4",
> > + "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (2400 * 1000000 * 2)",
> > + "ScaleUnit": "1e2%",
> > + "Unit": "imx9_ddr",
> > + "Compat": "imx91"
> > + },
> > + {
> > + "BriefDescription": "bytes all masters read from ddr",
> > + "MetricName": "imx91_ddr_read.all",
> > + "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8",
> > + "ScaleUnit": "9.765625e-4KB",
> > + "Unit": "imx9_ddr",
> > + "Compat": "imx91"
> > + },
> > + {
> > + "BriefDescription": "bytes all masters write to ddr",
> > + "MetricName": "imx91_ddr_write.all",
> > + "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32",
> > + "ScaleUnit": "9.765625e-4KB",
> > + "Unit": "imx9_ddr",
> > + "Compat": "imx91"
> > + }
> > +]
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-10-08 5:49 ` Xu Yang
@ 2024-10-09 6:49 ` Namhyung Kim
2024-10-09 9:38 ` Xu Yang
2024-10-24 12:26 ` Will Deacon
0 siblings, 2 replies; 15+ messages in thread
From: Namhyung Kim @ 2024-10-09 6:49 UTC (permalink / raw)
To: Xu Yang
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Tue, Oct 08, 2024 at 01:49:35PM +0800, Xu Yang wrote:
> Hi Namhyung,
>
> On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> > Hello,
> >
> > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > > Add JSON metrics for i.MX91 DDR Performance Monitor.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > ---
> > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > > 2 files changed, 35 insertions(+)
> > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> >
> > How do you want to route this? As it's mixed with kernel changes, I
> > would generally request to split but it's a change just to add new
> > files so it should be ok to go with other tree. In that case,
>
> Sorry for late.
>
> How about you pick up this one to perf-tools tree and Will Deacon pick up
> the first 2 patches to his tree? I didn't see Will apply perf-tools patch
> before.
Did Will pick up the kernel patches already?
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-10-09 6:49 ` Namhyung Kim
@ 2024-10-09 9:38 ` Xu Yang
2024-10-10 0:21 ` Namhyung Kim
2024-10-24 12:26 ` Will Deacon
1 sibling, 1 reply; 15+ messages in thread
From: Xu Yang @ 2024-10-09 9:38 UTC (permalink / raw)
To: Namhyung Kim
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Tue, Oct 08, 2024 at 11:49:23PM -0700, Namhyung Kim wrote:
> On Tue, Oct 08, 2024 at 01:49:35PM +0800, Xu Yang wrote:
> > Hi Namhyung,
> >
> > On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> > > Hello,
> > >
> > > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > > > Add JSON metrics for i.MX91 DDR Performance Monitor.
> > > >
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > > ---
> > > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > > > 2 files changed, 35 insertions(+)
> > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > >
> > > How do you want to route this? As it's mixed with kernel changes, I
> > > would generally request to split but it's a change just to add new
> > > files so it should be ok to go with other tree. In that case,
> >
> > Sorry for late.
> >
> > How about you pick up this one to perf-tools tree and Will Deacon pick up
> > the first 2 patches to his tree? I didn't see Will apply perf-tools patch
> > before.
>
> Did Will pick up the kernel patches already?
Not yet. I could ping you once it's done, is it ok?
Thanks,
Xu Yang
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-10-09 9:38 ` Xu Yang
@ 2024-10-10 0:21 ` Namhyung Kim
2024-10-29 8:31 ` Xu Yang
0 siblings, 1 reply; 15+ messages in thread
From: Namhyung Kim @ 2024-10-10 0:21 UTC (permalink / raw)
To: Xu Yang
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Wed, Oct 09, 2024 at 05:38:25PM +0800, Xu Yang wrote:
> On Tue, Oct 08, 2024 at 11:49:23PM -0700, Namhyung Kim wrote:
> > On Tue, Oct 08, 2024 at 01:49:35PM +0800, Xu Yang wrote:
> > > Hi Namhyung,
> > >
> > > On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> > > > Hello,
> > > >
> > > > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > > > > Add JSON metrics for i.MX91 DDR Performance Monitor.
> > > > >
> > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > > > ---
> > > > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > > > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > > > > 2 files changed, 35 insertions(+)
> > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > > >
> > > > How do you want to route this? As it's mixed with kernel changes, I
> > > > would generally request to split but it's a change just to add new
> > > > files so it should be ok to go with other tree. In that case,
> > >
> > > Sorry for late.
> > >
> > > How about you pick up this one to perf-tools tree and Will Deacon pick up
> > > the first 2 patches to his tree? I didn't see Will apply perf-tools patch
> > > before.
> >
> > Did Will pick up the kernel patches already?
>
> Not yet. I could ping you once it's done, is it ok?
Sure!
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-10-10 0:21 ` Namhyung Kim
@ 2024-10-29 8:31 ` Xu Yang
0 siblings, 0 replies; 15+ messages in thread
From: Xu Yang @ 2024-10-29 8:31 UTC (permalink / raw)
To: Namhyung Kim
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
Hi Namhyung,
On Wed, Oct 09, 2024 at 05:21:33PM -0700, Namhyung Kim wrote:
> On Wed, Oct 09, 2024 at 05:38:25PM +0800, Xu Yang wrote:
> > On Tue, Oct 08, 2024 at 11:49:23PM -0700, Namhyung Kim wrote:
> > > On Tue, Oct 08, 2024 at 01:49:35PM +0800, Xu Yang wrote:
> > > > Hi Namhyung,
> > > >
> > > > On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> > > > > Hello,
> > > > >
> > > > > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > > > > > Add JSON metrics for i.MX91 DDR Performance Monitor.
> > > > > >
> > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > > > > ---
> > > > > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > > > > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > > > > > 2 files changed, 35 insertions(+)
> > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > > > >
> > > > > How do you want to route this? As it's mixed with kernel changes, I
> > > > > would generally request to split but it's a change just to add new
> > > > > files so it should be ok to go with other tree. In that case,
> > > >
> > > > Sorry for late.
> > > >
> > > > How about you pick up this one to perf-tools tree and Will Deacon pick up
> > > > the first 2 patches to his tree? I didn't see Will apply perf-tools patch
> > > > before.
> > >
> > > Did Will pick up the kernel patches already?
> >
> > Not yet. I could ping you once it's done, is it ok?
>
> Sure!
You could pick up this path #3 now. :)
Thanks,
Xu Yang
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-10-09 6:49 ` Namhyung Kim
2024-10-09 9:38 ` Xu Yang
@ 2024-10-24 12:26 ` Will Deacon
1 sibling, 0 replies; 15+ messages in thread
From: Will Deacon @ 2024-10-24 12:26 UTC (permalink / raw)
To: Namhyung Kim
Cc: Xu Yang, Frank.li, mark.rutland, robh, krzk+dt, conor+dt,
shawnguo, s.hauer, kernel, festevam, john.g.garry, james.clark,
mike.leach, leo.yan, peterz, mingo, acme, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang, linux-arm-kernel,
devicetree, imx, linux-perf-users
On Tue, Oct 08, 2024 at 11:49:23PM -0700, Namhyung Kim wrote:
> On Tue, Oct 08, 2024 at 01:49:35PM +0800, Xu Yang wrote:
> > Hi Namhyung,
> >
> > On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote:
> > > Hello,
> > >
> > > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> > > > Add JSON metrics for i.MX91 DDR Performance Monitor.
> > > >
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > > ---
> > > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++
> > > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++
> > > > 2 files changed, 35 insertions(+)
> > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json
> > > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json
> > >
> > > How do you want to route this? As it's mixed with kernel changes, I
> > > would generally request to split but it's a change just to add new
> > > files so it should be ok to go with other tree. In that case,
> >
> > Sorry for late.
> >
> > How about you pick up this one to perf-tools tree and Will Deacon pick up
> > the first 2 patches to his tree? I didn't see Will apply perf-tools patch
> > before.
>
> Did Will pick up the kernel patches already?
I have done now, sorry for the delay.
Will
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics
2024-09-24 6:12 ` [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Xu Yang
2024-09-30 21:07 ` Namhyung Kim
@ 2024-10-29 18:29 ` Namhyung Kim
1 sibling, 0 replies; 15+ messages in thread
From: Namhyung Kim @ 2024-10-29 18:29 UTC (permalink / raw)
To: Xu Yang
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote:
> Add JSON metrics for i.MX91 DDR Performance Monitor.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible
2024-09-24 6:12 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Xu Yang
2024-09-24 6:12 ` [PATCH 2/3] perf: imx_perf: add support for i.MX91 platform Xu Yang
2024-09-24 6:12 ` [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Xu Yang
@ 2024-09-24 16:27 ` Conor Dooley
2024-10-09 17:42 ` Frank Li
2024-10-24 12:25 ` Will Deacon
4 siblings, 0 replies; 15+ messages in thread
From: Conor Dooley @ 2024-09-24 16:27 UTC (permalink / raw)
To: Xu Yang
Cc: Frank.li, will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, namhyung, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, linux-arm-kernel, devicetree,
imx, linux-perf-users
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On Tue, Sep 24, 2024 at 02:12:49PM +0800, Xu Yang wrote:
> i.MX91 has a DDR Performance Monitor Unit which is compatible with i.MX93.
> This will add a compatible for i.MX91.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible
2024-09-24 6:12 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Xu Yang
` (2 preceding siblings ...)
2024-09-24 16:27 ` [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Conor Dooley
@ 2024-10-09 17:42 ` Frank Li
2024-10-24 12:25 ` Will Deacon
4 siblings, 0 replies; 15+ messages in thread
From: Frank Li @ 2024-10-09 17:42 UTC (permalink / raw)
To: Xu Yang
Cc: will, mark.rutland, robh, krzk+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, john.g.garry, james.clark, mike.leach, leo.yan,
peterz, mingo, acme, namhyung, alexander.shishkin, jolsa, irogers,
adrian.hunter, kan.liang, linux-arm-kernel, devicetree, imx,
linux-perf-users
On Tue, Sep 24, 2024 at 02:12:49PM +0800, Xu Yang wrote:
> i.MX91 has a DDR Performance Monitor Unit which is compatible with i.MX93.
> This will add a compatible for i.MX91.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> index 37e8b98f2cdc..8597ea625edb 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
> @@ -31,7 +31,9 @@ properties:
> - const: fsl,imx8dxl-ddr-pmu
> - const: fsl,imx8-ddr-pmu
> - items:
> - - const: fsl,imx95-ddr-pmu
> + - enum:
> + - fsl,imx91-ddr-pmu
> + - fsl,imx95-ddr-pmu
> - const: fsl,imx93-ddr-pmu
>
> reg:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible
2024-09-24 6:12 [PATCH 1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible Xu Yang
` (3 preceding siblings ...)
2024-10-09 17:42 ` Frank Li
@ 2024-10-24 12:25 ` Will Deacon
4 siblings, 0 replies; 15+ messages in thread
From: Will Deacon @ 2024-10-24 12:25 UTC (permalink / raw)
To: Frank.li, mark.rutland, robh, krzk+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, john.g.garry, james.clark, mike.leach,
leo.yan, peterz, mingo, acme, namhyung, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, Xu Yang
Cc: catalin.marinas, kernel-team, Will Deacon, linux-arm-kernel,
devicetree, imx, linux-perf-users
On Tue, 24 Sep 2024 14:12:49 +0800, Xu Yang wrote:
> i.MX91 has a DDR Performance Monitor Unit which is compatible with i.MX93.
> This will add a compatible for i.MX91.
>
>
Applied first two patches to will (for-next/perf), thanks!
[1/3] dt-bindings: perf: fsl-imx-ddr: Add i.MX91 compatible
https://git.kernel.org/will/c/0263a1e4f5dd
[2/3] perf: imx_perf: add support for i.MX91 platform
https://git.kernel.org/will/c/44798fe136dc
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 15+ messages in thread