[PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Sibi Sankar]

Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
is the speed binned variant of X1E80100 that supports turbo boost up to
4.3 Ghz. The initial support includes the following:

-DSPs
-Ethernet (RTL8125BG) over the pcie 5 instance.
-NVme
-Wifi
-USB-C ports

V3:
* Asked around and looked at the firmware, couldn't find a codename so
  will keep it as DEVKIT. Will update it if someone from the community
  finds something else.
* Update type c roles as reported by ucsi. [Dmitry]
* Update THUNDERCOMM to Thundercomm. [Dmitry]
* Update regulator names and sort Order. [Dmitry]
* Add x1e001DE devkit to the safe list.
* Mark regulator-nmve as boot enabled.


V2:
* Fix Ghz -> GHz  [Jeff]
* Pick up Ab tag from Rob.
* Use Vendor in ADSP/CDSP firmware path [Dmitry]
* Fix reserved gpios [Dmitry]
* Only port0 supports DRD update the dt accordingly [Dmitry]

Sibi Sankar (3):
  dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
  firmware: qcom: uefisecapp: Allow X1E Devkit devices
  arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

 .../devicetree/bindings/arm/qcom.yaml         |   6 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |   1 +
 4 files changed, 822 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts

-- 
2.34.1

[PATCH V3 1/3] dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows

[Sibi Sankar]

X1E001DE is the speed binned variant of X1E80100 that supports turbo
boost up to 4.3 GHz.

Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 0f18cb35c774..e672e6ecee56 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1056,6 +1056,12 @@ properties:
               - qcom,sm8650-qrd
           - const: qcom,sm8650
 
+      - items:
+          - enum:
+              - qcom,x1e001de-devkit
+          - const: qcom,x1e001de
+          - const: qcom,x1e80100
+
       - items:
           - enum:
               - lenovo,thinkpad-t14s
-- 
2.34.1

[PATCH V3 2/3] firmware: qcom: uefisecapp: Allow X1E Devkit devices

[Sibi Sankar]

Add X1E Devkit to the allowlist.

Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 478538604225..95815e64e1e6 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -1751,6 +1751,7 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
 	{ .compatible = "microsoft,romulus13", },
 	{ .compatible = "microsoft,romulus15", },
 	{ .compatible = "qcom,sc8180x-primus" },
+	{ .compatible = "qcom,x1e001de-devkit" },
 	{ .compatible = "qcom,x1e80100-crd" },
 	{ .compatible = "qcom,x1e80100-qcp" },
 	{ }
-- 
2.34.1

[PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

[Sibi Sankar]

Add initial support for x1e001de devkit platform. This includes:

-DSPs
-Ethernet (RTL8125BG) over the pcie 5 instance.
-NVme
-Wifi
-USB-C ports

Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---

v3:
* Update type c roles as reported by ucsi. [Dmitry]
* Update THUNDERCOMM to Thundercomm. [Dmitry]
* Update regulator names and sort Order. [Dmitry]
* Mark regulator-nmve as boot enabled.

 arch/arm64/boot/dts/qcom/Makefile            |   1 +
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 +++++++++++++++++++
 2 files changed, 815 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index ac199f809b0d..cb6c2d4ecd10 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -270,6 +270,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-hdk-display-card.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-hdk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-qrd.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e78100-lenovo-thinkpad-t14s.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e80100-asus-vivobook-s15.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e80100-crd.dtb
diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
new file mode 100644
index 000000000000..d31e78a8027a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -0,0 +1,814 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. X1E001DE Snapdragon Devkit for Windows";
+	compatible = "qcom,x1e001de-devkit", "qcom,x1e001de", "qcom,x1e80100";
+
+	aliases {
+		serial0 = &uart21;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	pmic-glink {
+		compatible = "qcom,x1e80100-pmic-glink",
+			     "qcom,sm8550-pmic-glink",
+			     "qcom,pmic-glink";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
+				    <&tlmm 123 GPIO_ACTIVE_HIGH>,
+				    <&tlmm 125 GPIO_ACTIVE_HIGH>;
+
+		/* Back panel port closer to the RJ45 connector */
+		connector@0 {
+			compatible = "usb-c-connector";
+			reg = <0>;
+			power-role = "dual";
+			data-role = "dual";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					pmic_glink_ss0_hs_in: endpoint {
+						remote-endpoint = <&usb_1_ss0_dwc3_hs>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					pmic_glink_ss0_ss_in: endpoint {
+						remote-endpoint = <&usb_1_ss0_qmpphy_out>;
+					};
+				};
+			};
+		};
+
+		/* Back panel port closer to the audio jack */
+		connector@1 {
+			compatible = "usb-c-connector";
+			reg = <1>;
+			power-role = "dual";
+			data-role = "host";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					pmic_glink_ss1_hs_in: endpoint {
+						remote-endpoint = <&usb_1_ss1_dwc3_hs>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					pmic_glink_ss1_ss_in: endpoint {
+						remote-endpoint = <&usb_1_ss1_qmpphy_out>;
+					};
+				};
+			};
+		};
+
+		/* Front panel port */
+		connector@2 {
+			compatible = "usb-c-connector";
+			reg = <2>;
+			power-role = "dual";
+			data-role = "host";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					pmic_glink_ss2_hs_in: endpoint {
+						remote-endpoint = <&usb_1_ss2_dwc3_hs>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					pmic_glink_ss2_ss_in: endpoint {
+						remote-endpoint = <&usb_1_ss2_qmpphy_out>;
+					};
+				};
+			};
+		};
+	};
+
+	reserved-memory {
+		linux,cma {
+			compatible = "shared-dma-pool";
+			size = <0x0 0x8000000>;
+			reusable;
+			linux,cma-default;
+		};
+	};
+
+	vreg_nvme: regulator-nvme {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_NVME_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&nvme_reg_en>;
+
+		regulator-boot-on;
+	};
+
+	vph_pwr: regulator-vph-pwr {
+		compatible = "regulator-fixed";
+
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vreg_wwan: regulator-wwan {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDX_VPH_PWR";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 221 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wwan_sw_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+};
+
+&apps_rsc {
+	regulators-0 {
+		compatible = "qcom,pm8550-rpmh-regulators";
+		qcom,pmic-id = "b";
+
+		vdd-bob1-supply = <&vph_pwr>;
+		vdd-bob2-supply = <&vph_pwr>;
+		vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>;
+		vdd-l2-l13-l14-supply = <&vreg_bob1>;
+		vdd-l5-l16-supply = <&vreg_bob1>;
+		vdd-l6-l7-supply = <&vreg_bob2>;
+		vdd-l8-l9-supply = <&vreg_bob1>;
+		vdd-l12-supply = <&vreg_s5j_1p2>;
+		vdd-l15-supply = <&vreg_s4c_1p8>;
+		vdd-l17-supply = <&vreg_bob2>;
+
+		vreg_bob1: bob1 {
+			regulator-name = "vreg_bob1";
+			regulator-min-microvolt = <3008000>;
+			regulator-max-microvolt = <3960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_bob2: bob2 {
+			regulator-name = "vreg_bob2";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <3008000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1b_1p8: ldo1 {
+			regulator-name = "vreg_l1b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2b_3p0: ldo2 {
+			regulator-name = "vreg_l2b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l4b_1p8: ldo4 {
+			regulator-name = "vreg_l4b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l5b_3p0: ldo5 {
+			regulator-name = "vreg_l5b_3p0";
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <3000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l6b_1p8: ldo6 {
+			regulator-name = "vreg_l6b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l7b_2p8: ldo7 {
+			regulator-name = "vreg_l7b_2p8";
+			regulator-min-microvolt = <2800000>;
+			regulator-max-microvolt = <2800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l8b_3p0: ldo8 {
+			regulator-name = "vreg_l8b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l9b_2p9: ldo9 {
+			regulator-name = "vreg_l9b_2p9";
+			regulator-min-microvolt = <2960000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l10b_1p8: ldo10 {
+			regulator-name = "vreg_l10b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l12b_1p2: ldo12 {
+			regulator-name = "vreg_l12b_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l13b_3p0: ldo13 {
+			regulator-name = "vreg_l13b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l14b_3p0: ldo14 {
+			regulator-name = "vreg_l14b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l15b_1p8: ldo15 {
+			regulator-name = "vreg_l15b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l16b_2p9: ldo16 {
+			regulator-name = "vreg_l16b_2p9";
+			regulator-min-microvolt = <2912000>;
+			regulator-max-microvolt = <2912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l17b_2p5: ldo17 {
+			regulator-name = "vreg_l17b_2p5";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <2504000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-1 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "c";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s4-supply = <&vph_pwr>;
+
+		vreg_s4c_1p8: smps4 {
+			regulator-name = "vreg_s4c_1p8";
+			regulator-min-microvolt = <1856000>;
+			regulator-max-microvolt = <2000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1c_1p2: ldo1 {
+			regulator-name = "vreg_l1c_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2c_0p8: ldo2 {
+			regulator-name = "vreg_l2c_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3c_0p8: ldo3 {
+			regulator-name = "vreg_l3c_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-2 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "d";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s4c_1p8>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_l1d_0p8: ldo1 {
+			regulator-name = "vreg_l1d_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2d_0p9: ldo2 {
+			regulator-name = "vreg_l2d_0p9";
+			regulator-min-microvolt = <912000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3d_1p8: ldo3 {
+			regulator-name = "vreg_l3d_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-3 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "e";
+
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+
+		vreg_l2e_0p8: ldo2 {
+			regulator-name = "vreg_l2e_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3e_1p2: ldo3 {
+			regulator-name = "vreg_l3e_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-4 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "f";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_s1f_0p7: smps1 {
+			regulator-name = "vreg_s1f_0p7";
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1f_1p0: ldo1 {
+			regulator-name = "vreg_l1f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2f_1p0: ldo2 {
+			regulator-name = "vreg_l2f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3f_1p0: ldo3 {
+			regulator-name = "vreg_l3f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-6 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "i";
+
+		vdd-l1-supply = <&vreg_s4c_1p8>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s1-supply = <&vph_pwr>;
+		vdd-s2-supply = <&vph_pwr>;
+
+		vreg_s1i_0p9: smps1 {
+			regulator-name = "vreg_s1i_0p9";
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s2i_1p0: smps2 {
+			regulator-name = "vreg_s2i_1p0";
+			regulator-min-microvolt = <1000000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1i_1p8: ldo1 {
+			regulator-name = "vreg_l1i_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2i_1p2: ldo2 {
+			regulator-name = "vreg_l2i_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3i_0p8: ldo3 {
+			regulator-name = "vreg_l3i_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-7 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "j";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s5-supply = <&vph_pwr>;
+
+		vreg_s5j_1p2: smps5 {
+			regulator-name = "vreg_s5j_1p2";
+			regulator-min-microvolt = <1256000>;
+			regulator-max-microvolt = <1304000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1j_0p8: ldo1 {
+			regulator-name = "vreg_l1j_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2j_1p2: ldo2 {
+			regulator-name = "vreg_l2j_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3j_0p8: ldo3 {
+			regulator-name = "vreg_l3j_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+};
+
+&pcie4 {
+	perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
+
+	pinctrl-0 = <&pcie4_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie4_phy {
+	vdda-phy-supply = <&vreg_l3i_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&pcie5 {
+	perst-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>;
+
+	vddpe-3v3-supply = <&vreg_wwan>;
+
+	pinctrl-0 = <&pcie5_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie5_phy {
+	vdda-phy-supply = <&vreg_l3i_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&pcie6a {
+	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
+
+	vddpe-3v3-supply = <&vreg_nvme>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie6a_default>;
+
+	status = "okay";
+};
+
+&pcie6a_phy {
+	vdda-phy-supply = <&vreg_l1d_0p8>;
+	vdda-pll-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&qupv3_0 {
+	status = "okay";
+};
+
+&qupv3_1 {
+	status = "okay";
+};
+
+&qupv3_2 {
+	status = "okay";
+};
+
+&remoteproc_adsp {
+	firmware-name = "qcom/x1e80100/Thundercomm/DEVKIT/qcadsp8380.mbn",
+			"qcom/x1e80100/Thundercomm/DEVKIT/adsp_dtbs.elf";
+
+	status = "okay";
+};
+
+&remoteproc_cdsp {
+	firmware-name = "qcom/x1e80100/Thundercomm/DEVKIT/qccdsp8380.mbn",
+			"qcom/x1e80100/Thundercomm/DEVKIT/cdsp_dtbs.elf";
+
+	status = "okay";
+};
+
+&smb2360_0_eusb2_repeater {
+	vdd18-supply = <&vreg_l3d_1p8>;
+	vdd3-supply = <&vreg_l2b_3p0>;
+};
+
+&smb2360_1_eusb2_repeater {
+	vdd18-supply = <&vreg_l3d_1p8>;
+	vdd3-supply = <&vreg_l14b_3p0>;
+};
+
+&smb2360_2 {
+	status = "okay";
+};
+
+&smb2360_2_eusb2_repeater {
+	vdd18-supply = <&vreg_l3d_1p8>;
+	vdd3-supply = <&vreg_l8b_3p0>;
+};
+
+&tlmm {
+	gpio-reserved-ranges = <44 4>; /* SPI (TPM) */
+
+	nvme_reg_en: nvme-reg-en-state {
+		pins = "gpio18";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	pcie4_default: pcie4-default-state {
+		clkreq-n-pins {
+			pins = "gpio147";
+			function = "pcie4_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio146";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio148";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	pcie5_default: pcie5-default-state {
+		clkreq-n-pins {
+			pins = "gpio150";
+			function = "pcie5_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio149";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio151";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	pcie6a_default: pcie6a-default-state {
+		clkreq-n-pins {
+			pins = "gpio153";
+			function = "pcie6a_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio152";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio154";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	wwan_sw_en: wwan-sw-en-state {
+		pins = "gpio221";
+		function = "gpio";
+		drive-strength = <4>;
+		bias-disable;
+	};
+};
+
+&uart21 {
+	compatible = "qcom,geni-debug-uart";
+	status = "okay";
+};
+
+&usb_1_ss0_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	phys = <&smb2360_0_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_1_ss0_qmpphy {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l1j_0p8>;
+
+	status = "okay";
+};
+
+&usb_1_ss0 {
+	status = "okay";
+};
+
+&usb_1_ss0_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+};
+
+&usb_1_ss0_dwc3_hs {
+	remote-endpoint = <&pmic_glink_ss0_hs_in>;
+};
+
+&usb_1_ss0_qmpphy_out {
+	remote-endpoint = <&pmic_glink_ss0_ss_in>;
+};
+
+&usb_1_ss1_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	phys = <&smb2360_1_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_1_ss1_qmpphy {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	status = "okay";
+};
+
+&usb_1_ss1 {
+	status = "okay";
+};
+
+&usb_1_ss1_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_1_ss1_dwc3_hs {
+	remote-endpoint = <&pmic_glink_ss1_hs_in>;
+};
+
+&usb_1_ss1_qmpphy_out {
+	remote-endpoint = <&pmic_glink_ss1_ss_in>;
+};
+
+&usb_1_ss2_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	phys = <&smb2360_2_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_1_ss2_qmpphy {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	status = "okay";
+};
+
+&usb_1_ss2 {
+	status = "okay";
+};
+
+&usb_1_ss2_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_1_ss2_dwc3_hs {
+	remote-endpoint = <&pmic_glink_ss2_hs_in>;
+};
+
+&usb_1_ss2_qmpphy_out {
+	remote-endpoint = <&pmic_glink_ss2_ss_in>;
+};
-- 
2.34.1

Re: [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

[Konrad Dybcio]

On 25.10.2024 2:32 PM, Sibi Sankar wrote:
> Add initial support for x1e001de devkit platform. This includes:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---

[...]

> +	vreg_nvme: regulator-nvme {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "VREG_NVME_3P3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&nvme_reg_en>;

these are backwards

otherwise lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Rob Herring (Arm)]

On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote:
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> V3:
> * Asked around and looked at the firmware, couldn't find a codename so
>   will keep it as DEVKIT. Will update it if someone from the community
>   finds something else.
> * Update type c roles as reported by ucsi. [Dmitry]
> * Update THUNDERCOMM to Thundercomm. [Dmitry]
> * Update regulator names and sort Order. [Dmitry]
> * Add x1e001DE devkit to the safe list.
> * Mark regulator-nmve as boot enabled.
> 
> 
> V2:
> * Fix Ghz -> GHz  [Jeff]
> * Pick up Ab tag from Rob.
> * Use Vendor in ADSP/CDSP firmware path [Dmitry]
> * Fix reserved gpios [Dmitry]
> * Only port0 supports DRD update the dt accordingly [Dmitry]
> 
> Sibi Sankar (3):
>   dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>   firmware: qcom: uefisecapp: Allow X1E Devkit devices
>   arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   6 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
>  drivers/firmware/qcom/qcom_scm.c              |   1 +
>  4 files changed, 822 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e001de-devkit.dtb' for 20241025123227.3527720-1-quic_sibis@quicinc.com:

arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long
	from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Jens Glathe]

On 25.10.24 14:32, Sibi Sankar wrote:
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
>
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
>
> V3:
> * Asked around and looked at the firmware, couldn't find a codename so
>    will keep it as DEVKIT. Will update it if someone from the community
>    finds something else.
> * Update type c roles as reported by ucsi. [Dmitry]
> * Update THUNDERCOMM to Thundercomm. [Dmitry]
> * Update regulator names and sort Order. [Dmitry]
> * Add x1e001DE devkit to the safe list.
> * Mark regulator-nmve as boot enabled.
>
>
> V2:
> * Fix Ghz -> GHz  [Jeff]
> * Pick up Ab tag from Rob.
> * Use Vendor in ADSP/CDSP firmware path [Dmitry]
> * Fix reserved gpios [Dmitry]
> * Only port0 supports DRD update the dt accordingly [Dmitry]
>
> Sibi Sankar (3):
>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>    firmware: qcom: uefisecapp: Allow X1E Devkit devices
>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
>
>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
>   drivers/firmware/qcom/qcom_scm.c              |   1 +
>   4 files changed, 822 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>
I have used this dt to bring up my Dev Kit, it is a great help. Thank you!

- Jens

link:
https://github.com/jglathe/linux_ms_dev_kit/wiki/Bringing-up-the-SnapDragon-Dev-Kit-for-Windows-with-Linux-%E2%80%90-without-working-display

Tested-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Marc Zyngier]

On Fri, 25 Oct 2024 13:32:24 +0100,
Sibi Sankar <quic_sibis@quicinc.com> wrote:
> 
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> V3:
> * Asked around and looked at the firmware, couldn't find a codename so
>   will keep it as DEVKIT. Will update it if someone from the community
>   finds something else.

My machine has the following information as part of its DMI tables:

Handle 0x0005, DMI type 1, 27 bytes
System Information
	Manufacturer: Qualcomm
	Product Name: Snapdragon-Devkit
	Version: 2.1
	Serial Number: 5
	UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291
	Wake-up Type: Power Switch
	SKU Number: 6
	Family: SCP_HAMOA

So I guess that Snapdragon-Devkit is another possible name. But given
that it is a bit of a mouthful, devkit, Devkit, or any other variation
on the case would work for me.

> * Update type c roles as reported by ucsi. [Dmitry]
> * Update THUNDERCOMM to Thundercomm. [Dmitry]
> * Update regulator names and sort Order. [Dmitry]
> * Add x1e001DE devkit to the safe list.
> * Mark regulator-nmve as boot enabled.
> 
> 
> V2:
> * Fix Ghz -> GHz  [Jeff]
> * Pick up Ab tag from Rob.
> * Use Vendor in ADSP/CDSP firmware path [Dmitry]
> * Fix reserved gpios [Dmitry]
> * Only port0 supports DRD update the dt accordingly [Dmitry]
> 
> Sibi Sankar (3):
>   dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>   firmware: qcom: uefisecapp: Allow X1E Devkit devices
>   arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   6 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
>  drivers/firmware/qcom/qcom_scm.c              |   1 +
>  4 files changed, 822 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts

FWIW, I'm running this as part of my KVM test rig with minor changes
to expose the SMMU and allow the ITS on pcie5, and things work as well
as you can expect. FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>
Tested-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Abel Vesa]

On 24-10-30 17:02:32, Marc Zyngier wrote:
> On Fri, 25 Oct 2024 13:32:24 +0100,
> Sibi Sankar <quic_sibis@quicinc.com> wrote:
> > 
> > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> > is the speed binned variant of X1E80100 that supports turbo boost up to
> > 4.3 Ghz. The initial support includes the following:
> > 
> > -DSPs
> > -Ethernet (RTL8125BG) over the pcie 5 instance.
> > -NVme
> > -Wifi
> > -USB-C ports
> > 
> > V3:
> > * Asked around and looked at the firmware, couldn't find a codename so
> >   will keep it as DEVKIT. Will update it if someone from the community
> >   finds something else.
> 
> My machine has the following information as part of its DMI tables:
> 
> Handle 0x0005, DMI type 1, 27 bytes
> System Information
> 	Manufacturer: Qualcomm
> 	Product Name: Snapdragon-Devkit
> 	Version: 2.1
> 	Serial Number: 5
> 	UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291
> 	Wake-up Type: Power Switch
> 	SKU Number: 6
> 	Family: SCP_HAMOA
> 
> So I guess that Snapdragon-Devkit is another possible name. But given
> that it is a bit of a mouthful, devkit, Devkit, or any other variation
> on the case would work for me.

The point was to have something unique A codename would be unique.
Naming it Snapdragon-Devkit (or just devkit) will be confusing since
there was already a 2023 devkit (from Microsoft) with the Snapdragon
8cx Gen 3, and probably the next compute platform will also have a devkit
as well. So probably "X Elite devkit" could be the right option..

> 
> > * Update type c roles as reported by ucsi. [Dmitry]
> > * Update THUNDERCOMM to Thundercomm. [Dmitry]
> > * Update regulator names and sort Order. [Dmitry]
> > * Add x1e001DE devkit to the safe list.
> > * Mark regulator-nmve as boot enabled.
> > 
> > 
> > V2:
> > * Fix Ghz -> GHz  [Jeff]
> > * Pick up Ab tag from Rob.
> > * Use Vendor in ADSP/CDSP firmware path [Dmitry]
> > * Fix reserved gpios [Dmitry]
> > * Only port0 supports DRD update the dt accordingly [Dmitry]
> > 
> > Sibi Sankar (3):
> >   dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
> >   firmware: qcom: uefisecapp: Allow X1E Devkit devices
> >   arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> > 
> >  .../devicetree/bindings/arm/qcom.yaml         |   6 +
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
> >  drivers/firmware/qcom/qcom_scm.c              |   1 +
> >  4 files changed, 822 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> 
> FWIW, I'm running this as part of my KVM test rig with minor changes
> to expose the SMMU and allow the ITS on pcie5, and things work as well
> as you can expect. FWIW:
> 
> Acked-by: Marc Zyngier <maz@kernel.org>
> Tested-by: Marc Zyngier <maz@kernel.org>
> 
> 	M.
> 
> -- 
> Without deviation from the norm, progress is not possible.

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Jens Glathe]

On 31.10.24 10:46, Abel Vesa wrote:
> On 24-10-30 17:02:32, Marc Zyngier wrote:
>> On Fri, 25 Oct 2024 13:32:24 +0100,
>> Sibi Sankar <quic_sibis@quicinc.com> wrote:
>>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
>>> is the speed binned variant of X1E80100 that supports turbo boost up to
>>> 4.3 Ghz. The initial support includes the following:
>>>
>>> -DSPs
>>> -Ethernet (RTL8125BG) over the pcie 5 instance.
>>> -NVme
>>> -Wifi
>>> -USB-C ports
>>>
>>> V3:
>>> * Asked around and looked at the firmware, couldn't find a codename so
>>>    will keep it as DEVKIT. Will update it if someone from the community
>>>    finds something else.
>> My machine has the following information as part of its DMI tables:
>>
>> Handle 0x0005, DMI type 1, 27 bytes
>> System Information
>> 	Manufacturer: Qualcomm
>> 	Product Name: Snapdragon-Devkit
>> 	Version: 2.1
>> 	Serial Number: 5
>> 	UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291
>> 	Wake-up Type: Power Switch
>> 	SKU Number: 6
>> 	Family: SCP_HAMOA
>>
>> So I guess that Snapdragon-Devkit is another possible name. But given
>> that it is a bit of a mouthful, devkit, Devkit, or any other variation
>> on the case would work for me.
> The point was to have something unique A codename would be unique.
> Naming it Snapdragon-Devkit (or just devkit) will be confusing since
> there was already a 2023 devkit (from Microsoft) with the Snapdragon
> 8cx Gen 3, and probably the next compute platform will also have a devkit
> as well. So probably "X Elite devkit" could be the right option..
As for The Windows Dev Kit 2023, dmidecode says this:

Handle 0x0009, DMI type 1, 27 bytes
System Information
     Manufacturer: Microsoft Corporation
     Product Name: Windows Dev Kit 2023
     Version: 124I:00097T:000M:0200000B:07
     Serial Number: 0F01C4F22373F6
     UUID: e4a4662c-8367-75d0-a54f-1d04bd404860
     Wake-up Type: Unknown
     SKU Number: 2043
     Family: Surface

That's also really a mouthful. In my patchset for it there were some
name / path changes, microsoft/blackrock it is now. Would be cool to
have short and unique names. In the end, whatever works and is unique.
Like those UUIDs?

>>> * Update type c roles as reported by ucsi. [Dmitry]
>>> * Update THUNDERCOMM to Thundercomm. [Dmitry]
>>> * Update regulator names and sort Order. [Dmitry]
>>> * Add x1e001DE devkit to the safe list.
>>> * Mark regulator-nmve as boot enabled.
>>>
>>>
>>> V2:
>>> * Fix Ghz -> GHz  [Jeff]
>>> * Pick up Ab tag from Rob.
>>> * Use Vendor in ADSP/CDSP firmware path [Dmitry]
>>> * Fix reserved gpios [Dmitry]
>>> * Only port0 supports DRD update the dt accordingly [Dmitry]
>>>
>>> Sibi Sankar (3):
>>>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>>>    firmware: qcom: uefisecapp: Allow X1E Devkit devices
>>>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
>>>
>>>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>>>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 814 ++++++++++++++++++
>>>   drivers/firmware/qcom/qcom_scm.c              |   1 +
>>>   4 files changed, 822 insertions(+)
>>>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>> FWIW, I'm running this as part of my KVM test rig with minor changes
>> to expose the SMMU and allow the ITS on pcie5, and things work as well
>> as you can expect. FWIW:
>>
>> Acked-by: Marc Zyngier <maz@kernel.org>
>> Tested-by: Marc Zyngier <maz@kernel.org>
>>
>> 	M.
>>
>> --
>> Without deviation from the norm, progress is not possible.

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Marc Zyngier]

On Thu, 31 Oct 2024 10:00:40 +0000,
Jens Glathe <jens.glathe@oldschoolsolutions.biz> wrote:
> 
> On 31.10.24 10:46, Abel Vesa wrote:
> > On 24-10-30 17:02:32, Marc Zyngier wrote:
> >> On Fri, 25 Oct 2024 13:32:24 +0100,
> >> Sibi Sankar <quic_sibis@quicinc.com> wrote:
> >>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> >>> is the speed binned variant of X1E80100 that supports turbo boost up to
> >>> 4.3 Ghz. The initial support includes the following:
> >>> 
> >>> -DSPs
> >>> -Ethernet (RTL8125BG) over the pcie 5 instance.
> >>> -NVme
> >>> -Wifi
> >>> -USB-C ports
> >>> 
> >>> V3:
> >>> * Asked around and looked at the firmware, couldn't find a codename so
> >>>    will keep it as DEVKIT. Will update it if someone from the community
> >>>    finds something else.
> >> My machine has the following information as part of its DMI tables:
> >> 
> >> Handle 0x0005, DMI type 1, 27 bytes
> >> System Information
> >> 	Manufacturer: Qualcomm
> >> 	Product Name: Snapdragon-Devkit
> >> 	Version: 2.1
> >> 	Serial Number: 5
> >> 	UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291
> >> 	Wake-up Type: Power Switch
> >> 	SKU Number: 6
> >> 	Family: SCP_HAMOA
> >> 
> >> So I guess that Snapdragon-Devkit is another possible name. But given
> >> that it is a bit of a mouthful, devkit, Devkit, or any other variation
> >> on the case would work for me.
> > The point was to have something unique A codename would be unique.
> > Naming it Snapdragon-Devkit (or just devkit) will be confusing since
> > there was already a 2023 devkit (from Microsoft) with the Snapdragon
> > 8cx Gen 3, and probably the next compute platform will also have a devkit
> > as well. So probably "X Elite devkit" could be the right option..

Odd, I didn't get that email.

My point was the the HW already comes with a full description as part
of the existing tables. If you really want something that is truly
unique to that platform and that can be used by a tool (be it
firmware, kernel or userspace) to understand what it is running on,
then you cannot have *less* information.

At the very least, you would need Manufacturer, Product Name, Version
and Family.

But does it really matter? I don't think it is *that* crucial. At the
end of the day, this is only used to pick the correct DT out of a set
for a given SoC, or worse case a family of SoCs that are closely
related.

> As for The Windows Dev Kit 2023, dmidecode says this:
> 
> Handle 0x0009, DMI type 1, 27 bytes
> System Information
>     Manufacturer: Microsoft Corporation
>     Product Name: Windows Dev Kit 2023
>     Version: 124I:00097T:000M:0200000B:07
>     Serial Number: 0F01C4F22373F6
>     UUID: e4a4662c-8367-75d0-a54f-1d04bd404860
>     Wake-up Type: Unknown
>     SKU Number: 2043
>     Family: Surface
> 
> That's also really a mouthful. In my patchset for it there were some
> name / path changes, microsoft/blackrock it is now. Would be cool to
> have short and unique names. In the end, whatever works and is unique.
> Like those UUIDs?

Are those actually per platform? or per unit? On my box, the serial
number is probably a dud. What does the UUID reports on your X1E box?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Jens Glathe]

On 31.10.24 13:29, Marc Zyngier wrote:
> On Thu, 31 Oct 2024 10:00:40 +0000,
> Jens Glathe <jens.glathe@oldschoolsolutions.biz> wrote:
>> On 31.10.24 10:46, Abel Vesa wrote:
>>> On 24-10-30 17:02:32, Marc Zyngier wrote:
>>>> On Fri, 25 Oct 2024 13:32:24 +0100,
>>>> Sibi Sankar <quic_sibis@quicinc.com> wrote:
>>>>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
>>>>> is the speed binned variant of X1E80100 that supports turbo boost up to
>>>>> 4.3 Ghz. The initial support includes the following:
>>>>>
>>>>> -DSPs
>>>>> -Ethernet (RTL8125BG) over the pcie 5 instance.
>>>>> -NVme
>>>>> -Wifi
>>>>> -USB-C ports
>>>>>
>>>>> V3:
>>>>> * Asked around and looked at the firmware, couldn't find a codename so
>>>>>     will keep it as DEVKIT. Will update it if someone from the community
>>>>>     finds something else.
>>>> My machine has the following information as part of its DMI tables:
>>>>
>>>> Handle 0x0005, DMI type 1, 27 bytes
>>>> System Information
>>>> 	Manufacturer: Qualcomm
>>>> 	Product Name: Snapdragon-Devkit
>>>> 	Version: 2.1
>>>> 	Serial Number: 5
>>>> 	UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291
>>>> 	Wake-up Type: Power Switch
>>>> 	SKU Number: 6
>>>> 	Family: SCP_HAMOA
>>>>
>>>> So I guess that Snapdragon-Devkit is another possible name. But given
>>>> that it is a bit of a mouthful, devkit, Devkit, or any other variation
>>>> on the case would work for me.
>>> The point was to have something unique A codename would be unique.
>>> Naming it Snapdragon-Devkit (or just devkit) will be confusing since
>>> there was already a 2023 devkit (from Microsoft) with the Snapdragon
>>> 8cx Gen 3, and probably the next compute platform will also have a devkit
>>> as well. So probably "X Elite devkit" could be the right option..
> Odd, I didn't get that email.
>
> My point was the the HW already comes with a full description as part
> of the existing tables. If you really want something that is truly
> unique to that platform and that can be used by a tool (be it
> firmware, kernel or userspace) to understand what it is running on,
> then you cannot have *less* information.
>
> At the very least, you would need Manufacturer, Product Name, Version
> and Family.
>
> But does it really matter? I don't think it is *that* crucial. At the
> end of the day, this is only used to pick the correct DT out of a set
> for a given SoC, or worse case a family of SoCs that are closely
> related.
>
>> As for The Windows Dev Kit 2023, dmidecode says this:
>>
>> Handle 0x0009, DMI type 1, 27 bytes
>> System Information
>>      Manufacturer: Microsoft Corporation
>>      Product Name: Windows Dev Kit 2023
>>      Version: 124I:00097T:000M:0200000B:07
>>      Serial Number: 0F01C4F22373F6
>>      UUID: e4a4662c-8367-75d0-a54f-1d04bd404860
>>      Wake-up Type: Unknown
>>      SKU Number: 2043
>>      Family: Surface
>>
>> That's also really a mouthful. In my patchset for it there were some
>> name / path changes, microsoft/blackrock it is now. Would be cool to
>> have short and unique names. In the end, whatever works and is unique.
>> Like those UUIDs?
> Are those actually per platform? or per unit? On my box, the serial
> number is probably a dud. What does the UUID reports on your X1E box?
>
> Thanks,
>
> 	M.
>
Looks like the UUIDs are System UUIDs (unique). They are not the same as
/etc/machine-id either.

X1E DevKit:

Handle 0x0005, DMI type 1, 27 bytes
System Information
     Manufacturer: Qualcomm
     Product Name: Snapdragon-Devkit
     Version: 2.1
     Serial Number: 5
     UUID: eadc72c0-a0bd-cced-025c-c3a1494d433c
     Wake-up Type: Power Switch
     SKU Number: 6
     Family: SCP_HAMOA


Second Windows Dev Kit 2023:

Handle 0x0009, DMI type 1, 27 bytes
System Information
     Manufacturer: Microsoft Corporation
     Product Name: Windows Dev Kit 2023
     Version: 124I:00097T:000M:0200000B:07
     Serial Number: 0F004PD22363F6
     UUID: 35b94307-ddb5-e0c5-1c9a-ffc43fdf60ba
     Wake-up Type: Unknown
     SKU Number: 2043
     Family: Surface

Looks like maybe using the manufacturer for directory and product name
for subdirectory could do. But that long name everywhere?

with best regards

Jens

Re: (subset) [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows

[Bjorn Andersson]

On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote:
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 
> [...]

Applied, thanks!

[2/3] firmware: qcom: uefisecapp: Allow X1E Devkit devices
      commit: 75837f0b2bc61c62c8326fe3a1eb9a100714cfd7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>