From: Stanislav Jakubek <stano.jakubek@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: power: supply: sc27xx-fg: document deprecated bat-detect-gpio
Date: Wed, 6 Nov 2024 08:19:58 +0100 [thread overview]
Message-ID: <ZysYnmWYTFzMBVMj@standask-GA-A55M-S2HP> (raw)
In-Reply-To: <atetahoyv7iz4hvw2avx6gs6kit6owvmfsniorkmzrqhl2gvgv@iwdz7uzcpxcy>
On Tue, Nov 05, 2024 at 10:03:16AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 04, 2024 at 02:03:58PM +0100, Stanislav Jakubek wrote:
> > While the bindings have always used the correct 'battery-detect-gpios'
> > property, the DTS and the Linux driver have been using the incorrect
> > 'bat-detect-gpio' property. Document this property and mark it
> > as deprecated.
>
> Well, I would just correct bindings instead - much less changes needed.
> Document 'bat-detect-gpios' (note the 's') and drop
> 'battery-detect-gpios'.
Hi Krzysztof,
this approach was preferred by one of the Spreadtrum maintainers [1],
so I did it this way.
[1] https://lore.kernel.org/lkml/CAAfSe-uC+G8iEk_37vBr3+dQsv4a4tTTsz11hUguVRnU=r+4qQ@mail.gmail.com/
Regards,
Stanislav
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-11-06 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 13:03 [PATCH v2 0/3] sc27xx-fuel-gauge: fix battery detect Stanislav Jakubek
2024-11-04 13:03 ` [PATCH v2 1/3] dt-bindings: power: supply: sc27xx-fg: document deprecated bat-detect-gpio Stanislav Jakubek
2024-11-05 9:03 ` Krzysztof Kozlowski
2024-11-06 7:19 ` Stanislav Jakubek [this message]
2024-11-06 11:10 ` Krzysztof Kozlowski
2024-11-07 2:50 ` Chunyan Zhang
2024-11-04 13:04 ` [PATCH v2 2/3] power: supply: sc27xx: Fix battery detect GPIO probe Stanislav Jakubek
2024-11-04 13:04 ` [PATCH v2 3/3] arm64: dts: sprd: Fix battery-detect-gpios property Stanislav Jakubek
2024-11-11 22:13 ` (subset) [PATCH v2 0/3] sc27xx-fuel-gauge: fix battery detect Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZysYnmWYTFzMBVMj@standask-GA-A55M-S2HP \
--to=stano.jakubek@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox