From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13FA91CC16C for ; Thu, 7 Nov 2024 07:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730963856; cv=none; b=siZQM8qDN5ucGO+BJuh4pJ4Q+M37t7Kd/0KrxJ6WDQE+9sYrvB4HlFOi4d1mjT9V8P4LdrNuYTWTRtitVqQv+W6oA3WNwgzfddLEqG0v8dHRGAzXlvoluo0jPBP3vzuQV3OrquJOYWzomZPmgvbgdCglN7MVtgH/wGN4NyhiFOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730963856; c=relaxed/simple; bh=pMTFpGhlQtDtxK49IKvVF6FBBM3QiommfkMVhzAskMg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bdpHhuAjUnHoZ7enJAtZEzRjn1ezvJ8Gw5w4k6fJJwyRepDCVEjj9vuKtBF0vY9QEfj8fVrq+M2NNUO153sFwRAXWcNQcJQJepkGQzw1iVpad/gLow2MhSxa6zLG+Ot2foQ/vG/CY5wPLWcKxFBJPC4Okvgus9xG4NDOD/doGFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OPoUaR2Q; arc=none smtp.client-ip=209.85.218.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OPoUaR2Q" Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-a9a850270e2so101456666b.0 for ; Wed, 06 Nov 2024 23:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730963852; x=1731568652; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=nbOrRriYh6w4F8LVkNHZr22RHexrNFjFKA4icR8e7Vs=; b=OPoUaR2QjF/le64kDXff1pVReBcS1YW6YvjDmyunb1UOtQW+EN9WzLUBHANyjsgFom 8NSGwY3gxsvP0ZsFeW8YSwxJrh3B/1aS3lSr8PsAhngMvO2Z6MWfj0vg/Pgn4ngm+M37 /rs+lXIxfqAEJ9GWeR/RPzKJ9tFv++ow4cyFoIMBDTfqG/iAT4j9MOOCFugGzEcEV3sS CRrL+1MVrmyGw0fBrEf+DwDg+FkTIQvzqfXKR/sTxpVUpx+38p3jah3sMOX9V9SffHWc NVWH0S5H4qQ7yWgx/3LC3nzVzf13nCsvsu4do1TSZr5N9EuhZ2VfkfpZEdn/tS5c7IZs YIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730963852; x=1731568652; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nbOrRriYh6w4F8LVkNHZr22RHexrNFjFKA4icR8e7Vs=; b=Wc2ZBepn46KK49ejoY6irYEqfvkHtgyXj0Urzor61CApC8vdi6YddPsgVt9HhMZ7mP YvN/WYXeN8ndWgHCUVLactQ9zpkrfuw4C/ARDZD+qg8QLkfHGVygd75qNwNQwpvjmESj j+F1aeneDhx3fXonKdIQE3I3PHt2JHe+u/YK/3Z/NkHRTI/4mhxr7/FeTz0g/ctb/gK4 71jCDBOKAyohBxEtAzWFSdpqVSlIErHzYgMTYUPkPqtaUbmlrHOjLL4gLznowpdCCHL/ P7xJGLOD4TJG7LrJuiS5xNGI4FuRx2UnSSLL42HFXZtp9VynTHKnaXu+6AiKkI2cXU0U 6obg== X-Forwarded-Encrypted: i=1; AJvYcCVAc1v/kuOPuchHZ0TjYvsOXExkdSq4obI0II5b87LP0pOWLDGCCh007+YV7TsbFHKt4e5KJ3TbpRQ4@vger.kernel.org X-Gm-Message-State: AOJu0Yy0FHacbyK2r7p5PUgOEJxihvNO4jszBPmXCK8LDLDujDNY15Jj vtoICTVlyGPABlljyqly2ycfpTmIE+R6/5iGGCXLIpDzZd78iO6+sKo2zRQL67Y= X-Google-Smtp-Source: AGHT+IFPT6mzuetQvJyLFc7e08zxC/5UPQxA/Xio6fkK4wjMcfEmL06ep3a65TdFRwza/k5rV5x/ew== X-Received: by 2002:a17:907:70d4:b0:a9e:b5d0:de6 with SMTP id a640c23a62f3a-a9eb5d00edemr628074966b.50.1730963852370; Wed, 06 Nov 2024 23:17:32 -0800 (PST) Received: from localhost (host-79-35-211-193.retail.telecomitalia.it. [79.35.211.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0defaefsm49539066b.164.2024.11.06.23.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 23:17:32 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 7 Nov 2024 08:17:58 +0100 To: Manivannan Sadhasivam Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v3 04/12] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1 Message-ID: References: <768d2307342e1054c58324a9d51957456dc82cbf.1730123575.git.andrea.porta@suse.com> <20241106145022.t7w2762t7zxpefc3@thinkpad> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241106145022.t7w2762t7zxpefc3@thinkpad> Hi Manivannan, On 14:50 Wed 06 Nov , Manivannan Sadhasivam wrote: > On Mon, Oct 28, 2024 at 03:07:21PM +0100, Andrea della Porta wrote: > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > > schema is intended as minimal support for the clock generator and > > gpio controller peripherals which are accessible through BAR1. > > > > Signed-off-by: Andrea della Porta > > --- > > .../devicetree/bindings/misc/pci1de4,1.yaml | 80 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 81 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > > > diff --git a/Documentation/devicetree/bindings/misc/pci1de4,1.yaml b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > new file mode 100644 > > index 000000000000..d66b2fc130d1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > @@ -0,0 +1,80 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/misc/pci1de4,1.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: RaspberryPi RP1 MFD PCI device > > + > > +maintainers: > > + - Andrea della Porta > > + > > +description: > > + The RaspberryPi RP1 is a PCI multi function device containing > > + peripherals ranging from Ethernet to USB controller, I2C, SPI > > + and others. > > + The peripherals are accessed by addressing the PCI BAR1 region. > > + > > +allOf: > > + - $ref: /schemas/pci/pci-ep-bus.yaml > > + > > +properties: > > + compatible: > > + additionalItems: true > > + maxItems: 3 > > + items: > > + - const: pci1de4,1 > > + > > + '#interrupt-cells': > > + const: 2 > > + description: > > + Specifies respectively the interrupt number and flags as defined > > + in include/dt-bindings/interrupt-controller/irq.h. > > + > > + interrupt-controller: true > > + > > +unevaluatedProperties: false > > + > > +required: > > + - compatible > > + - '#interrupt-cells' > > + - interrupt-controller > > + - pci-ep-bus@1 > > + > > +examples: > > + - | > > + pci { > > + #address-cells = <3>; > > + #size-cells = <2>; > > + > > + rp1@0,0 { > > + compatible = "pci1de4,1"; > > + ranges = <0x01 0x00 0x00000000 > > + 0x82010000 0x00 0x00 > > + 0x00 0x400000>; > > Could you please have the 'ranges' in a single line as used everywhere? > > - Mani Sure. Many thanks, Andrea > > > + #address-cells = <3>; > > + #size-cells = <2>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + > > + pci_ep_bus: pci-ep-bus@1 { > > + compatible = "simple-bus"; > > + ranges = <0xc0 0x40000000 > > + 0x01 0x00 0x00000000 > > + 0x00 0x00400000>; > > + dma-ranges = <0x10 0x00000000 > > + 0x43000000 0x10 0x00000000 > > + 0x10 0x00000000>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + rp1_clocks: clocks@c040018000 { > > + compatible = "raspberrypi,rp1-clocks"; > > + reg = <0xc0 0x40018000 0x0 0x10038>; > > + #clock-cells = <1>; > > + clocks = <&clk_rp1_xosc>; > > + clock-names = "xosc"; > > + }; > > + }; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index ccf123b805c8..2aea5a6166bd 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19384,6 +19384,7 @@ RASPBERRY PI RP1 PCI DRIVER > > M: Andrea della Porta > > S: Maintained > > F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml > > +F: Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml > > F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml > > F: include/dt-bindings/clock/rp1.h > > -- > > 2.35.3 > > > > -- > மணிவண்ணன் சதாசிவம்