Re: [PATCH v3 2/2] dt-bindings: input: gt7986u-spifw: Remove hid-report-addr property

[Charles Wang <charles.goodix@gmail.com>]

Hi Rob,

On Fri, Nov 08, 2024 at 10:13:50AM -0600, Rob Herring wrote:
> On Fri, Nov 08, 2024 at 08:03:11PM +0800, Charles Wang wrote:
> > Since all boards use the same address, drop the goodix,hid-report-addr
> > property and hardcode it in the driver as a default value.
> 
> Where's the driver change?
> 
> I don't see the point in defining this and then removing it in the next 
> patch.
>

Apologies for the confusion. The driver changes will be included in the next version.

>
> > 
> > Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> > ---
> >  .../devicetree/bindings/input/goodix,gt7986u-spifw.yaml    | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> > index 8105b9ce2..c9e346a60 100644
> > --- a/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> > +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u-spifw.yaml
> > @@ -36,11 +36,6 @@ properties:
> >    reset-gpios:
> >      maxItems: 1
> >  
> > -  goodix,hid-report-addr:
> > -    $ref: /schemas/types.yaml#/definitions/uint32
> > -    description:
> > -      The register address for retrieving HID report data.
> > -
> >    spi-max-frequency: true
> >  
> >  required:
> > @@ -48,7 +43,6 @@ required:
> >    - reg
> >    - interrupts
> >    - reset-gpios
> > -  - goodix,hid-report-addr
> 
> Dropping a required property is an ABI break.
> 
> A devicetree that passes with the schema will not work on current 
> kernels that require this property.
> 

Thank you for pointing this out. The next version will include the
necessary driver modifications.

> >  
> >  unevaluatedProperties: false
> >  
> > @@ -68,7 +62,6 @@ examples:
> >          interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
> >          reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
> >          spi-max-frequency = <10000000>;
> > -        goodix,hid-report-addr = <0x22c8c>;
> >        };
> >      };
> >  
> > -- 
> > 2.43.0
> > 

Best regards,
Charles